Re: [DISCUSS] KIP-747 Add support for basic aggregation APIs

Hi Alex, Responses below. On Fri, Jun 4, 2021 at 9:27 AM Alexandre Brasil wrote: > Hi Mohan, > > I like the idea of adding those methods to the API, but I'd like to make a > suggestion: > > Although the most used scenario for min() / max() might possibly be for > numeric values, I think they co

[VOTE] KIP-749: Add --files and --file-separator options to the ConsoleProducer

Hi all, I'd like to start a vote on KIP-749 to add two options (--files and --files-separator) to ConsoleProducer. https://cwiki.apache.org/confluence/display/KAFKA/KIP-749:+Add+--files+and+--file-separator+options+to+the+ConsoleProducer Thanks, Wenbing

[jira] [Created] (KAFKA-12900) JBOD: Partitions count calculation does not take into account topic name

Georgy created KAFKA-12900: -- Summary: JBOD: Partitions count calculation does not take into account topic name Key: KAFKA-12900 URL: https://issues.apache.org/jira/browse/KAFKA-12900 Project: Kafka

Re: [DISCUSS] KIP-390: Support Compression Level (rebooted)

Hi Ismael, Thanks for the reply. > So you're saying that reducing the buffer size didn't reduce the compression rate for codecs like lz4? Of course, there were some improvements in compressed size when I tried the 'buffer.size' option, but the gain was not significant. I tried several datasets,

Re: [DISCUSS] KIP-390: Support Compression Level (rebooted)

Thanks Dongjin. So you're saying that reducing the buffer size didn't reduce the compression rate for codecs like lz4? If so, that would suggest reducing the default value, but that seems odd. Ismael On Sat, Jun 5, 2021, 9:25 AM Dongjin Lee wrote: > Hello Kafka dev, > > I hope to reboot the dis

[VOTE] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

Hi all, I'd like to call for a vote on KIP-752: Support --bootstrap-server in ReplicaVerificationTool: https://cwiki.apache.org/confluence/display/KAFKA/KIP-752%3A+Support+--bootstrap-server+in+ReplicaVerificationTool Best, Dongjin -- *Dongjin Lee* *A hitchhiker in the mathematical world.*

[VOTE] KIP-390: Support Compression Level (rebooted)

Hi all, I'd like to open a voting thread for KIP-390: Support Compression Level (rebooted): https://cwiki.apache.org/confluence/display/KAFKA/KIP-390%3A+Support+Compression+Level Best, Dongjin -- *Dongjin Lee* *A hitchhiker in the mathematical world.* *github: gith

[DISCUSS] KIP-752: Support --bootstrap-server in ReplicaVerificationTool

Hello, Kafka dev, I hope to start the discussion of KIP-752: Support --bootstrap-server in ReplicaVerificationTool . It is the last piece of unifying connection name flag for the com

Re: [DISCUSS] KIP-745: Connect API to restart connector and tasks

Thanks for the review and feedback, Konstantine. I think I've addressed all of your concerns below. On Fri, Jun 4, 2021 at 7:55 PM Konstantine Karantasis wrote: > Thanks for the KIP Randall! > Really happy to see this feature coming along finally. Will indeed resolve > an unintuitive aspect of C

[jira] [Created] (KAFKA-12899) Support --bootstrap-server in ReplicaVerificationTool

Dongjin Lee created KAFKA-12899: --- Summary: Support --bootstrap-server in ReplicaVerificationTool Key: KAFKA-12899 URL: https://issues.apache.org/jira/browse/KAFKA-12899 Project: Kafka Issue Typ

[DISCUSS] KIP-390: Support Compression Level (rebooted)

Hello Kafka dev, I hope to reboot the discussion of KIP-390: Support Compression Level . It proposes to add a new option, 'compression.level', that controls the compression level. This KIP has been submitted m

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Done, KIP is now updated to reflect this. On Sat, Jun 5, 2021 at 4:29 PM Josep Prat wrote: > Hi Guozhang, > > Thanks for your review, let's exclude the "localThreadsMetadata returning > StreamsMetadata" change then. This way, as well, this KIP is completely > consistent on making those Metadata

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Hi Guozhang, Thanks for your review, let's exclude the "localThreadsMetadata returning StreamsMetadata" change then. This way, as well, this KIP is completely consistent on making those Metadata classes interfaces with internal implementations. I'll update the KIP document right away. Thanks for

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Hi Josep, I think the most significant change would be, "localThreadsMetadata" returns a StreamsMetadata instead of ThreadMetadata, and StreamsMetadata would expose a new API to return a set of ThreadMetadata. All others (including the repackaging and splitting of interface / impl) are minor inde

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #199

See Changes: -- [...truncated 473387 lines...] [2021-06-05T14:06:36.196Z] [INFO] [2021-06-05T14:06:36.196Z] [INFO] --- maven-archetype-plugin:3.2.0:generate (default-cli)

Re: [DISCUSS] KIP-746: Revise KRaft Metadata Records

Right, we are not supporting upgrade (as discussed earlier). However, since 2.8 was an official release that had the earlier versions of the records, I think it's good to bump the version when we make incompatible changes. For documentation purposes, it's good to be able to see the differences v

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

A summary of the changes from previous version can be seen under Public Interfaces --> UPDATE On Sat, Jun 5, 2021 at 1:39 PM Josep Prat wrote: > Hi Guozhang, > I updated the KIP with, but I'm not so sure about your point 1, as from > the user's perspective, the API available to them will be real

Re: [DISCUSS] KIP-744: Migrate TaskMetadata to interface with internal implementation

A summary of the changes from previous version can be seen under Public Interfaces --> UPDATE On Sat, Jun 5, 2021 at 1:42 PM Josep Prat wrote: > Hi all, > > During the vote thread there was a request to extend this KIP to be > aligned with https://issues.apache.org/jira/browse/KAFKA-12370. > Dis

Re: [DISCUSS] KIP-744: Migrate TaskMetadata to interface with internal implementation

Hi all, During the vote thread there was a request to extend this KIP to be aligned with https://issues.apache.org/jira/browse/KAFKA-12370. Disucssion point is here: https://lists.apache.org/x/thread.html/rafa347f2c0f0bddb253c1ddc8d2817d1f04d500bb96366a4f6ec9482@%3Cdev.kafka.apache.org%3E Pasting

Re: [VOTE] KIP-744: Migrate TaskMetadata and ThreadMetadata to an interface with internal implementation

Hi Guozhang, I updated the KIP with, but I'm not so sure about your point 1, as from the user's perspective, the API available to them will be really different. If you think it's fine to introduce this change for the users, I'm happy to do that. If not, I can revert my KIP to remove your point 1).