Re: [ANNOUNCE] Apache Kafka 3.0.0

2021-09-22 Thread Dongjin Lee
Thank you for your hard work, Konstantine!! Best, Dongjin On Thu, Sep 23, 2021 at 1:14 AM Guozhang Wang wrote: > Kudos to Konstantine! Congrats to everyone. > > On Tue, Sep 21, 2021 at 9:01 AM Konstantine Karantasis < > kkaranta...@apache.org> wrote: > > > The Apache Kafka community is pleased

[jira] [Created] (KAFKA-13319) Do not send AddOffsetsToTxn/TxnOffsetCommit if offsets map is empty

2021-09-22 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-13319: --- Summary: Do not send AddOffsetsToTxn/TxnOffsetCommit if offsets map is empty Key: KAFKA-13319 URL: https://issues.apache.org/jira/browse/KAFKA-13319 Project:

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #490

2021-09-22 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-775: Custom partitioners in foreign key joins

2021-09-22 Thread John Roesler
Hi Victoria, Here's the other conern I mentioned. I didn't bother bringing it up before because it would be obviated by the last proposal. I'm wondering about the need to add four new overloads and a new config object. We already have 20 KTable#join overloads, out of a total of 47 KTable

Re: [DISCUSS] KIP-775: Custom partitioners in foreign key joins

2021-09-22 Thread John Roesler
Thanks, Guozhang! I agree it would be bigger in scope to approach it that way. We certainly would need to implement a way for the partitioner to flow down the topology, like we do with serdes and grace period information. It's not super complex, but not trivial either. I think we've always been

Re: [DISCUSS] KIP-775: Custom partitioners in foreign key joins

2021-09-22 Thread Guozhang Wang
Thanks Victoria for writing the KIP! I think this is a miss when we designed KIP-213 and should be fixed in syntax. Regarding how large its scope should be, here's my thoughts: 1) Today Streams does not take any indicator on how the input stream/table are partitioned, instead it simply assumes

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #489

2021-09-22 Thread Apache Jenkins Server
See

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #488

2021-09-22 Thread Apache Jenkins Server
See Changes: -- [...truncated 470701 lines...] [2021-09-22T18:29:51.054Z] > Task :streams:compileJava UP-TO-DATE [2021-09-22T18:29:51.054Z] > Task :streams:classes

Re: [DISCUSS] KIP-774: Deprecate public access to Admin client's *Result constructors

2021-09-22 Thread Tom Bentley
Hi Ismael, These are all fair questions. I did a quick review of how these constructors have changed. There are a few cases where extra constructor parameters were added, so overloading the constructor would've been a trivial way to be backwards compatible. The more interesting cases are those

Re: [DISCUSS] KIP-775: Custom partitioners in foreign key joins

2021-09-22 Thread John Roesler
Thanks for the KIP, Victoria! This is a great catch. As fas as my memory serves, we totally missed this case in the design of FK joins. tl;dr: I'm wondering if it might be better to instead introduce a way to specify the partitioning scheme when we create a KTable and then just use it when we

[jira] [Created] (KAFKA-13318) Add jmh benchmarks for MetadataCache#topicNamesToIds

2021-09-22 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-13318: Summary: Add jmh benchmarks for MetadataCache#topicNamesToIds Key: KAFKA-13318 URL: https://issues.apache.org/jira/browse/KAFKA-13318 Project: Kafka Issue

Re: [ANNOUNCE] Apache Kafka 3.0.0

2021-09-22 Thread Guozhang Wang
Kudos to Konstantine! Congrats to everyone. On Tue, Sep 21, 2021 at 9:01 AM Konstantine Karantasis < kkaranta...@apache.org> wrote: > The Apache Kafka community is pleased to announce the release for Apache > Kafka 3.0.0 > > It is a major release that includes many new features, including: > > *

[jira] [Created] (KAFKA-13317) Kafka brokers can't communicate with each other, reports Error sending fetch request , java.io.IOException: Connection to 2 was disconnected before the response was read

2021-09-22 Thread priya Vijay (Jira)
priya Vijay created KAFKA-13317: --- Summary: Kafka brokers can't communicate with each other, reports Error sending fetch request , java.io.IOException: Connection to 2 was disconnected before the response was read Key: KAFKA-13317

Re: [DISCUSS] KIP-775: Custom partitioners in foreign key joins

2021-09-22 Thread Bill Bejeck
Hi Victoria, Thanks for the KIP; this is a beneficial addition. I'm a +1 on the KIP and the changes made: - Using a config object TableJoined - Limiting the static methods to two I have an additional "wild" thought about rolling the `Function foreignKeyExtractor` and `Materialized>` into

Re: [DISCUSS] KIP-775: Custom partitioners in foreign key joins

2021-09-22 Thread Victoria Xia
Thanks, Matthias. > > The existing methods which accept Named will be marked for deprecation in 4.0. > We can skip `in 4.0`. (1) The next release will be 3.1 (not 4.0) and (2) a KIP could always slip into a future release. This was actually a typo -- I meant that the methods will be marked for

[jira] [Created] (KAFKA-13316) Convert CreateTopicsRequestWithPolicyTest to use ClusterTest

2021-09-22 Thread dengziming (Jira)
dengziming created KAFKA-13316: -- Summary: Convert CreateTopicsRequestWithPolicyTest to use ClusterTest Key: KAFKA-13316 URL: https://issues.apache.org/jira/browse/KAFKA-13316 Project: Kafka

Re: [DISCUSS] KIP-714: Client metrics and observability

2021-09-22 Thread Magnus Edenhill
Den tis 21 sep. 2021 kl 06:58 skrev Colin McCabe : > On Mon, Sep 20, 2021, at 17:35, Feng Min wrote: > > Thanks Magnus & Colin for the discussion. > > > > Based on KIP-714's stateless design, Client can pretty much use any > > connection to any broker to send metrics. We are not associating >

Re: [DISCUSS] KIP-714: Client metrics and observability

2021-09-22 Thread Magnus Edenhill
Den mån 20 sep. 2021 kl 20:41 skrev Colin McCabe : > On Tue, Sep 14, 2021, at 00:47, Magnus Edenhill wrote: > > Thanks for your feedback Colin, see my updated proposal below. > > ... > > Hi Magnus, > > Thanks for the update. > > > > > Splitting up the API into separate data and control requests

[jira] [Resolved] (KAFKA-13302) [IEP-59] Support not default page size

2021-09-22 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikolay Izhikov resolved KAFKA-13302. - Resolution: Invalid Sorry for any inconvinience. This issue should go to Ignite