Jenkins build is back to normal : Kafka » kafka-2.6-jdk8 #144

2021-12-21 Thread Apache Jenkins Server
See

[jira] [Created] (KAFKA-13562) Mirror Maker 2 Negative Offsets

2021-12-21 Thread David Urton (Jira)
David Urton created KAFKA-13562: --- Summary: Mirror Maker 2 Negative Offsets Key: KAFKA-13562 URL: https://issues.apache.org/jira/browse/KAFKA-13562 Project: Kafka Issue Type: Bug

Re: [DISCUSS] KIP-811 Add separate delete.interval.ms to Kafka Streams

2021-12-21 Thread Nick Telford
Hi everyone, Thanks for your feedback. I've made the suggested changes to the KIP (1, 2, 3 and 5). For the new name, I've chosen repartition.purge.interval.ms, as I felt it struck a good balance between being self-descriptive and concise. Please let me know if you'd prefer something else. On

[jira] [Created] (KAFKA-13561) Consider deprecating `StreamsBuilder#build(props)` function

2021-12-21 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-13561: - Summary: Consider deprecating `StreamsBuilder#build(props)` function Key: KAFKA-13561 URL: https://issues.apache.org/jira/browse/KAFKA-13561 Project: Kafka

Re: [DISCUSS] KIP-591: Add Kafka Streams config to set default state store

2021-12-21 Thread Guozhang Wang
Thanks Luke, I do not have any major comments on the wiki any more. BTW thanks for making the "public StreamsBuilder(final TopologyConfig topologyConfigs)" API public now, I think it will benefit a lot of future works! I think with the new API, we can deprecate the `build(props)` function in

Re: [DISCUSS] KIP-802: Validation Support for Kafka Connect SMT Options

2021-12-21 Thread Chris Egerton
Hi Gunnar, Thanks, this looks great. I'm ready to cast a non-binding on the vote thread when it comes. One small non-blocking nit: I like that you call out that the new validation steps will take place when a connector gets registered or updated. IMO this is important enough to be included in

Jenkins build is unstable: Kafka » Kafka Branch Builder » 3.1 #42

2021-12-21 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-802: Validation Support for Kafka Connect SMT Options

2021-12-21 Thread Gunnar Morling
Hey Chris, Thanks a lot for reviewing this KIP and your comments! Some more answers inline. Am Di., 7. Dez. 2021 um 23:49 Uhr schrieb Chris Egerton : > Hi Gunnar, > > Thanks for the KIP! The section on backwards compatibility is especially > impressive and was enjoyable to read. > Excellent,

[jira] [Created] (KAFKA-13560) Load indexes and data in async manner in the critical path of replica fetcher threads.

2021-12-21 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-13560: -- Summary: Load indexes and data in async manner in the critical path of replica fetcher threads. Key: KAFKA-13560 URL: https://issues.apache.org/jira/browse/KAFKA-13560

Re: [DISCUSS] KIP-808: Add support for unix epoch precision in TimestampConverter SMT

2021-12-21 Thread Julien Chanaud
Hi everyone, Bumping this KIP discussion. It's a small change, entirely backward compatible and I'd love your feedback on it. Thanks, Julien Le jeu. 9 déc. 2021 à 21:56, Julien Chanaud a écrit : > > Hi everyone, > > I would like to start a discussion for KIP-808 >

Re: [DISCUSS] KIP-811 Add separate delete.interval.ms to Kafka Streams

2021-12-21 Thread Luke Chen
Thanks, Bruno. I agree my point 4 is more like PR discussion, not KIP discussion. @Nick , please update my point 4 in PR directly. Thank you. Luke On Tue, Dec 21, 2021 at 7:24 PM Bruno Cadonna wrote: > Hi Nick, > > Thank you for the KIP! > > I agree on points 1, 2, and 3. I am not sure

Re: [DISCUSS] KIP-811 Add separate delete.interval.ms to Kafka Streams

2021-12-21 Thread Bruno Cadonna
Hi Nick, Thank you for the KIP! I agree on points 1, 2, and 3. I am not sure about point 4. I agree that we should update the docs for commit.interval.ms but I am not sure if this needs to mentioned in the KIP. That seems to me more a PR discussion. Also on point 2, I agree that we need to

MDC context for Kafka Streams

2021-12-21 Thread Maks Usanin
Hi team. My current task is updating MDC context for Kafka Streams. Is it possible to update MDC context per thread and reset to original MDC context after thread is finished execution ? Does Kafka Streams support this? any ideas .. Thanks

Re: [DISCUSS] KIP-811 Add separate delete.interval.ms to Kafka Streams

2021-12-21 Thread Luke Chen
Hi Nick, Thanks for the KIP! In addition to Sophie's comments, I have one more to this KIP: 3. I think you should mention the behavior change *explicitly* in "Compatibility" section. I know you already mentioned it in KIP, in the benefit way. But I think in this section, we should clearly point

Build failed in Jenkins: Kafka » Kafka Branch Builder » 3.1 #41

2021-12-21 Thread Apache Jenkins Server
See Changes: -- [...truncated 501411 lines...] [2021-12-21T09:54:41.892Z] > Task :raft:testClasses UP-TO-DATE [2021-12-21T09:54:41.892Z] > Task :connect:json:testJar

Re: [DISCUSS] KIP-719: Add Log4J2 Appender

2021-12-21 Thread Dongjin Lee
Hi Mickael, > In the meantime, you may want to bump the VOTE thread too. Sure, I just reset the voting thread with a brief context. Thanks, Dongjin On Tue, Dec 21, 2021 at 2:13 AM Mickael Maison wrote: > Thanks Dongjin! > > I'll take a look soon. > In the meantime, you may want to bump the

[VOTE] KIP-719: Deprecate Log4J Appender

2021-12-21 Thread Dongjin Lee
Hi All, I hope to reboot the voting for KIP-719: Deprecate Log4J Appender. https://cwiki.apache.org/confluence/display/KAFKA/KIP-719%3A+Deprecate+Log4J+Appender Here is some context: the purpose of this proposal is to remove log4j-appender from the dependency, and initially, the proposal