Re: [DISCUSS] KIP-792: Add "generation" field into consumer protocol

2022-02-21 Thread David Jacot
Thanks, Luke! Le mar. 22 févr. 2022 à 08:02, Luke Chen a écrit : > Hi David, > > Thanks for the comment. > I've updated the KIP, to add the method will be added into `Subscription` > class: > > // new added, the generationId getter > public int generationId() { > return generationId; > } > >

Re: [VOTE] KIP-815: Support max-timestamp in GetOffsetShell

2022-02-21 Thread Luke Chen
Hi Ziming, Thanks for the KIP! I'm +1 (binding) Luke On Tue, Feb 22, 2022 at 2:56 PM David Jacot wrote: > For reference, here is the KIP: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-815%3A++Support+max-timestamp+in+GetOffsetShell > > Thanks for the KIP! +1 (binding) > > Best, > D

Re: [DISCUSS] KIP-792: Add "generation" field into consumer protocol

2022-02-21 Thread Luke Chen
Hi David, Thanks for the comment. I've updated the KIP, to add the method will be added into `Subscription` class: // new added, the generationId getter public int generationId() { return generationId; } Thank you. Luke On Mon, Feb 21, 2022 at 5:24 PM David Jacot wrote: > Hi Luke, > > I a

Re: [VOTE] KIP-815: Support max-timestamp in GetOffsetShell

2022-02-21 Thread David Jacot
For reference, here is the KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-815%3A++Support+max-timestamp+in+GetOffsetShell Thanks for the KIP! +1 (binding) Best, David Le mar. 22 févr. 2022 à 04:03, deng ziming a écrit : > Hey all, I'm starting the voting on KIP-815. > > This suppor

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #709

2022-02-21 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-815: Replace KafkaConsumer with AdminClient in GetOffsetShell

2022-02-21 Thread deng ziming
Thank you David, I started a new one and let’s close this. Best, Ziming Deng > On Feb 21, 2022, at 5:31 PM, David Jacot wrote: > > Thanks for the update. LGTM. > > The vote thread looks weird. Could you check or > perhaps create a new one with the latest title? > > Best, > David > > On Fri,

[VOTE] KIP-815: Support max-timestamp in GetOffsetShell

2022-02-21 Thread deng ziming
Hey all, I'm starting the voting on KIP-815. This supports a new OffsetSpec in GetOffsetShell so that we can easily determine the offset and timestamp of the message with the largest timestamp on a partition. This seems a simple change but replaced KafkaConsumer with AdminClient in GetOffsetShe

[jira] [Created] (KAFKA-13679) Superfluous node disconnected logs

2022-02-21 Thread Philip Bourke (Jira)
Philip Bourke created KAFKA-13679: - Summary: Superfluous node disconnected logs Key: KAFKA-13679 URL: https://issues.apache.org/jira/browse/KAFKA-13679 Project: Kafka Issue Type: Bug

[jira] [Created] (KAFKA-13678) 2nd punctuation using STREAM_TIME does not respect scheduled interval

2022-02-21 Thread Lorenzo Cagnatel (Jira)
Lorenzo Cagnatel created KAFKA-13678: Summary: 2nd punctuation using STREAM_TIME does not respect scheduled interval Key: KAFKA-13678 URL: https://issues.apache.org/jira/browse/KAFKA-13678 Project

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #708

2022-02-21 Thread Apache Jenkins Server
See

Re: [VOTE] KIP-797: Accept duplicate listener on port for IPv4/IPv6

2022-02-21 Thread David Jacot
Hi Matthew, Thanks for the KIP. I have a few minor comments: 1. In the public interface section, could we spell out the configurations that we are changing with this KIP? The name does not change but the semantic is so it is good to be clear. 2. In the proposed changes section, I would rather me

Re: [VOTE] KIP-815: Replace KafkaConsumer with AdminClient in GetOffsetShell

2022-02-21 Thread David Jacot
Thanks for the update. LGTM. The vote thread looks weird. Could you check or perhaps create a new one with the latest title? Best, David On Fri, Feb 11, 2022 at 2:57 PM deng ziming wrote: > > David, Thank you for pointing out this. > > After some time, I sorted out the main configurations, the

[jira] [Created] (KAFKA-13677) version 3.0.0 Processor implementation uses parameter record (restricted identifier)

2022-02-21 Thread Jira
Aljoša Vrbanac created KAFKA-13677: -- Summary: version 3.0.0 Processor implementation uses parameter record (restricted identifier) Key: KAFKA-13677 URL: https://issues.apache.org/jira/browse/KAFKA-13677

Re: [DISCUSS] KIP-792: Add "generation" field into consumer protocol

2022-02-21 Thread David Jacot
Hi Luke, I apologize for my late reply. I was out for a while. Coming back to my previous point, could you also spell out the new method(s) that we need to add to the Subscription class? Thanks, David On Mon, Feb 14, 2022 at 6:28 PM Guozhang Wang wrote: > > Thanks Luke, no more comments from m

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #707

2022-02-21 Thread Apache Jenkins Server
See