Re: [DISCUSS] KIP-847: Add ProducerCount metrics

2022-06-29 Thread Luke Chen
Hi Artem, Thanks for the update. LGTM. Luke On Thu, Jun 30, 2022 at 6:51 AM Artem Livshits wrote: > Thank you for your feedback. I've updated the KIP to elaborate on the > motivation and provide some background on producer ids and how we measure > them. > > Also, after some thinking and

Re: [DISCUSS] KIP-847: Add ProducerCount metrics

2022-06-29 Thread Artem Livshits
Thank you for your feedback. I've updated the KIP to elaborate on the motivation and provide some background on producer ids and how we measure them. Also, after some thinking and discussing it offline with some folks, I think that we don't really need partitioner level metrics. We can use

Re: [DISCUSS] KIP-842: Add richer group offset reset mechanisms

2022-06-29 Thread Matthew Howlett
My first reaction also is that the proposed configuration is surely too complicated. It seems like an ideal solution from a usability perspective (always a good place to start) would be if the consumer just automatically behaved in this way. To make that work: 1. auto.offset.reset=latest would

Re: [VOTE] KIP-825: introduce a new API to control when aggregated results are produced

2022-06-29 Thread Hao Li
Hi Dev Team, Just want to inform you here that we made an update to this KIP. To implement emit final in Session Window aggregation, we augment the `SessionStore` by adding an public API to range query from earliest session end time to latest session end time. API is like this: ``` public

Potential bug for forwarded request time cost metrics

2022-06-29 Thread Feiyan Yu
Howdy! It seems like `requestDequeueTimeNanos` is ignored when handling an envelope request, which could lead to `requestDequeueTimeNanos` ending with "-1", so that the metric,`LocalTimeMs` is not correct. I created an issue related to this together with a tiny PR. issue:

[GitHub] [kafka-site] bbejeck commented on pull request #406: Add Qudosoft to powered-by

2022-06-29 Thread GitBox
bbejeck commented on PR #406: URL: https://github.com/apache/kafka-site/pull/406#issuecomment-1170082018 Hi @StephanZimmermann if you can rebase this PR we'll get this merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka-site] bbejeck commented on pull request #320: Update powered-by.html used by percentage

2022-06-29 Thread GitBox
bbejeck commented on PR #320: URL: https://github.com/apache/kafka-site/pull/320#issuecomment-1170078043 Thanks @JaviOverflow for the contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka-site] bbejeck commented on pull request #320: Update powered-by.html used by percentage

2022-06-29 Thread GitBox
bbejeck commented on PR #320: URL: https://github.com/apache/kafka-site/pull/320#issuecomment-117005 merged #320 into asf-site -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka-site] bbejeck merged pull request #320: Update powered-by.html used by percentage

2022-06-29 Thread GitBox
bbejeck merged PR #320: URL: https://github.com/apache/kafka-site/pull/320 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [kafka-site] bbejeck commented on pull request #413: Add Covage to powered-by

2022-06-29 Thread GitBox
bbejeck commented on PR #413: URL: https://github.com/apache/kafka-site/pull/413#issuecomment-1170063176 merged #413 into asf-site -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka-site] bbejeck merged pull request #413: Add Covage to powered-by

2022-06-29 Thread GitBox
bbejeck merged PR #413: URL: https://github.com/apache/kafka-site/pull/413 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [DISCUSS] KIP-821: Connect Transforms support for nested structures

2022-06-29 Thread Jorge Esteban Quilcate Otoya
Thanks Chris! I have updated the KIP to include this fix. I will keep the array as a potential improvement at the moment, and out of the scope of this KIP. Thanks, Jorge. On Tue, 28 Jun 2022 at 23:19, Chris Egerton wrote: > Hi Jorge, > > Apologies for the long delay, had my own KIP-related

Re: [DISCUSS] KIP-842: Add richer group offset reset mechanisms

2022-06-29 Thread David Jacot
Thanks for the KIP. I read it and I am also worried by the complexity of the new configurations. They are not easy to grasp. I need to digest it a bit more, I think. Best, David Le mer. 29 juin 2022 à 02:25, Matthias J. Sax a écrit : > Thanks for the KIP. > > I don't think I fully digested

[GitHub] [kafka-site] ZachLC commented on pull request #413: Add Covage to powered-by

2022-06-29 Thread GitBox
ZachLC commented on PR #413: URL: https://github.com/apache/kafka-site/pull/413#issuecomment-1169764733 > HI @ZachLC can you rebase this PR and we can get this merged? Hi @bbejeck, Sure. thanks. -- This is an automated message from the Apache Git Service. To respond to the

Re: [DISCUSS] KIP-847: Add ProducerCount metrics

2022-06-29 Thread Luke Chen
Hi Artem, Could you elaborate more in the motivation section? I'm interested to know what kind of scenarios this metric can benefit for. What could it bring to us when a topic partition has 100 ProducerIdCount VS another topic partition has 10 ProducerIdCount? Thank you. Luke On Wed, Jun 29,

[GitHub] [kafka-site] d-t-w commented on pull request #372: Add kPow (https://www.kpow.io) to the powered-by page

2022-06-29 Thread GitBox
d-t-w commented on PR #372: URL: https://github.com/apache/kafka-site/pull/372#issuecomment-1169631953 Thanks @bbejeck much appreciated :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the