Re: [DISCUSS] KIP-844: Transactional State Stores

2022-08-07 Thread Guozhang Wang
Hello Alex, I made a pass on your WIP PR (thanks for putting it up! It helps for me to understand many details). And here are some more thoughts: 1. I looked over all the places where `.transactional()` is called, and I still think that they are not needed, and hence we could consider removing

Re: [DISCUSS] KIP-857: Streaming recursion in Kafka Streams

2022-08-07 Thread Sagar
Hey Nick, Since we are adding a new method to the public interface, we should probably decide the necessity of doing so, more so when you say that it's an alternative to something already existing. My suggestion would be to still modify the KIP around the new API, highlight how it's an

Re: [DISCISS] KIP-860: Add client-provided option to guard against unintentional replication factor change during partition reassignments

2022-08-07 Thread Stanislav Kozlovski
Thank you for the reviews. Vikas, > > In the case of an already-reassigning partition being reassigned again, the validation compares the targetReplicaSet size of the reassignment to the targetReplicaSet size of the new reassignment and throws if those differ. > Can you add more detail to this,

Re: Jira Access

2022-08-07 Thread Mickael Maison
Hi Madhu, Done! Thanks for your interest in Apache Kafka. Mickael On Sat, Aug 6, 2022 at 7:26 PM Madhusudhan Reddy Vennapusa wrote: > > Hi Team, > > Please add me to the contributor list, my Jira account username: *sudhan499* > > Regards, > Madhu