Re: [Streams] GlobalStateManagerImpl#restoreState locally restores previously deleted records

2022-12-08 Thread Patrick D’Addona
> In your case you also delete if the value is not null and if the value > not-equals "deleteme", right? Ie, you use non-tombstone records as deletes > what is just not allowed/supported. The "deleteme" String was only for testing, the issue also happens without it, i.e. if there is a "real"

Build failed in Jenkins: Kafka » Kafka Branch Builder » 3.1 #137

2022-12-08 Thread Apache Jenkins Server
See Changes: -- [...truncated 440141 lines...] [2022-12-08T22:15:13.639Z] [2022-12-08T22:15:13.639Z] You can use '--warning-mode all' to show the individual deprecation

Re: [VOTE] KIP-837 Allow MultiCasting a Result Record.

2022-12-08 Thread Sagar
Thanks Matthias, Well, as things stand, we did have internal discussions on this and it seemed ok to open it up for IQ and more importantly not ok to have it opened up for FK-Join. And more importantly, the PR for this is already merged and some of these things came up during that. Here's the PR

Re: [VOTE] KIP-878: Internal Topic Autoscaling for Kafka Streams

2022-12-08 Thread Sophie Blee-Goldman
Thanks all! That closes the voting out and the KIP is accepted with four +1 (binding) votes from Matthias, Bruno, and Bill (and myself). Best, Sophie On Thu, Dec 8, 2022 at 8:45 AM Bill Bejeck wrote: > Thanks for the KIP, Sophie. > > +1(binding) > > -Bill > > On Thu, Dec 8, 2022 at 11:39 AM

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #1418

2022-12-08 Thread Apache Jenkins Server
See

Build failed in Jenkins: Kafka » Kafka Branch Builder » 3.3 #132

2022-12-08 Thread Apache Jenkins Server
See Changes: -- [...truncated 339489 lines...] [2022-12-09T01:18:21.724Z] > Task :connect:api:javadocJar [2022-12-09T01:18:21.724Z] > Task

Re: [Streams] GlobalStateManagerImpl#restoreState locally restores previously deleted records

2022-12-08 Thread Matthias J. Sax
The way I see it, KAFKA-7663 says, "a global store will be exactly the input topic after restore, regardless of the processor" Not sure what you mean by this? The issue the tickets describe is, that if you don't do a plain `put(key,value)` in your processor, stuff breaks right now. (Note

Re: [VOTE] KIP-837 Allow MultiCasting a Result Record.

2022-12-08 Thread Matthias J. Sax
Ah. Missed it as it does not have a nice "code block" similar to `StreamPartitioner` changes. I understand the motivation, but I am wondering if we might head into a tricky direction? State stores (at least the built-in ones) and IQ are kinda build with the idea to have sharded data and that

Build failed in Jenkins: Kafka » Kafka Branch Builder » 3.4 #5

2022-12-08 Thread Apache Jenkins Server
See Changes: -- [...truncated 521506 lines...] [2022-12-08T23:23:47.001Z] [2022-12-08T23:23:47.001Z] Gradle Test Run :core:integrationTest > Gradle Test Executor 163 >

Build failed in Jenkins: Kafka » Kafka Branch Builder » 3.0 #214

2022-12-08 Thread Apache Jenkins Server
See Changes: -- [...truncated 355232 lines...] [2022-12-08T23:18:58.448Z] [INFO] --- maven-remote-resources-plugin:1.5:process (process-resource-bundles) @

Re: [VOTE] KIP-884: Add config to configure KafkaClientSupplier in Kafka Streams

2022-12-08 Thread Matthias J. Sax
Thanks Hao. I think it makes sense to extend `StreamsConfig` as proposed. -Matthias On 12/7/22 10:26 AM, Hao Li wrote: Hi all, I updated the KIP to add a `getKafkaClientSupplier` method in `StreamsConfig`. Let me know if you have any concerns. Thanks, Hao On Wed, Nov 30, 2022 at 10:26 AM

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #1417

2022-12-08 Thread Apache Jenkins Server
See Changes: -- [...truncated 521006 lines...] [2022-12-08T21:51:11.606Z] Gradle Test Run :core:integrationTest > Gradle Test Executor 163 > StopReplicaRequestTest >

Build failed in Jenkins: Kafka » Kafka Branch Builder » 3.2 #93

2022-12-08 Thread Apache Jenkins Server
See Changes: -- [...truncated 456642 lines...] [2022-12-08T21:08:00.656Z] > Task :connect:api:generateMetadataFileForMavenJavaPublication [2022-12-08T21:08:00.656Z] > Task

Jenkins build is unstable: Kafka » Kafka Branch Builder » 3.3 #131

2022-12-08 Thread Apache Jenkins Server
See

Re: [Streams] GlobalStateManagerImpl#restoreState locally restores previously deleted records

2022-12-08 Thread Patrick D’Addona
Hi, I don't think this issue is exactly the same as KAFKA-7663. The way I see it, KAFKA-7663 says, "a global store will be exactly the input topic after restore, regardless of the processor" My issue here, is that the global store after restore is inconsistent with the input topic and the

Re: [VOTE] KIP-893: The Kafka protocol should support nullable structs

2022-12-08 Thread David Jacot
The KIP is accepted with 3 binding votes (Colin, John, Ziming) and 1 non-binding vote (Kirk). Thank you all! Best, David On Tue, Dec 6, 2022 at 3:59 AM deng ziming wrote: > > +1 (binding) > > -- > Thanks, > Ziming > > > > On Dec 6, 2022, at 10:48, John Roesler wrote: > > > > +1 (binding) > >

[jira] [Resolved] (KAFKA-14417) Producer doesn't handle REQUEST_TIMED_OUT for InitProducerIdRequest, treats as fatal error

2022-12-08 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-14417. - Fix Version/s: 4.0.0 3.3.2 Resolution: Fixed > Producer

Re: [Streams] GlobalStateManagerImpl#restoreState locally restores previously deleted records

2022-12-08 Thread Colt McNealy
Hi Patrick, Your issue is in fact identical to KAFKA-7663. As per that issue/bug/discussion, if your processor does anything other than simply pass-through records, the results of initial processing vs restoration are different. Global State Stores don't have a changelog topic (for example, in

Re: [VOTE] KIP-878: Internal Topic Autoscaling for Kafka Streams

2022-12-08 Thread Bill Bejeck
Thanks for the KIP, Sophie. +1(binding) -Bill On Thu, Dec 8, 2022 at 11:39 AM Bruno Cadonna wrote: > Thanks for the KIP! > > +1 (binding) > > Best, > Bruno > > On 07.12.22 17:24, Matthias J. Sax wrote: > > +1 (binding) > > > > On 12/1/22 9:39 PM, Sophie Blee-Goldman wrote: > >> Thanks to all

[Streams] GlobalStateManagerImpl#restoreState locally restores previously deleted records

2022-12-08 Thread Patrick D’Addona
Hello, I have a quarkus application using **org.apache.kafka:kafka-streams:3.1.0** and found that * when creating a global table using a compacted topic as input * entries that have been deleted at some point * are then no longer returned when iterating over the store with **store.all()** - as

Re: [VOTE] KIP-878: Internal Topic Autoscaling for Kafka Streams

2022-12-08 Thread Bruno Cadonna
Thanks for the KIP! +1 (binding) Best, Bruno On 07.12.22 17:24, Matthias J. Sax wrote: +1 (binding) On 12/1/22 9:39 PM, Sophie Blee-Goldman wrote: Thanks to all who participated for a great discussion on this KIP. Seems we're ready to kick off the voting on this, but please don't hesitate

[jira] [Resolved] (KAFKA-14352) Support rack-aware partition assignment for Kafka consumers

2022-12-08 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram resolved KAFKA-14352. Reviewer: David Jacot Resolution: Fixed This includes protocol changes for

[jira] [Created] (KAFKA-14456) Fix AdminUtils startIndex for rack aware partition creations

2022-12-08 Thread Andrew Grant (Jira)
Andrew Grant created KAFKA-14456: Summary: Fix AdminUtils startIndex for rack aware partition creations Key: KAFKA-14456 URL: https://issues.apache.org/jira/browse/KAFKA-14456 Project: Kafka

Re: [DISCUSS] KIP-879: Multi-level Rack Awareness

2022-12-08 Thread Andrew Otto
FWIW, the Wikimedia Foundation would find this change really helpful. We are going to soon experiment with a stretched Kafka cluster, and it would be nice to be able to target datacenter AND racks for replica placement. On Thu, Dec 8, 2022 at 3:37 AM ziming deng wrote: > Hi Viktor, > > As far

[jira] [Created] (KAFKA-14455) Kafka Connect create and update REST APIs should surface failures while writing to the config topic

2022-12-08 Thread Yash Mayya (Jira)
Yash Mayya created KAFKA-14455: -- Summary: Kafka Connect create and update REST APIs should surface failures while writing to the config topic Key: KAFKA-14455 URL: https://issues.apache.org/jira/browse/KAFKA-14455

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #1416

2022-12-08 Thread Apache Jenkins Server
See

Jenkins build is still unstable: Kafka » Kafka Branch Builder » 3.4 #4

2022-12-08 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-879: Multi-level Rack Awareness

2022-12-08 Thread ziming deng
Hi Viktor, As far as I know, we haven't make ReplicaPlacer a public interface, and we have no plan to make it public. I think you can submit a discussion or create a JIRA ticket directly without KIP if you have ideas on improving it, right? -- Best, Ziming > On Nov 29, 2022, at 21:52, Viktor