Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #2357

2023-11-03 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-969: Support range interactive queries for versioned state stores

2023-11-03 Thread Matthias J. Sax
Great discussion. Seems we are making good progress. I see advantages and disadvantages in splitting out a "single-ts key-range" query type. I guess, the main question might be, what use-cases do we anticipate and how common we believe they are? We should also take KIP-992 (adding

Re: [VOTE] KIP-992 Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery

2023-11-03 Thread Matthias J. Sax
Thanks for the KIP. +1 (binding) -Matthias On 11/3/23 6:08 AM, Lucas Brutschy wrote: Hi Hanyu, Thanks for the KIP! +1 (binding) Cheers Lucas On Thu, Nov 2, 2023 at 10:19 PM Hao Li wrote: Hi Hanyu, Thanks for the KIP! +1 (non-binding) Hao On Thu, Nov 2, 2023 at 1:29 PM Bill Bejeck

Re: [VOTE] KIP-998: Give ProducerConfig(props, doLog) constructor protected access

2023-11-03 Thread Matthias J. Sax
Sophie reads my mind well, but I also won't object if majority if people thinks it's desirable to have it public (it's does not really hurt to have them public). I just personally think, we should optimize for "end users" and they should not need it -- and thus, keeping the API surface area

Re: [VOTE] KIP-998: Give ProducerConfig(props, doLog) constructor protected access

2023-11-03 Thread Chris Egerton
No objections, I'm +1 ether way. On Fri, Nov 3, 2023, 18:50 Sophie Blee-Goldman wrote: > I am fine with making them public. Of course in that case we should also > change the corresponding constructors in ConsumerConfig, AdminConfig, and > StreamsConfig from protected to public as well, to be

Re: [VOTE] KIP-998: Give ProducerConfig(props, doLog) constructor protected access

2023-11-03 Thread Sophie Blee-Goldman
I am fine with making them public. Of course in that case we should also change the corresponding constructors in ConsumerConfig, AdminConfig, and StreamsConfig from protected to public as well, to be consistent. But Matthias seems to feel that these should never be instantiated by a user and that

[jira] [Created] (KAFKA-15791) Investigate new test case failure - MirrorConnectorsWithCustomForwardingAdminIntegrationTest - MirrorConnectorsIntegrationBaseTest

2023-11-03 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15791: - Summary: Investigate new test case failure - MirrorConnectorsWithCustomForwardingAdminIntegrationTest - MirrorConnectorsIntegrationBaseTest Key: KAFKA-15791 URL:

[jira] [Created] (KAFKA-15788) Investigate new test case failure - testDeleteCmdNonExistingGroup

2023-11-03 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15788: - Summary: Investigate new test case failure - testDeleteCmdNonExistingGroup Key: KAFKA-15788 URL: https://issues.apache.org/jira/browse/KAFKA-15788 Project: Kafka

[jira] [Created] (KAFKA-15790) Investigate new test case failure - testHighWaterMarkAfterPartitionReassignment

2023-11-03 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15790: - Summary: Investigate new test case failure - testHighWaterMarkAfterPartitionReassignment Key: KAFKA-15790 URL: https://issues.apache.org/jira/browse/KAFKA-15790

[jira] [Created] (KAFKA-15789) Investigate new test case failure - testTimeouts - QuorumControllerTest

2023-11-03 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15789: - Summary: Investigate new test case failure - testTimeouts - QuorumControllerTest Key: KAFKA-15789 URL: https://issues.apache.org/jira/browse/KAFKA-15789 Project:

[jira] [Created] (KAFKA-15786) Investigate new test case failure - testBumpTransactionalEpoch

2023-11-03 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15786: - Summary: Investigate new test case failure - testBumpTransactionalEpoch Key: KAFKA-15786 URL: https://issues.apache.org/jira/browse/KAFKA-15786 Project: Kafka

[jira] [Created] (KAFKA-15787) Investigate new test case failure - testReplicateSourceDefault

2023-11-03 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15787: - Summary: Investigate new test case failure - testReplicateSourceDefault Key: KAFKA-15787 URL: https://issues.apache.org/jira/browse/KAFKA-15787 Project: Kafka

[jira] [Created] (KAFKA-15785) Investigate new test case failures

2023-11-03 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-15785: - Summary: Investigate new test case failures Key: KAFKA-15785 URL: https://issues.apache.org/jira/browse/KAFKA-15785 Project: Kafka Issue Type: Sub-task

Re: Request for Removal From the Mail Thread

2023-11-03 Thread Divij Vaidya
Hey Dasun Subscribe/unsubscribe to the mailing list is self service. You can find the details at https://kafka.apache.org/contact -- Divij Vaidya On Fri, Nov 3, 2023 at 7:37 PM Dasun Nirmitha wrote: > Hello Apache Kafka Mail Thread, > Thanks for having me in your mail thread for a really

Request for Removal From the Mail Thread

2023-11-03 Thread Dasun Nirmitha
Hello Apache Kafka Mail Thread, Thanks for having me in your mail thread for a really long time. But since I've changed my fields I believe I won't be needing an active involvement with this platform anymore. So, this is me dear request to kindly remove me from your mailing list. Thanks and

Re: [VOTE] KIP-998: Give ProducerConfig(props, doLog) constructor protected access

2023-11-03 Thread Ismael Juma
It seems wrong to require inheritance for this and we already have a public constructor. I would make both of them public. Ismael On Fri, Nov 3, 2023 at 10:47 AM Matthias J. Sax wrote: > +1 (binding) > > > About "why not public" question: > > I think we need to distinguish between "end users"

Re: [DISCUSS] KIP-954: expand default DSL store configuration to custom types

2023-11-03 Thread Matthias J. Sax
Thanks. Will take a look into the PR. I don't have any objection to the goal; contrary! It's very annoying what we have right now, and if we can improve it, I am totally in favor of it. -Matthias On 11/3/23 8:47 AM, Almog Gavra wrote: Good question :) I have a PR for it already here:

Re: [VOTE] KIP-998: Give ProducerConfig(props, doLog) constructor protected access

2023-11-03 Thread Matthias J. Sax
+1 (binding) About "why not public" question: I think we need to distinguish between "end users" who create a producer instance, and "external parties" that might implement their own `Producer` (or wrap/extend `KafkaProducer`). In the end, I would not expect an "end user" to actually call

Re: [DISCUSS] Apache Kafka 3.5.2 release

2023-11-03 Thread Matthias J. Sax
Hey, Sorry for late reply. We finished our testing, and think we are go. Thanks for giving us the opportunity to get the RocksDB version bump in. Let's ship it! -Matthias On 11/2/23 4:37 PM, Luke Chen wrote: Hi Matthias, Is there any update about the test status for RocksDB versions

[jira] [Created] (KAFKA-15784) Ensure atomicity of in memory update and write when transactionally committing offsets

2023-11-03 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-15784: -- Summary: Ensure atomicity of in memory update and write when transactionally committing offsets Key: KAFKA-15784 URL: https://issues.apache.org/jira/browse/KAFKA-15784

Re: Java 1.8 and TLSv1.3

2023-11-03 Thread Edoardo Comar
Andreas, do you mean that even if you configure your Java client running on Java8 with ssl.enabled.protocols=TLSv1.3 you can't connect to a Kafka broker using TLS1.3 ? On Sat, 28 Oct 2023 at 01:03, Ismael Juma wrote: > > Hi Andreas, > > The TLS code has run into changes in behavior across

Re: [DISCUSS] KIP-954: expand default DSL store configuration to custom types

2023-11-03 Thread Almog Gavra
Good question :) I have a PR for it already here: https://github.com/apache/kafka/pull/14659. The concept is to wrap the suppliers with an interface that allows for delayed creation of the StoreBuilder instead of creating the StoreBuilder from the suppliers right away. Happy to get on a quick call

Re: [VOTE] KIP-978: Allow dynamic reloading of certificates with different DN / SANs

2023-11-03 Thread Viktor Somogyi-Vass
+1 (binding) Thank you for working on this, feel free to add me to the code review too. On Fri, Oct 27, 2023 at 2:54 PM Mickael Maison wrote: > Hi, > > +1 (binding) > Thanks for the KIP > > Mickael > > On Wed, Oct 25, 2023 at 5:34 PM Federico Valeri > wrote: > > > > Hi Jakub, thanks for this

[jira] [Created] (KAFKA-15783) Unable to set batchSize in log4j2 Kafka appender

2023-11-03 Thread Diego Pettisani (Jira)
Diego Pettisani created KAFKA-15783: --- Summary: Unable to set batchSize in log4j2 Kafka appender Key: KAFKA-15783 URL: https://issues.apache.org/jira/browse/KAFKA-15783 Project: Kafka Issue

Re: [VOTE] KIP-992 Proposal to introduce IQv2 Query Types: TimestampedKeyQuery and TimestampedRangeQuery

2023-11-03 Thread Lucas Brutschy
Hi Hanyu, Thanks for the KIP! +1 (binding) Cheers Lucas On Thu, Nov 2, 2023 at 10:19 PM Hao Li wrote: > > Hi Hanyu, > > Thanks for the KIP! > +1 (non-binding) > > Hao > > On Thu, Nov 2, 2023 at 1:29 PM Bill Bejeck wrote: > > > Hi Hanyu, > > > > Thanks for the KIP this LGTM. > > +1 (binding) >

Re: [VOTE] KIP-998: Give ProducerConfig(props, doLog) constructor protected access

2023-11-03 Thread Ismael Juma
Hi Sophie, I was trying to understand the goal of the change and it's not totally clear to me. If the goal is to allow third party applications to customize the logging behavior, why is the method protected instead of public? Ismael On Thu, Nov 2, 2023 at 9:55 PM Sophie Blee-Goldman wrote: >

Re: [DISCUSS] KIP-969: Support range interactive queries for versioned state stores

2023-11-03 Thread Bruno Cadonna
Hi Alieh, I like the examples! 1. Some terms like `asOf` in the descriptions still need to be replaced in the KIP. 2. In your last e-mail you state: "How can a user retrieve the latest value? We have the same issue with kip-968 as well." Why do we have the same issue in KIP-968? If

Re: [VOTE] KIP-998: Give ProducerConfig(props, doLog) constructor protected access

2023-11-03 Thread Bruno Cadonna
Thanks for the KIP! +1 (binding) Best, Bruno On 11/3/23 7:55 AM, Chris Egerton wrote: +1 (binding) FWIW, I agree that this change should require a KIP. Gating upgrades of visibility from private or package-private to protected may be cumbersome, but it comes with the expectation that

[REVIEW REQUEST] ReplicationQuotasTestRig rewritten in java

2023-11-03 Thread Николай Ижиков
Hello. I prepare PR that implements `ReplicationQuotasTestRig` in java - https://github.com/apache/kafka/pull/14588 Please, review. PR contains screenshots and reports both from scala version and java version [1] So It seems pretty straightforward. PR that rewrites `ReassignPartitionCommand`

Re: [VOTE] KIP-998: Give ProducerConfig(props, doLog) constructor protected access

2023-11-03 Thread Chris Egerton
+1 (binding) FWIW, I agree that this change should require a KIP. Gating upgrades of visibility from private or package-private to protected may be cumbersome, but it comes with the expectation that downgrades in visibility for those same classes/methods will also be gated behind a KIP, which is