Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2378

See Changes: -- [...truncated 326987 lines...] Gradle Test Run :streams:test > Gradle Test Executor 62 > DefaultTaskManagerTest > shouldNotUnassignNotOwnedTask() STARTED

Re: [DISCUSS] Should we continue to merge without a green build? No!

I will say that I have also seen tests that seem to be more flaky intermittently. It may be ok for some time and suddenly the CI is overloaded and we see issues. I have also seen the CI struggling with running out of space recently, so I wonder if we can also try to improve things on that front.

Re: [DISCUSS] Should we continue to merge without a green build? No!

On Sat, Nov 11, 2023 at 10:32 AM John Roesler wrote: > In other words, I’m biased to think that new flakiness indicates > non-deterministic bugs more often than it indicates a bad test. > My experience is exactly the opposite. As someone who has tracked many of the flaky fixes, the vast

Re: [DISCUSS] Should we continue to merge without a green build? No!

Thanks, all, This proposal sounds good to me. We could try to just disable the current flaky tests as a one-time step and configure GitHub only to merge green builds as a bulwark against the future. By definition, flaky tests may not fail during the buggy PR build itself, but they should make

Re: [DISCUSS] Should we continue to merge without a green build? No!

One more thing: 3. If test flakiness is introduced by a recent PR, it's appropriate to revert said PR vs disabling the flaky tests. Ismael On Sat, Nov 11, 2023, 8:45 AM Ismael Juma wrote: > Hi David, > > I would be fine with: > 1. Only allowing merges if the build is green > 2. Disabling all

Re: [DISCUSS] Should we continue to merge without a green build? No!

Hi David, I would be fine with: 1. Only allowing merges if the build is green 2. Disabling all flaky tests that aren't fixed within a week. That is, if a test is flaky for more than a week, it should be automatically disabled (it doesn't add any value since it gets ignored). We need both to make

Re: [DISCUSS] Should we continue to merge without a green build? No!

Hi David, Thanks for bringing this point and also for creating the revert PRs. I think there has been an effort in the community to fix a lot of flakey tests(like around MirrorMaker). I also agree that we shouldn't merge PRs without green builds and look to ignore flaky tests. For example, I did

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #2377

See Changes: -- [...truncated 248172 lines...] Gradle Test Run :streams:test > Gradle Test Executor 58 > DefaultTaskExecutorTest >

[DISCUSS] Should we continue to merge without a green build? No!

Hi all, The state of our CI worries me a lot. Just this week, we merged two PRs with compilation errors and one PR introducing persistent failures. This really hurts the quality and the velocity of the project and it basically defeats the purpose of having a CI because we tend to ignore it