Re: [VOTE] KIP-1056 - Deprecate `default.` prefix for exception handler in StreamsConfig

2024-06-21 Thread Matthias J. Sax
+1 (binding) from my side. I understand the concerns raised, but would personally move forward with this KIP as-is. If we cannot get three votes, it would get naturally discarded. -Matthias On 6/19/24 11:33 AM, Muralidhar Basani wrote: Hi all, I would like to call a vote on KIP-1056 -

Re: [DISCUSS] KIP-1059: Enable the Producer flush() method to clear the latest send() error

2024-06-21 Thread Matthias J. Sax
Hey Kirk, can you elaborate on a few points? Otherwise users would have to know to explicitly change their code to invoke flush(). Why? If we would add an option to `flush(FlushOption)`, the existing `flush()` w/o any option will still be there, right? If we would really deprecate

Re: [DISCUSS] KIP-1059: Enable the Producer flush() method to clear the latest send() error

2024-06-21 Thread Kirk True
Hi Matthias, > On Jun 21, 2024, at 12:28 PM, Matthias J. Sax wrote: > > If we want to limit it to `RecordTooLargeException` throwing from `send()` > directly make sense. Thanks for calling it out. > > It's still a question of backward compatibility? `send()` does throw > exceptions already,

Re: [VOTE] KIP-1022 Formatting and Updating Features

2024-06-21 Thread Justine Olshan
Ok makes sense. I will update my PR. On Fri, Jun 21, 2024 at 5:09 PM Colin McCabe wrote: > I think it's better to suppress the response in v3. The issue with > modifying it is that there may be scenarios where [1, 1] is the actual > supported range, and we'd want to know that. But leaving out

Re: [VOTE] KIP-1022 Formatting and Updating Features

2024-06-21 Thread Colin McCabe
I think it's better to suppress the response in v3. The issue with modifying it is that there may be scenarios where [1, 1] is the actual supported range, and we'd want to know that. But leaving out the feature should be OK for older clients (it will be the case with clients old enough to send

Re: [DISCUSS] KIP-1059: Enable the Producer flush() method to clear the latest send() error

2024-06-21 Thread Kirk True
Hi all, The JavaDoc for Producer.flush() states: Applications don't need to call this method for transactional producers, since the commitTransaction() will flush all buffered records before performing the commit. This ensures that all the send() calls made since the previous

Re: [VOTE] KIP-1022 Formatting and Updating Features

2024-06-21 Thread Justine Olshan
Thanks Colin, This makes sense to me. Namely in the case where we perhaps don't want to support version 0 anymore, we need the range to be able to not include 0. (In other words, we can't assume 0 is supported) It is unfortunate that this change is a bit tricky, but I think it's the best option.

Re: [VOTE] KIP-1022 Formatting and Updating Features

2024-06-21 Thread Colin McCabe
Hi all, It seems that there was a bug in older versions of Kafka which caused deserialization problems when a supported feature range included 0. For example, the range for group.version of [0, 1] would be a problem in this situation. This obviously makes supportedVersions kind of useless.

Jenkins build is still unstable: Kafka » Kafka Branch Builder » 3.8 #57

2024-06-21 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-1059: Enable the Producer flush() method to clear the latest send() error

2024-06-21 Thread Matthias J. Sax
If we want to limit it to `RecordTooLargeException` throwing from `send()` directly make sense. Thanks for calling it out. It's still a question of backward compatibility? `send()` does throw exceptions already, including generic `KafkaException`. Not sure if this helps with backward

[jira] [Created] (KAFKA-17019) Producer TimeoutException should include root cause

2024-06-21 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-17019: --- Summary: Producer TimeoutException should include root cause Key: KAFKA-17019 URL: https://issues.apache.org/jira/browse/KAFKA-17019 Project: Kafka

Re: [DISCUSS] KIP-1059: Enable the Producer flush() method to clear the latest send() error

2024-06-21 Thread Chris Egerton
Hi Artem, I think it'd make sense to throw directly from send whenever possible, instead of returning an already-completed future. I didn't do that in my bug fix to try to be conservative about breaking changes but this seems to have caused its own set of headaches. It would be a little less

Re: [DISCUSS] KIP-1059: Enable the Producer flush() method to clear the latest send() error

2024-06-21 Thread Matthias J. Sax
Not sure if we can change send and make it throw, given that send() is async? That is why users can register a `Callback` to begin with, right? And Alieh's point about backward compatibility is also a fair concern. Actually, this would potentially be even worse than the original buggy

Re: [VOTE] 3.7.1 RC2

2024-06-21 Thread Jakub Scholz
+1 (non-binding). I used the staged binaries (based on Scala 2.13) and Maven artifacts to run my tests. All seems to work fine. Thanks & Regards Jakub On Wed, Jun 19, 2024 at 10:55 AM Igor Soarez wrote: > Hello Kafka users, developers and client-developers, > > This is the second candidate for

[jira] [Created] (KAFKA-17018) Metadata version 3.9 should return Fetch version 17

2024-06-21 Thread Jira
José Armando García Sancio created KAFKA-17018: -- Summary: Metadata version 3.9 should return Fetch version 17 Key: KAFKA-17018 URL: https://issues.apache.org/jira/browse/KAFKA-17018

[jira] [Created] (KAFKA-17017) AsyncConsumer#unsubscribe does not clean the assigned partitions

2024-06-21 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17017: -- Summary: AsyncConsumer#unsubscribe does not clean the assigned partitions Key: KAFKA-17017 URL: https://issues.apache.org/jira/browse/KAFKA-17017 Project: Kafka

Re: [DISCUSS] KIP-1052: Enable warmup in producer performance test

2024-06-21 Thread Federico Valeri
Hi Matt, I thanks for the KIP, this is a really useful feature. In public interfaces, you say that the output won't change by default, so I guess this means that --combined-summary will be false by default, otherwise we would break the producer_performance system test. Is that correct? I think a

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #3037

2024-06-21 Thread Apache Jenkins Server
See

Re: [PR] Add Skillsoft to "Powered By" [kafka-site]

2024-06-21 Thread via GitHub
mjsax merged PR #601: URL: https://github.com/apache/kafka-site/pull/601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Adding OREXES to powered-by section [kafka-site]

2024-06-21 Thread via GitHub
mjsax commented on PR #591: URL: https://github.com/apache/kafka-site/pull/591#issuecomment-2177287181 @siifuu -- Can you rebase this PR to resolve merge conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Netstratum info updated [kafka-site]

2024-06-21 Thread via GitHub
mjsax commented on PR #534: URL: https://github.com/apache/kafka-site/pull/534#issuecomment-2177285732 @netstratum-labs -- can you rebase this PR to resolve merge conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Update powered-by.html [kafka-site]

2024-06-21 Thread via GitHub
mjsax commented on code in PR #503: URL: https://github.com/apache/kafka-site/pull/503#discussion_r1645236142 ## powered-by.html: ## @@ -763,6 +763,11 @@ "logo": "nussknacker.svg", "logoBgColor": "#ff", "description": "Nussknacker is a low-code

Re: [PR] adding spitha on powered-by [kafka-site]

2024-06-21 Thread via GitHub
mjsax commented on PR #515: URL: https://github.com/apache/kafka-site/pull/515#issuecomment-2177283797 @VictorParkM -- happy to merge this, but it seems your web-page does not follow ASF guidelines with regard to respecting the Apache Kafka trademark. -

Re: [PR] Update powered-by.html [kafka-site]

2024-06-21 Thread via GitHub
mjsax commented on PR #503: URL: https://github.com/apache/kafka-site/pull/503#issuecomment-2177280319 Logo is added in a different PR: https://github.com/apache/kafka-site/pull/502 But not sure if we need to close both. -- This is an automated message from the Apache Git Service.

Re: [PR] Create edenlab.svg [kafka-site]

2024-06-21 Thread via GitHub
mjsax commented on PR #502: URL: https://github.com/apache/kafka-site/pull/502#issuecomment-2177279909 Cf https://github.com/apache/kafka-site/pull/503#discussion_r1645236142 Maybe we need to close this PR? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Create edenlab.svg [kafka-site]

2024-06-21 Thread via GitHub
mjsax commented on PR #502: URL: https://github.com/apache/kafka-site/pull/502#issuecomment-2177278235 @Anykry -- not sure if I understand this PR. The logo won't show up anywhere without a powered-by entry the html? -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Added Deep.BI - Predictive Analytics & AI Platform [kafka-site]

2024-06-21 Thread via GitHub
mjsax merged PR #500: URL: https://github.com/apache/kafka-site/pull/500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Howly added to powered-by page [kafka-site]

2024-06-21 Thread via GitHub
mjsax merged PR #498: URL: https://github.com/apache/kafka-site/pull/498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [VOTE] KIP-1057: Add remote log metadata flag to the dump log tool

2024-06-21 Thread Kamal Chandraprakash
Hi Federico, Thanks for the KIP! +1 from me. On Fri, Jun 21, 2024 at 5:47 PM Luke Chen wrote: > Hi Fede, > > Thanks for the KIP! > +1 from me. > > Luke > > On Fri, Jun 21, 2024 at 6:44 PM Federico Valeri > wrote: > > > Hi all, I'd like to kick off a vote on KIP-1057. > > > > Design doc: > > >

[jira] [Resolved] (KAFKA-17012) Enable testMeasureCommitSyncDuration, testMeasureCommittedDurationOnFailure, testInvalidGroupMetadata, testMeasureCommittedDuration, testOffsetsForTimesTimeout, testBeg

2024-06-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17012?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17012. Fix Version/s: 3.9.0 Resolution: Fixed > Enable testMeasureCommitSyncDuration,

[jira] [Resolved] (KAFKA-17007) Fix SourceAndTarget#equal

2024-06-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17007?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17007. Fix Version/s: 3.9.0 Resolution: Fixed > Fix SourceAndTarget#equal >

Re: [VOTE] KIP-1057: Add remote log metadata flag to the dump log tool

2024-06-21 Thread Luke Chen
Hi Fede, Thanks for the KIP! +1 from me. Luke On Fri, Jun 21, 2024 at 6:44 PM Federico Valeri wrote: > Hi all, I'd like to kick off a vote on KIP-1057. > > Design doc: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-1057%3A+Add+remote+log+metadata+flag+to+the+dump+log+tool > >

Re: [DISCUSS] KIP-1052: Enable warmup in producer performance test

2024-06-21 Thread Luke Chen
Hi Matt, Thanks for the KIP! I agree having the warm-up records could help correctly analyze the performance. Some questions: 1. It looks like we will add 2 more options to producer perf tool: - --warmup-records - --combined-summary Is this correct? In the "public interface" section, only 1

[jira] [Created] (KAFKA-17016) Align the behavior of GaugeWrapper and MeterWrapper

2024-06-21 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-17016: -- Summary: Align the behavior of GaugeWrapper and MeterWrapper Key: KAFKA-17016 URL: https://issues.apache.org/jira/browse/KAFKA-17016 Project: Kafka

Re: [DISCUSS] KIP-1059: Enable the Producer flush() method to clear the latest send() error

2024-06-21 Thread Alieh Saeedi
Hi all, It is very exciting to see all the experts here raising very good points. As we go further, we see more and more options to improve our solution, which makes concluding and updating the KIP impossible. The main suggestions so far are: 1. `flush` with `flushOptions` as input parameter

[VOTE] KIP-1057: Add remote log metadata flag to the dump log tool

2024-06-21 Thread Federico Valeri
Hi all, I'd like to kick off a vote on KIP-1057. Design doc: https://cwiki.apache.org/confluence/display/KAFKA/KIP-1057%3A+Add+remote+log+metadata+flag+to+the+dump+log+tool Discussion thread: https://lists.apache.org/thread/kxx1h4qwshgcjh4d5xzqltkx5mx9qopm Thanks, Fede

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #3036

2024-06-21 Thread Apache Jenkins Server
See

[jira] [Created] (KAFKA-17015) ContextualRecord#hashCode()、ProcessorRecordContext#hashCode() Should not be deprecated and throw an exception

2024-06-21 Thread dujian0068 (Jira)
dujian0068 created KAFKA-17015: -- Summary: ContextualRecord#hashCode()、ProcessorRecordContext#hashCode() Should not be deprecated and throw an exception Key: KAFKA-17015 URL:

[jira] [Resolved] (KAFKA-17008) Update zookeeper to 3.8.4 or 3.9.2 to address CVE-2024-23944

2024-06-21 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-17008. Resolution: Duplicate > Update zookeeper to 3.8.4 or 3.9.2 to address CVE-2024-23944 >

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

2024-06-21 Thread Kaushik Raina
Thanks Matthias for feedback - We have updates KIP and grouped exceptions https://cwiki.apache.org/confluence/display/KAFKA/KIP-1050%3A+Consistent+error+handling+for+Transactions#KIP1050:ConsistenterrorhandlingforTransactions-ExceptionTable - Regarding compatibility, all changes in KIP are

Re: [DISCUSS] KIP-1059: Enable the Producer flush() method to clear the latest send() error

2024-06-21 Thread Andrew Schofield
Hi Artem, I think you make a good point which is worth further consideration. If any of the existing methods is really ripe for a change here, it’s the send() that actually caused the problem. If that can be fixed so there are no situations in which a lurking error breaks a transaction, that might