Re: [VOTE] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

2024-08-21 Thread 黃竣陽
+1 (non-binding) Best regard, Jiunn Yang

Re: [VOTE] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

2024-08-21 Thread Chia-Ping Tsai
+1 (binding) TengYao Chi 於 2024年8月22日 週四 下午2:04寫道: > Hi everyone, > > Based on our discussion > > regarding > KIP-1078 , I believe this > KIP > is now ready for a vote. > > Sincerely,

[VOTE] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

2024-08-21 Thread TengYao Chi
Hi everyone, Based on our discussion regarding KIP-1078 , I believe this KIP is now ready for a vote. Sincerely, TengYao

[jira] [Created] (KAFKA-17398) Facing large leader election time in Kafka

2024-08-21 Thread Atul Sharma (Jira)
Atul Sharma created KAFKA-17398: --- Summary: Facing large leader election time in Kafka Key: KAFKA-17398 URL: https://issues.apache.org/jira/browse/KAFKA-17398 Project: Kafka Issue Type: Bug

Re: [DISCUSS] KIP-1081: Graduation Steps for Features

2024-08-21 Thread Matthias J. Sax
Thanks Josep. Couple of comments/questions: For Level 1, the KIP says: The feature is not yet stable and it is not meant to be used by end users. This seems to be little bit confusing. If it's not meant to be used by anybody, should it not be feature flagged and disable/hidden from users co

Re: [DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

2024-08-21 Thread TengYao Chi
Hi Matthias Thank you again for previous suggestion. I will start a VOTE soon. Best regards, TengYao Matthias J. Sax 於 2024年8月22日 週四 下午12:02寫道: > I think the KIP is fine as-is. > > Seems it's also not very controversial. Feel free to start a VOTE. > > > -Matthias > > On 8/6/24 7:54 PM, TengYao

Re: [DISCUSS] KIP-1076: Metrics for client applications a KIP-714 extension

2024-08-21 Thread Matthias J. Sax
Thanks for the KIP Bill. Just for brainstorming: the newly added methods have `boolean` return type. Is this necessary or would logging a WARN be sufficient? Or maybe throw an exception if reporting is disabled? As we intend to report KS metrics, I am wondering if we should talk about this i

Re: [IMPORTANT] Need Confluence Account | Approved by PMC member

2024-08-21 Thread Matthias J. Sax
Atul, Based on https://issues.apache.org/jira/browse/INFRA-25451?focusedCommentId=17867582&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17867582 your account should have been created and you should have received an email about it. (Did you check your spam f

[jira] [Resolved] (KAFKA-17391) Remove bootstrap-servers in StreamsResetter

2024-08-21 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang resolved KAFKA-17391. --- Resolution: Duplicate > Remove bootstrap-servers in StreamsResetter > --

Re: [VOTE] KIP-1077: Deprecate `ForeachProcessor` and move to internal package

2024-08-21 Thread Matthias J. Sax
+1 (binding) On 8/19/24 6:14 AM, 黃竣陽 wrote: Hi Bruno, Thanks for your reminder. Sorry for the wrong voting. I'm +1 (non-binding). Best regards, Jiunn Yang

Re: [DISCUSS] KIP-1078: Remove Leaking Getter Methods in Joined Helper Class

2024-08-21 Thread Matthias J. Sax
I think the KIP is fine as-is. Seems it's also not very controversial. Feel free to start a VOTE. -Matthias On 8/6/24 7:54 PM, TengYao Chi wrote: Hi Matthias, Thank you for pointing that out. I will keep it in mind. Do I need to update the content of the KIP, or can we leave it as is? Best r

[jira] [Resolved] (KAFKA-16324) Move BrokerApiVersionsCommand to tools

2024-08-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16324. Fix Version/s: 4.0.0 Resolution: Fixed > Move BrokerApiVersionsCommand to tools > -

[jira] [Created] (KAFKA-17397) Ensure ClassicKafkaConsumer sends leave request on close even if interrupted

2024-08-21 Thread Kirk True (Jira)
Kirk True created KAFKA-17397: - Summary: Ensure ClassicKafkaConsumer sends leave request on close even if interrupted Key: KAFKA-17397 URL: https://issues.apache.org/jira/browse/KAFKA-17397 Project: Kafka

[jira] [Resolved] (KAFKA-17378) Initial performance testing fixes

2024-08-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17378. Resolution: Fixed > Initial performance testing fixes > -

[jira] [Created] (KAFKA-17396) Fix releasing of session on clients final epoch

2024-08-21 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-17396: - Summary: Fix releasing of session on clients final epoch Key: KAFKA-17396 URL: https://issues.apache.org/jira/browse/KAFKA-17396 Project: Kafka Issue Type:

Jenkins build is still unstable: Kafka » Kafka Branch Builder » 3.9 #41

2024-08-21 Thread Apache Jenkins Server
See

[jira] [Resolved] (KAFKA-17346) Refactor Share Sesssion Class to Server Module

2024-08-21 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-17346. --- Resolution: Fixed > Refactor Share Sesssion Class to Server Module > ---

Jenkins build is still unstable: Kafka » Kafka Branch Builder » trunk #3220

2024-08-21 Thread Apache Jenkins Server
See

[jira] [Resolved] (KAFKA-16443) Update streams_static_membership_test.py to support KIP-848’s group protocol config

2024-08-21 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-16443. --- Resolution: Won't Fix This Jira was created prior to getting input from the Kafka Streams developers

[jira] [Resolved] (KAFKA-16441) Update streams_broker_down_resilience_test.py to support KIP-848’s group protocol config

2024-08-21 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-16441. --- Resolution: Won't Fix This Jira was created prior to getting input from the Kafka Streams developers

[jira] [Resolved] (KAFKA-16442) Update streams_standby_replica_test.py to support KIP-848’s group protocol config

2024-08-21 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-16442. --- Resolution: Won't Fix This Jira was created prior to getting input from the Kafka Streams developers

Re: [DISCUSS] KIP-1076: Metrics for client applications a KIP-714 extension

2024-08-21 Thread Apoorv Mittal
Hi Bill, Thanks for addressing, looks good to me. Looking forward to implementation. Regards, Apoorv Mittal On Wed, Aug 21, 2024 at 8:14 PM Bill Bejeck wrote: > Hi Apoorv, > > Good call, I've updated the compatibility section with text about using > older brokers. > > -Bill > > On Wed, Aug 21,

Re: [DISCUSS] KIP-1076: Metrics for client applications a KIP-714 extension

2024-08-21 Thread Bill Bejeck
Hi Apoorv, Good call, I've updated the compatibility section with text about using older brokers. -Bill On Wed, Aug 21, 2024 at 1:30 PM Apoorv Mittal wrote: > Hi Bill, > Thanks for the details. Sounds good to me. > > One last question: > > AM5: Do we need to capture any details around compatib

[jira] [Created] (KAFKA-17395) Flaky test testMissingOffsetNoResetPolicy for new consumer

2024-08-21 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-17395: -- Summary: Flaky test testMissingOffsetNoResetPolicy for new consumer Key: KAFKA-17395 URL: https://issues.apache.org/jira/browse/KAFKA-17395 Project: Kafka

Jenkins build is still unstable: Kafka » Kafka Branch Builder » 3.9 #40

2024-08-21 Thread Apache Jenkins Server
See

Re: [DISCUSS] KIP-1076: Metrics for client applications a KIP-714 extension

2024-08-21 Thread Apoorv Mittal
Hi Bill, Thanks for the details. Sounds good to me. One last question: AM5: Do we need to capture any details around compatibility with older brokers which don't support KIP-714 or when telemetry APIs are not enabled on brokers (no configured receiver plugin)? Regards, Apoorv Mittal On Tue, Au

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

2024-08-21 Thread Nick Telford
Hi Lucas, NT4. Sounds good, although should it take the maximum offsets? Wouldn't it be more correct to take the *most recent* offsets? (i.e. the offsets from the more recently received heartbeat) My thinking is that it might be possible (albeit exceptionally rare) for the on-disk offsets to rever

[jira] [Resolved] (KAFKA-16581) Implement KafkaRaftClient unittest for membership change

2024-08-21 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-16581. -- Fix Version/s: 3.9.0 Resolution: Fixed > Implement KafkaRaftClient unittest for members

[jira] [Created] (KAFKA-17394) Flaky test in DefaultTaskExecutorTest.shouldSetUncaughtStreamsException

2024-08-21 Thread Ao Li (Jira)
Ao Li created KAFKA-17394: - Summary: Flaky test in DefaultTaskExecutorTest.shouldSetUncaughtStreamsException Key: KAFKA-17394 URL: https://issues.apache.org/jira/browse/KAFKA-17394 Project: Kafka Is

Re: [DISCUSS] KIP-891: Running multiple versions of Connector plugins

2024-08-21 Thread Greg Harris
Hey Snehashis, Thanks for your reply! > Deviating > it from the spec seems unnecessary if we document it accordingly, however > It's probably less intuitive and can lead to confusion. I would just keep > it as is but making it simpler is also fine. It sounds like you don't have a strong opinion

Jenkins build is unstable: Kafka » Kafka Branch Builder » trunk #3219

2024-08-21 Thread Apache Jenkins Server
See

[IMPORTANT] Need Confluence Account | Approved by PMC member

2024-08-21 Thread Atul Khanduri
Hello, I requested for a Confluence account in JIRA ticket so that I can create a KIP for a PR. It is also *approved by a PMC member* (Mickael Maison). Can you please create an account so that we can create KIP and close the PR? URL where I have provided details and requested for Confluence acces

[jira] [Resolved] (KAFKA-17279) Handle retriable errors from offset fetches in ConsumerCoordinator

2024-08-21 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-17279. - Fix Version/s: 3.9.0 Resolution: Fixed > Handle retriable errors from offset fetches in C

[jira] [Resolved] (KAFKA-17151) Remove waitForCondition when detecting thread leak

2024-08-21 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-17151. Fix Version/s: 4.0.0 Resolution: Fixed > Remove waitForCondition when detecting thr

Build failed in Jenkins: Kafka » Kafka Branch Builder » trunk #3218

2024-08-21 Thread Apache Jenkins Server
See Changes: -- [...truncated 277965 lines...] [2024-08-21T09:01:28.619Z] Gradle Test Run :core:test > Gradle Test Executor 102 > ZkMigrationClientTest > testMigrateTopicC

Re: [DISCUSS] KIP-891: Running multiple versions of Connector plugins

2024-08-21 Thread Snehashis
Hi Greg, No issues, I have been caught up in a few things myself. I have added the points we discussed. In addition, I have added config providers as part of the set of plugins which will not support versioning, for the same reason as to why it is not supported in the other plugins that are initi

[jira] [Resolved] (KAFKA-17389) Remove ReplicaVerificationTool

2024-08-21 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang resolved KAFKA-17389. --- Resolution: Duplicate > Remove ReplicaVerificationTool > -- > >

Re: [DISCUSS] KIP-1074: Make the replication of internal topics configurable

2024-08-21 Thread Patrik Marton
Hi Omnia, Thanks, I updated the KIP with the DefaultTopicFilter changes, to reflect the new mm2.*.internal pattern. Best, Patrik On Mon, Aug 19, 2024 at 2:24 PM Omnia Ibrahim wrote: > Thanks Patrik for updating the KIP. > One last feedback, should we update `TOPICS_EXCLUDE_DEFAULT` also to > r

[jira] [Created] (KAFKA-17393) Remove message.format.version and message.timestamp.difference.max.ms in TopicConfig

2024-08-21 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-17393: - Summary: Remove message.format.version and message.timestamp.difference.max.ms in TopicConfig Key: KAFKA-17393 URL: https://issues.apache.org/jira/browse/KAFKA-17393 Projec

[jira] [Created] (KAFKA-17391) Remove bootstrap-servers in StreamsResetter

2024-08-21 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-17391: - Summary: Remove bootstrap-servers in StreamsResetter Key: KAFKA-17391 URL: https://issues.apache.org/jira/browse/KAFKA-17391 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-17390) Remove broker-list in GetOffsetShell

2024-08-21 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-17390: - Summary: Remove broker-list in GetOffsetShell Key: KAFKA-17390 URL: https://issues.apache.org/jira/browse/KAFKA-17390 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-17392) Remove whitelist in ConsoleConsumerOptions

2024-08-21 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-17392: - Summary: Remove whitelist in ConsoleConsumerOptions Key: KAFKA-17392 URL: https://issues.apache.org/jira/browse/KAFKA-17392 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-17389) Remove ReplicaVerificationTool

2024-08-21 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-17389: - Summary: Remove ReplicaVerificationTool Key: KAFKA-17389 URL: https://issues.apache.org/jira/browse/KAFKA-17389 Project: Kafka Issue Type: Sub-task Rep

[jira] [Created] (KAFKA-17388) Remove broker-list in VerifiableProducer

2024-08-21 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-17388: - Summary: Remove broker-list in VerifiableProducer Key: KAFKA-17388 URL: https://issues.apache.org/jira/browse/KAFKA-17388 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-17387) Remove broker-list in VerifiableConsumer

2024-08-21 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-17387: - Summary: Remove broker-list in VerifiableConsumer Key: KAFKA-17387 URL: https://issues.apache.org/jira/browse/KAFKA-17387 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-17386) Remove broker-list, threads, num-fetch-threads in ConsumerPerformance

2024-08-21 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-17386: - Summary: Remove broker-list, threads, num-fetch-threads in ConsumerPerformance Key: KAFKA-17386 URL: https://issues.apache.org/jira/browse/KAFKA-17386 Project: Kafka

[jira] [Created] (KAFKA-17385) Remove authorizer in AclCommand

2024-08-21 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-17385: - Summary: Remove authorizer in AclCommand Key: KAFKA-17385 URL: https://issues.apache.org/jira/browse/KAFKA-17385 Project: Kafka Issue Type: Sub-task Re

[jira] [Created] (KAFKA-17384) Remove deprecated options in tools

2024-08-21 Thread PoAn Yang (Jira)
PoAn Yang created KAFKA-17384: - Summary: Remove deprecated options in tools Key: KAFKA-17384 URL: https://issues.apache.org/jira/browse/KAFKA-17384 Project: Kafka Issue Type: Improvement