Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

2024-09-27 Thread TengYao Chi
Hi Matthias, Thanks for the explanation, particularly regarding the important considerations for both the plain consumer and Kafka Streams use cases. In this case, I think it would be better to stick with my initial proposal. We should give plain consumers the ability to determine whether to send

Re: [VOTE] KIP-1080: Fix the typo: `maxlifeTimeMs` in CreateDelegationTokenOptions

2024-09-27 Thread 黃竣陽
Hello everyone, I hope this message finds you well. As the vote has been pending for more than two weeks, I would like to push it manually. Thank you for your attention. Best regards, Jiunn-Yang > Lianet M. 於 2024年9月10日 晚上11:06 寫道: > > Hello, > > Thanks for updating the KIP. Looks good to me n

[VOTE] KIP-1089: Allow disabling heartbeats replication in MirrorSourceConnector

2024-09-27 Thread Dániel Urbán
Hi everyone, I would like to start a vote on KIP-1089: Allow disabling heartbeats replication in MirrorSourceConnector ( https://cwiki.apache.org/confluence/display/KAFKA/KIP-1089%3A+Allow+disabling+heartbeats+replication+in+MirrorSourceConnector ). TIA, Daniel

Re: [VOTE] KIP-1076: Metrics for client applications a KIP-714 extension

2024-09-27 Thread Bill Bejeck
Hi All, Just a quick update on KIP-1076. Due to the ad hoc connections made by the `AdminClient` I've updated the KIP to state that the default value of the `AdminClient.ENABLE_METRICS_PUSH_CONFIG` will be set to false. I expect this minor change to be non-controversial, but it should be noted in

[jira] [Created] (KAFKA-17645) KIP-1052: Enable warmup in producer performance test

2024-09-27 Thread Matt Welch (Jira)
Matt Welch created KAFKA-17645: -- Summary: KIP-1052: Enable warmup in producer performance test Key: KAFKA-17645 URL: https://issues.apache.org/jira/browse/KAFKA-17645 Project: Kafka Issue Type:

RE: [VOTE] KIP-1052: Enable warmup in producer performance test

2024-09-27 Thread Welch, Matt
Thank you David and Chia-Ping for voting. @David I added the mention of the new command line argument in the public interfaces section. This brings our total to +3 binding, +1 non-binding so I will conclude the vote as *approved*: Federico Valeri: +1 (non-binding) Justine Olshan: +1 (binding) Da

Re: [DISCUSS] KIP-1094 Add a new constructor method with nextOffsets to ConsumerRecords

2024-09-27 Thread Andrew Schofield
Hi Matthias, Tests will also create ConsumerRecords. I don't see the point in forcing a bunch of trivial changes to tests, that's all. Of course, it's not too hard to tweak the tests, but it's making work. Thanks, Andrew From: Matthias J. Sax Sent: 27 Se

[jira] [Created] (KAFKA-17642) Add ProspectiveState and ProspectiveStateTest

2024-09-27 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-17642: Summary: Add ProspectiveState and ProspectiveStateTest Key: KAFKA-17642 URL: https://issues.apache.org/jira/browse/KAFKA-17642 Project: Kafka Issue Type: Sub

[jira] [Created] (KAFKA-17641) Update vote RPC with new pre-vote field

2024-09-27 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-17641: Summary: Update vote RPC with new pre-vote field Key: KAFKA-17641 URL: https://issues.apache.org/jira/browse/KAFKA-17641 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-17639) Add Java 23 to CI build matrix

2024-09-27 Thread Greg Harris (Jira)
Greg Harris created KAFKA-17639: --- Summary: Add Java 23 to CI build matrix Key: KAFKA-17639 URL: https://issues.apache.org/jira/browse/KAFKA-17639 Project: Kafka Issue Type: Task Rep

[jira] [Created] (KAFKA-17640) Document Java 23 support and include release note

2024-09-27 Thread Greg Harris (Jira)
Greg Harris created KAFKA-17640: --- Summary: Document Java 23 support and include release note Key: KAFKA-17640 URL: https://issues.apache.org/jira/browse/KAFKA-17640 Project: Kafka Issue Type: T

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

2024-09-27 Thread Chia-Ping Tsai
hi Matthias > 100: Why do we want to distinguish between the classic and the new async consumer? Should they not have the same (user facing) behavior? Or maybe I misunderstand something. Can one catch we up what epoch "-1" vs epoch "-2" means? I apologize for any confusion in my earlier explanat

Re: New release branch 3.9

2024-09-27 Thread David Arthur
Federico, thanks for the report. I also tried it locally and it looks like a regression for 3.9. I agree that this should be a blocker. -David On Fri, Sep 27, 2024 at 2:03 PM Colin McCabe wrote: > Hi Greg, > > I think new JDK support is a new feature rather than a bugfix. So we > wouldn't inclu

[jira] [Created] (KAFKA-17644) TLA+ spec modifications

2024-09-27 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-17644: Summary: TLA+ spec modifications Key: KAFKA-17644 URL: https://issues.apache.org/jira/browse/KAFKA-17644 Project: Kafka Issue Type: Sub-task Repo

Re: [DISCUSS] KIP-1094 Add a new constructor method with nextOffsets to ConsumerRecords

2024-09-27 Thread Matthias J. Sax
Thanks for the KIP Alieh. Deprecating the existing constructor won't break anybody atm, right? We don't remove the constructor yet. Of course, in 5.0 in the future we would apply this breaking change. While `ConsumerRecord` is a public API, it seems that actual user code should never create

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

2024-09-27 Thread Matthias J. Sax
Thanks for the KIP. Two questions/comments: 100: Why do we want to distinguish between the classic and the new async consumer? Should they not have the same (user facing) behavior? Or maybe I misunderstand something. Can one catch we up what epoch "-1" vs epoch "-2" means? 101: I think we

[jira] [Created] (KAFKA-17643) Response handling for pre-vote set to True

2024-09-27 Thread Alyssa Huang (Jira)
Alyssa Huang created KAFKA-17643: Summary: Response handling for pre-vote set to True Key: KAFKA-17643 URL: https://issues.apache.org/jira/browse/KAFKA-17643 Project: Kafka Issue Type: Sub-ta

Re: New release branch 3.9

2024-09-27 Thread Colin McCabe
Hi Greg, I think new JDK support is a new feature rather than a bugfix. So we wouldn't include it in 3.9.x for that reason. It may be a compatible new feature, of course (most new features are...) but still a new feature. I'll comment more on the KIP-1006 thread... my main comment there is tha

[jira] [Created] (KAFKA-17638) Add support for Java 23

2024-09-27 Thread Greg Harris (Jira)
Greg Harris created KAFKA-17638: --- Summary: Add support for Java 23 Key: KAFKA-17638 URL: https://issues.apache.org/jira/browse/KAFKA-17638 Project: Kafka Issue Type: Improvement Affects Ver

Re: [VOTE] KIP-1034: Dead letter queue in Kafka Streams

2024-09-27 Thread Damien Gasparina
Thanks Bill, Bruno, Sophie, I’ll conclude the vote with your 3 binding votes. Thank you everyone! Damien On Thu, 26 Sept 2024 at 15:21, Bill Bejeck wrote: > > Thanks for the KIP, this will be a great addition. > > +1(binding) > > Regards, > Bill > > On Thu, Sep 26, 2024 at 9:19 AM Bruno Cadonna

[jira] [Resolved] (KAFKA-17581) AsyncKafkaConsumer can't unsubscribe invalid topics

2024-09-27 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-17581. Resolution: Fixed > AsyncKafkaConsumer can't unsubscribe invalid topics >

Re: [VOTE] KIP-1090 Flaky Test Management

2024-09-27 Thread Federico Valeri
+1 non binding Great work David! On Fri, Sep 27, 2024 at 10:47 AM Bruno Cadonna wrote: > > Thanks, David! > > +1 (binding) > > Best, > Bruno > > On 9/27/24 10:16 AM, Lucas Brutschy wrote: > > +1 (binding) > > > > Thanks, David, for all the hard work on this > > > > On Fri, Sep 27, 2024 at 2:21 A

[jira] [Created] (KAFKA-17637) Invert the search for LIST_OFFSETS request for remote storage topic

2024-09-27 Thread Kamal Chandraprakash (Jira)
Kamal Chandraprakash created KAFKA-17637: Summary: Invert the search for LIST_OFFSETS request for remote storage topic Key: KAFKA-17637 URL: https://issues.apache.org/jira/browse/KAFKA-17637 P

Re: New release branch 3.9

2024-09-27 Thread Federico Valeri
Hello, I think I found a blocker, because the issue is related to a fairly common setup: https://issues.apache.org/jira/browse/KAFKA-17636 Let me know if you agree, or I'm missing something here. Thanks Fede On Thu, Sep 26, 2024 at 7:31 PM Greg Harris wrote: > > Hey Colin, > > KIP-1006 and the

[jira] [Created] (KAFKA-17636) StorageTool does not write SCRAM credentials when formatting disk

2024-09-27 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-17636: --- Summary: StorageTool does not write SCRAM credentials when formatting disk Key: KAFKA-17636 URL: https://issues.apache.org/jira/browse/KAFKA-17636 Project: Kafk

[jira] [Resolved] (KAFKA-17286) Flaky PlaintextConsumerSubscriptionTest#testSubscribeInvalidTopic

2024-09-27 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-17286. Resolution: Fixed > Flaky PlaintextConsumerSubscriptionTest#testSubscribeInvalidTopic > --

[jira] [Resolved] (KAFKA-17522) Share partition acquire() need not return a future

2024-09-27 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-17522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal resolved KAFKA-17522. --- Resolution: Duplicate > Share partition acquire() need not return a future > ---

[jira] [Created] (KAFKA-17635) Lost events on internal repartition topic when excatly_once_v2 is set and producer is fenced

2024-09-27 Thread Herbert Wespi (Jira)
Herbert Wespi created KAFKA-17635: - Summary: Lost events on internal repartition topic when excatly_once_v2 is set and producer is fenced Key: KAFKA-17635 URL: https://issues.apache.org/jira/browse/KAFKA-17635

[jira] [Created] (KAFKA-17634) Tighten up wakeup handling for share consumer

2024-09-27 Thread Andrew Schofield (Jira)
Andrew Schofield created KAFKA-17634: Summary: Tighten up wakeup handling for share consumer Key: KAFKA-17634 URL: https://issues.apache.org/jira/browse/KAFKA-17634 Project: Kafka Issue T

[jira] [Created] (KAFKA-17633) Implement formatter for share group state topic records

2024-09-27 Thread Sushant Mahajan (Jira)
Sushant Mahajan created KAFKA-17633: --- Summary: Implement formatter for share group state topic records Key: KAFKA-17633 URL: https://issues.apache.org/jira/browse/KAFKA-17633 Project: Kafka

Re: [DISCUSS] KIP-1094 Add a new constructor method with nextOffsets to ConsumerRecords

2024-09-27 Thread Andrew Schofield
Hi Alieh, Thanks for the KIP. Looks like a nice addition to me. I prefer not deprecating the existing constructor too. Thanks, Andrew From: Alieh Saeedi Sent: 27 September 2024 09:09 To: dev@kafka.apache.org Subject: Re: [DISCUSS] KIP-1094 Add a new con

Re: [VOTE] KIP-1090 Flaky Test Management

2024-09-27 Thread Bruno Cadonna
Thanks, David! +1 (binding) Best, Bruno On 9/27/24 10:16 AM, Lucas Brutschy wrote: +1 (binding) Thanks, David, for all the hard work on this On Fri, Sep 27, 2024 at 2:21 AM David Arthur wrote: Could you please add the KIP link to KAFKA-17629 Done. On Thu, Sep 26, 2024 at 8:11 PM Bill

Re: [VOTE] KIP-1090 Flaky Test Management

2024-09-27 Thread Lucas Brutschy
+1 (binding) Thanks, David, for all the hard work on this On Fri, Sep 27, 2024 at 2:21 AM David Arthur wrote: > > > Could you please add the KIP link to KAFKA-17629 > > Done. > > On Thu, Sep 26, 2024 at 8:11 PM Bill Bejeck wrote: > > > +1 > > > > On Thu, Sep 26, 2024 at 8:08 PM Lianet M. wrote

Re: [VOTE] KIP-1034: Dead letter queue in Kafka Streams

2024-09-27 Thread Lucas Brutschy
Thanks for the KIP! +1 (binding) Cheers, Lucas On Thu, Sep 26, 2024 at 3:22 PM Bill Bejeck wrote: > > Thanks for the KIP, this will be a great addition. > > +1(binding) > > Regards, > Bill > > On Thu, Sep 26, 2024 at 9:19 AM Bruno Cadonna wrote: > > > Thanks Loïc, Sebastien, and Damien, > > >

Re: [DISCUSS] KIP-1094 Add a new constructor method with nextOffsets to ConsumerRecords

2024-09-27 Thread Alieh Saeedi
Thank you, Bill and Sophie. @Bill: You are right. I updated the KIP. @Sophie: Yes, it was also our concern, but we thought we should keep the current constructor in order to not break the user's code who has called this constructor in their code. Thanks, Alieh On Fri, Sep 27, 2024 at 1:07 AM Sop

[jira] [Created] (KAFKA-17632) Custom `partitioner.class` with an even number of partitions always writes to even partitions

2024-09-27 Thread thanhlv (Jira)
thanhlv created KAFKA-17632: --- Summary: Custom `partitioner.class` with an even number of partitions always writes to even partitions Key: KAFKA-17632 URL: https://issues.apache.org/jira/browse/KAFKA-17632 P