Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

Hi Sophie, Thanks for the suggestions. I have reviewed the `close()` method implementation for both the Classic and Async Consumers. I believe the `timeout` parameter could have a default value, and this default should align with the existing `Consumer#close()` method, which internally calls the

Re: [DISCUSS] KIP-1094 Add a new constructor method with nextOffsets to ConsumerRecords

@sophie I meant AK tests. But you make a fair point. There will not be that many instances I'm sure, so if the consensus is to deprecate the old constructor, that's fine with me. From: Sophie Blee-Goldman Sent: 28 September 2024 22:56 To: dev@kafka.apache.

Jenkins build is still unstable: Kafka » Kafka PowerPC Daily » test-powerpc #71

See

[jira] [Created] (KAFKA-17651) Implement `describeDelegationToken`, `describeUserScramCredentials` and `unregisterBroker`

TengYao Chi created KAFKA-17651: --- Summary: Implement `describeDelegationToken`, `describeUserScramCredentials` and `unregisterBroker` Key: KAFKA-17651 URL: https://issues.apache.org/jira/browse/KAFKA-17651

[jira] [Created] (KAFKA-17650) validate ReplaceField config

TaiJuWu created KAFKA-17650: --- Summary: validate ReplaceField config Key: KAFKA-17650 URL: https://issues.apache.org/jira/browse/KAFKA-17650 Project: Kafka Issue Type: Bug Reporter: TaiJ

[jira] [Resolved] (KAFKA-16761) ZkClusterInstance#start does not create ClusterConfigurableIntegrationHarness

[ https://issues.apache.org/jira/browse/KAFKA-16761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16761. Resolution: Won't Fix zk-related code is removed from trunk > ZkClusterInstance#start doe

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

hi Sophie Fewer overloads are preferable, so in my opinion, the consumer should only have close() and close(CloseOptions), with the other overloads deprecated. That means all options in CloseOptions should be optional, and we should use a fluent-style API to add setters for them. This would allow

Re: [DISCUSS] KIP-1094 Add a new constructor method with nextOffsets to ConsumerRecords

Sophie, yes, that a fair summary, and yes, it was only an alternative idea for the case that people think, allowing to disable leave-group request for the plain consumer is not desirable. Seems we are actually on the same page. On 9/28/24 2:56 PM, Sophie Blee-Goldman wrote: @Andrew do you me

Re: [DISCUSS] KIP-1094 Add a new constructor method with nextOffsets to ConsumerRecords

@Andrew do you mean user tests might create ConsumerRecords, or are you concerned about AK tests? I guess Alieh would be the one to implement this, so I'll leave it up to her to investigate the current usage of the existing constructor and whether it feels like too much trivial work to remove it f

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

@Matthias, regarding your questions in 101, is it fair to summarize your points here as (A) only Kafka Streams, but not plain consumer, would need to avoid leaving the group on close (for non-static members), and (B) with KIP-1088 we will soon have a Streams-specific Consumer API that would be more

[jira] [Resolved] (KAFKA-12358) Migrate to Java 11

[ https://issues.apache.org/jira/browse/KAFKA-12358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-12358. Resolution: Duplicate this will be fixed by KAFKA-12894 > Migrate to Java 11 > --

RE: [VOTE] KIP-1087: Removing intermediateTopicsOption from StreamsResetter

Hey Everyone, The vote is closed. The KIP has been accepted with 4 binding votes (Sophie, Lucas, Chia-Ping, and Matthias). Thanks for your feedback and participation! Best, Arnav Dadarya On 2024/09/03 16:35:43 Arnav Dadarya wrote: > Hello All, > > I would like to call for a vote on KIP-1087: >

[jira] [Resolved] (KAFKA-6197) Difficult to get to the Kafka Streams javadocs

[ https://issues.apache.org/jira/browse/KAFKA-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-6197. Fix Version/s: 4.0.0 Resolution: Fixed > Difficult to get to the Kafka Streams javad

[jira] [Created] (KAFKA-17649) Remove none-StateUpdater Code

Matthias J. Sax created KAFKA-17649: --- Summary: Remove none-StateUpdater Code Key: KAFKA-17649 URL: https://issues.apache.org/jira/browse/KAFKA-17649 Project: Kafka Issue Type: Task

Build failed in Jenkins: Kafka » Kafka Branch Builder » 3.9 #79

See Changes: -- [...truncated 409901 lines...] [2024-09-28T18:25:02.363Z] [2024-09-28T18:25:02.363Z] Gradle Test Run :core:test > Gradle Test Executor 98 > ZkMigrationClientT

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

hi TengYao Could you please consider adding a "default" behavior for leaveGroup? As I previously mentioned, leaveGroup=true is not ideal as the default for static members, and similarly, leaveGroup=false is not suitable as the default for dynamic members. Maybe we could change the type of leaveGr

Re: [DISCUSS] KIP-1092: Extend Consumer#close with an option to leave the group or not

Hi Sophie Thanks for feedback. I have updated the Public Interface part accordingly. Please take a look. Best, TengYao TengYao Chi 於 2024年9月28日 週六 下午1:26寫道： > Hi Matthias, > > Thanks for the explanation, particularly regarding the important > considerations for both the plain consumer and Kafk

[jira] [Created] (KAFKA-17648) AsyncKafkaConsumer#unsubscribe swallow TopicAuthorizationException

PoAn Yang created KAFKA-17648: - Summary: AsyncKafkaConsumer#unsubscribe swallow TopicAuthorizationException Key: KAFKA-17648 URL: https://issues.apache.org/jira/browse/KAFKA-17648 Project: Kafka

[jira] [Created] (KAFKA-17647) Check PlaintextConsumerSubscriptionTest#testSubscribeInvalidTopicCanUnsubscribe really ignore ErrorEvent

PoAn Yang created KAFKA-17647: - Summary: Check PlaintextConsumerSubscriptionTest#testSubscribeInvalidTopicCanUnsubscribe really ignore ErrorEvent Key: KAFKA-17647 URL: https://issues.apache.org/jira/browse/KAFKA-1764

[jira] [Created] (KAFKA-17646) Fix flaky KafkaStreamsTest.testStateGlobalThreadClose

Yu-Lin Chen created KAFKA-17646: --- Summary: Fix flaky KafkaStreamsTest.testStateGlobalThreadClose Key: KAFKA-17646 URL: https://issues.apache.org/jira/browse/KAFKA-17646 Project: Kafka Issue Typ