Hello everyone,
I would like to start the discussion thread for KIP-1068. This is a
relatively small KIP, only proposing to add a couple of new metrics.
If you have any suggestions or feedback, let me know, it will be much
appreciated.
Hello everyone,
I would like to start the discussion thread for KIP-1068. This is a
relatively small KIP, only proposing to add a couple of new metrics.
If you have any suggestions or feedback, let me know, it will be much
appreciated.
he link to the KIP document.
> >
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-1068%3A+New+JMX+metrics+for+the+new+KafkaConsumer
> >
> > Any comment is appreciated,
> >
> >
> > On Tue, Jul 9, 2024 at 10:14 AM Brenden Deluna
>
> > wrote:
> &g
simply `unsent-requests`?
> > LB3. "the proposed metrics below will be set to null or 0." → which
> > one will be set to null and which ones will be set to 0, and why?
> >
> > nit: "The current number of unsent requests in the consumer network" →
> &
have any more suggestions!
Thanks,
Brenden
On Fri, Jul 12, 2024 at 2:11 PM Brenden Deluna wrote:
> Hi Lucas,
>
> Thank you for the feedback! I have addressed your comments:
>
>
> LB1. Good catch there, I will update the names as needed.
>
>
> LB2. Good catch again
llow this convention. I would tend to err on the
> side of
> consistency with the existing metrics and not use `.ms`. However, that’s
> just my
> opinion, so I’d be interested to know what other reviewers of the KIP
> think.
>
> Thanks,
> Andrew
>
> > On 12 Jul 2024
ns in Kafka
> > Connect
> > and MirrorMaker do not follow this convention. I would tend to err on the
> > side of
> > consistency with the existing metrics and not use `.ms`. However, that’s
> > just my
> > opinion, so I’d be interested to know what other reviewers of t
eue-size useful. I was
> just wondering about the asymmetry between background-event-queue and
> application-event-queue.
>
> Best,
> Bruno
>
>
>
> On 7/19/24 9:14 PM, Brenden Deluna wrote:
> > Hi Apoorv,
> > Thank you for your comments, I will address each.
>
not useful, why is background-event-queue-size useful. I was
> > just wondering about the asymmetry between background-event-queue and
> > application-event-queue.
> >
> > Best,
> > Bruno
> >
> >
> >
> > On 7/19/24 9:14 PM, Brenden Deluna wro
Hello everyone,
I believe now this KIP is ready for a vote. I will be starting the vote
here momentarily.
Thanks again,
Brenden
On Wed, Jul 24, 2024 at 11:01 AM Brenden Deluna
wrote:
> Hi Mickael,
> Thank you for your feedback.
>
> 1. I can see that, I will get that change
Hello everyone,
I would like to start the vote on KIP-1068:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-1068%3A+New+metrics+for+the+new+KafkaConsumer
This KIP introduces new metrics for the new KafkaConsumer implementation
for broader metrics coverage.
Thanks,
Brenden
Brenden DeLuna created KAFKA-16912:
--
Summary: Migrate ConsumerNetworkThreadTest.testPollResultTimer()
to NetworkClientDelegateTest
Key: KAFKA-16912
URL: https://issues.apache.org/jira/browse/KAFKA-16912
[
https://issues.apache.org/jira/browse/KAFKA-16000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Brenden DeLuna resolved KAFKA-16000.
Resolution: Fixed
[https://github.com/apache/kafka/pull/16312] merged
> Migr
13 matches
Mail list logo
