Re: Should InvalidTopicException be called IllegalTopicException

2017-02-16 Thread Cosmin Lehene
From: Cosmin Lehene Sent: Thursday, February 16, 2017 4:29:14 PM To: dev@kafka.apache.org Subject: Should InvalidTopicException be called IllegalTopicException It's a bit confusing when trying to understand what's the difference between UnknownTopicOrPartitionException

Should InvalidTopicException be called IllegalTopicException

2017-02-16 Thread Cosmin Lehene
It's a bit confusing when trying to understand what's the difference between UnknownTopicOrPartitionException (retriable) and InvalidTopicException (non-retriable). Looking through the code to figure out what's an invalid topic I see most tests that throw it describe it as "illegal". This is

[jira] [Commented] (KAFKA-1566) Kafka environment configuration (kafka-env.sh)

2014-08-04 Thread Cosmin Lehene (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084778#comment-14084778 ] Cosmin Lehene commented on KAFKA-1566: -- The convention is to have it in conf/ We can

[jira] [Commented] (KAFKA-1566) Kafka environment configuration (kafka-env.sh)

2014-08-04 Thread Cosmin Lehene (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14084788#comment-14084788 ] Cosmin Lehene commented on KAFKA-1566: -- Somehow related: KAFKA_LOG_DIR would

[jira] [Created] (KAFKA-1566) Kafka environment configuration (kafka-env.sh)

2014-08-01 Thread Cosmin Lehene (JIRA)
Cosmin Lehene created KAFKA-1566: Summary: Kafka environment configuration (kafka-env.sh) Key: KAFKA-1566 URL: https://issues.apache.org/jira/browse/KAFKA-1566 Project: Kafka Issue Type

[jira] [Updated] (KAFKA-1566) Kafka environment configuration (kafka-env.sh)

2014-08-01 Thread Cosmin Lehene (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cosmin Lehene updated KAFKA-1566: - Description: It would be useful (especially for automated deployments) to have an environment

Fixes for 0.8 in trunk, absent from 0.8 branch

2013-08-06 Thread Cosmin Lehene
Hey guys, There are a few fixes which are marked for 0.8 and fixed in JIRA but have only been pushed to trunk and missing from 0.8 https://issues.apache.org/jira/browse/KAFKA-925 https://issues.apache.org/jira/browse/KAFKA-852 https://issues.apache.org/jira/browse/KAFKA-995

[jira] [Commented] (KAFKA-347) change number of partitions of a topic online

2013-08-06 Thread Cosmin Lehene (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13730616#comment-13730616 ] Cosmin Lehene commented on KAFKA-347: - Is there some operational documentation on how

Re: Make documentation part of new features acceptance criteria?

2013-07-11 Thread Cosmin Lehene
a release without this. It is debatable whether this should apply to beta releases, but probably it should. We can certainly apply it to the final 0.8 release if people are on board. -Jay On Wed, Jul 10, 2013 at 1:17 AM, Cosmin Lehene cleh...@adobe.com wrote: I'm not sure if there's already

Make documentation part of new features acceptance criteria?

2013-07-10 Thread Cosmin Lehene
I'm not sure if there's already a guideline like this, but I wouldn't it make sense to have it in order to keep documentation in sync with the code? Also, having this type of documentation as part of the codebase to allow proper versioning might be a good idea as well. Cosmin

Re: Kafka/Hadoop consumers and producers

2013-07-03 Thread Cosmin Lehene
If the Hadoop consumer/producers use-case will remain relevant for Kafka (I assume it will), it would make sense to have the core components (kafka input/output format at least) as part of Kafka so that it could be built, tested and versioned together to maintain compatibility. This would also

[jira] [Created] (KAFKA-960) Upgrade Metrics to 3.x

2013-07-03 Thread Cosmin Lehene (JIRA)
Cosmin Lehene created KAFKA-960: --- Summary: Upgrade Metrics to 3.x Key: KAFKA-960 URL: https://issues.apache.org/jira/browse/KAFKA-960 Project: Kafka Issue Type: Improvement Affects

[jira] [Commented] (KAFKA-826) Make Kafka 0.8 depend on metrics 2.2.0 instead of 3.x

2013-07-03 Thread Cosmin Lehene (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13699191#comment-13699191 ] Cosmin Lehene commented on KAFKA-826: - https://issues.apache.org/jira/browse/KAFKA-960

[jira] [Commented] (KAFKA-960) Upgrade Metrics to 3.x

2013-07-03 Thread Cosmin Lehene (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13699389#comment-13699389 ] Cosmin Lehene commented on KAFKA-960: - [~jjkoshy] I was going to set it back on 3.x

[jira] [Updated] (KAFKA-843) Re-add the release-zip sbt target

2013-04-17 Thread Cosmin Lehene (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cosmin Lehene updated KAFKA-843: Attachment: 0001-KAFKA-843-Addendum-comply-with-Semantic-Versioning-2.patch Added new patch

[jira] [Commented] (KAFKA-843) Re-add the release-zip sbt target

2013-04-16 Thread Cosmin Lehene (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13632656#comment-13632656 ] Cosmin Lehene commented on KAFKA-843: - [~junrao] Is the last patch ok

[jira] [Updated] (KAFKA-843) Re-add the release-zip sbt target

2013-04-13 Thread Cosmin Lehene (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cosmin Lehene updated KAFKA-843: Attachment: 0001-KAFKA-843-Addendum-comply-with-Semantic-Versioning-2.patch Attached an addendum

[jira] [Comment Edited] (KAFKA-843) Re-add the release-zip sbt target

2013-04-13 Thread Cosmin Lehene (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630955#comment-13630955 ] Cosmin Lehene edited comment on KAFKA-843 at 4/13/13 6:00 AM

[jira] [Comment Edited] (KAFKA-843) Re-add the release-zip sbt target

2013-04-13 Thread Cosmin Lehene (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13630955#comment-13630955 ] Cosmin Lehene edited comment on KAFKA-843 at 4/13/13 6:01 AM

[jira] [Commented] (KAFKA-843) Re-add the release-zip sbt target

2013-04-11 Thread Cosmin Lehene (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629238#comment-13629238 ] Cosmin Lehene commented on KAFKA-843: - [~scott_carey] fi an empty build number

[jira] [Commented] (KAFKA-843) Re-add the release-zip sbt target

2013-04-11 Thread Cosmin Lehene (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13629417#comment-13629417 ] Cosmin Lehene commented on KAFKA-843: - Perhaps, then, append -buildNumber

[jira] [Updated] (KAFKA-843) Re-add the release-zip sbt target

2013-04-10 Thread Cosmin Lehene (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cosmin Lehene updated KAFKA-843: Affects Version/s: 0.8 Status: Patch Available (was: Open) added release, release

[jira] [Comment Edited] (KAFKA-843) Re-add the release-zip sbt target

2013-04-10 Thread Cosmin Lehene (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13627720#comment-13627720 ] Cosmin Lehene edited comment on KAFKA-843 at 4/10/13 12:22 PM

[jira] [Updated] (KAFKA-843) Re-add the release-zip sbt target

2013-04-10 Thread Cosmin Lehene (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cosmin Lehene updated KAFKA-843: Attachment: KAFKA-843.patch Changed the patch so that both zip and tar are created in the target

[jira] [Created] (KAFKA-843) Re-add the release-zip sbt target

2013-04-02 Thread Cosmin Lehene (JIRA)
Cosmin Lehene created KAFKA-843: --- Summary: Re-add the release-zip sbt target Key: KAFKA-843 URL: https://issues.apache.org/jira/browse/KAFKA-843 Project: Kafka Issue Type: Sub-task

Re: How to create a deployable release?

2013-04-02 Thread Cosmin Lehene
that has all the dependencies , configs and scripts. Patches are welcome! Thanks, Neha On Mon, Apr 1, 2013 at 8:14 AM, Cosmin Lehene cleh...@adobe.com wrote: Hi, Reading the documentation it seems there should be a release-zip task (release-zip : Create all the jars, run unit tests

How to create a deployable release?

2013-04-01 Thread Cosmin Lehene
Hi, Reading the documentation it seems there should be a release-zip task (release-zip : Create all the jars, run unit tests and create a deployable release zip) I can't see it, nor can I find the equivalent. Any hints? Thanks, Cosmin