GitHub user Kaiserchen opened a pull request:

    https://github.com/apache/kafka/pull/1705

    KAFKA-3817: KTableRepartitionMap publish old Change first, for non-count 
aggregates

    I affirm that the contribution is my original work and that I license the 
work to the project under the project's open source license. 
    
    This cleans up misbehaviour that was introduce while fixing KAFKA-3817. It 
is impossible for a non-count aggregate to be build, when the addition happens 
before the removal. IMHO making sure that these details are correct is very 
important. 
    
    This PR has local test errors. It somehow fails the ResetIntegrationTest. 
It doesn't quite appear to me why but it looks like this PR breaks it, 
especially because the error appears with the ordering of the events. Still I 
am unable to find where I could have broken it. Maybe not seems to fail on 
trunk aswell.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Kaiserchen/kafka 
KAFKA-3817-preserve-order-for-aggreagators

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1705.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1705
    
----
commit efb8c4b9ff1dbef8bcf874b66a228756dd017c76
Author: jfilipiak <jan.filip...@trivago.com>
Date:   2016-08-04T08:23:43Z

    KTableRepartitionMap publish old Change first, for non-count aggregates

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to