Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

2024-11-06 Thread Lianet M.
ould never throw producer-abortable exception. > > > > The handling of retriable errors for other APIs can stay unchanged -- > > .commitTransaction() and .abortTransaction() are idempotent and can be > > safely retried, read-only APIs can always be safely retried, and for > >

Re: Seeking Beginner-Friendly Contribution Opportunities in Apache Kafka

2024-11-04 Thread Lianet M.
Hello Grace, thanks for your interest in Apache Kafka! Other than the beginner's tickets marked as newbie, I suggest to also check tickets that may not have that label but are considered Minor/Trivial ( https://issues.apache.org/jira/browse/KAFKA-17936?jql=project%20%3D%20KAFKA%20AND%20status%20in

Re: [DISCUSS] KIP-1099: Extend kafka-consumer-groups command line tool to support new consumer group

2024-10-31 Thread Lianet M.
Hello Frank, thanks for the KIP! A few comments: LM1. I strongly agree with Andrew's suggestion of moving this into a --verbose option. I expect someone would only attempt to make sense of the epochs while debugging an issue, not while trying to view the group or member's info. (Also member-epoch

Re: [DISCUSS] Apache Kafka 3.7.2 release

2024-10-10 Thread Lianet M.
+1. Thanks! On Thu, Oct 10, 2024 at 12:07 PM Colin McCabe wrote: > +1. Thanks, Matthias. > > Colin > > > On Thu, Oct 10, 2024, at 08:46, Mickael Maison wrote: > > +1, thanks for volunteering > > > > Mickael > > > > On Thu, Oct 10, 2024 at 5:42 PM Bill Bejeck wrote: > >> > >> Thanks for voluntee

Re: [DISCUSS] Apache Kafka 3.8.1 release

2024-10-10 Thread Lianet M.
Done (sorry I noticed now I didn't mention I would in the previous email) Thanks! On Thu, Oct 10, 2024 at 9:41 AM Josep Prat wrote: > Hi Lianet, > > Will you backport it to the 3.8 branch, or shall I? > > Best, > > On Thu, Oct 10, 2024 at 3:26 PM Lianet M. wrote

Re: [DISCUSS] Apache Kafka 3.8.1 release

2024-10-10 Thread Lianet M.
Hey Josep, just to update that the fix (KAFKA-17731 ) is merged into trunk now. Thanks! On Thu, Oct 10, 2024 at 4:22 AM Josep Prat wrote: > Hi Matthias, > > Yes, let's add this one to the release. I got the results from the system > tests today

Re: New release branch 3.9

2024-10-10 Thread Lianet M.
Hi Colin, Also, we discovered a bug affecting 3.9, that I would see as a regression given that it degrades the consumer#close. Fix has been merged to trunk with https://github.com/apache/kafka/pull/17431 so wonder if we should include it. Thanks, Lianet On Thu, Oct 10, 2024 at 9:09 AM Mickael

Re: [DISCUSS] KIP-1050: Consistent error handling for Transactions

2024-10-04 Thread Lianet M.
Hello, thanks for the KIP! After going through the KIP and discussion here are some initial comments. 107 - I understand we’re proposing a new ProducerRetriableTransactionException, and changing existing exceptions to inherit from it (the ones on the table below it). The existing exceptions inhe

Re: [VOTE] KIP-1082: Require Client-Generated IDs over the ConsumerGroupHeartbeat RPC

2024-10-03 Thread Lianet M.
Hello TengYao, just one last minor comment. The KIP refers in multiple places to bumping the heartbeat RPC from version 0 to version 1. We should update that given that the RPC is already in version 1. With that I'm +1 (binding) Thanks! Lianet On Thu, Oct 3, 2024 at 5:01 AM David Jacot wrote:

Re: [ANNOUNCE] New committer: Kamal Chandraprakash

2024-09-30 Thread Lianet M.
Congratulations Kamal!!! On Mon, Sep 30, 2024, 9:22 a.m. Chia-Ping Tsai wrote: > Congratulations Kamal!!! > > Satish Duggana 於 2024年9月30日 週一 下午9:01寫道: > > > Congratulations Kamal! > > > > On Mon, 30 Sept 2024 at 18:18, Josep Prat > > wrote: > > > > > Congrats Kamal! > > > > > > On Mon, Sep 3

Re: [VOTE] KIP-1090 Flaky Test Management

2024-09-26 Thread Lianet M.
+1. Thanks David! On Thu, Sep 26, 2024, 7:47 p.m. Matthias J. Sax wrote: > +1 > > On 9/26/24 3:38 PM, Chia-Ping Tsai wrote: > > +1 > > > > nit: Could you please add the KIP link to KAFKA-17629 > > > > David Arthur 於 2024年9月27日 週五 上午6:31寫道: > > > >> I would like to call a vote for KIP-1090. Pl

Re: [DISCUSS] Apache Kafka 4.0.0 release

2024-09-23 Thread Lianet M.
+1 Thanks David! On Mon, Sep 23, 2024, 9:54 a.m. Justine Olshan wrote: > +1 and thanks! > > On Mon, Sep 23, 2024 at 6:36 AM Chia-Ping Tsai wrote: > > > +1 and thanks David for volunteering! > > > > Best, > > Chia-Ping > > > > Josep Prat 於 2024年9月23日 週一 下午9:13寫道: > > > > > Thanks David for vol

Re: [VOTE] KIP-1043: Administration of groups

2024-09-23 Thread Lianet M.
Hello Andrew, Thanks for the KIP. +1 (binding) Lianet On Mon, Sep 23, 2024, 3:37 a.m. Lucas Brutschy wrote: > Hi Andrew, > > thanks for the KIP! > > +1 (binding) > > Cheers, > Lucas > > On Mon, Sep 23, 2024 at 9:27 AM Andrew Schofield > wrote: > > > > Hi, > > I would like to start voting for

Re: [VOTE] KIP-1079: Deprecate `delete-config` of TopicCommand

2024-09-16 Thread Lianet M.
Thanks for the update! Looks good to me now. +1 (binding) Cheers, Lianet On Mon, Sep 16, 2024 at 9:31 AM TengYao Chi wrote: > Hi Lianet, > > Thanks for comment. > It is very helpful and I have applied it to the content of this KIP. > Please take a look. > > Sincerely, &

Re: [VOTE] KIP-1079: Deprecate `delete-config` of TopicCommand

2024-09-16 Thread Lianet M.
Hello TengYao. Thanks for the KIP, nice cleanup. Just one question left. I wonder how we make sure that we don't just bring in this KIP, deprecate the arg and forget about it?. First we could maybe mention in the KIP that is with the intention of removing the option in 5.0 (just for reference), an

Re: [DISCUSS] KIP-1043: Administration of groups

2024-09-11 Thread Lianet M.
e is as you suggest to introduce > > the new error code, INVALID_GROUP_TYPE. If you use any of the following > > RPCs with the wrong type of group, you get this response: > > > > * ConsumerGroupDescribe > > * ShareGroupDescribe > > * ConsumerGroupHeartbeat &g

Re: [VOTE] KIP-1080: Fix the typo: `maxlifeTimeMs` in CreateDelegationTokenOptions

2024-09-10 Thread Lianet M.
>> it aligns better with the RPC field (max_lifetime_ms) > > > > That makes sense to me. +1 to align it > > > > Best, > > Chia-Ping > > > > Lianet M. 於 2024年9月5日 週四 下午11:13寫道: > > > >> Hey all, just one small comment: shouldn't the

Re: [VOTE] KIP-1080: Fix the typo: `maxlifeTimeMs` in CreateDelegationTokenOptions

2024-09-05 Thread Lianet M.
Hey all, just one small comment: shouldn't the new method be named " maxLifetimeMs()" (Lifetime vs LifeTime)? I believe it's the right spelling, but mostly, it aligns better with the RPC field (max_lifetime_ms), that generates a CreateDelegationTokenRequestData.maxLifetimeMs() and CreateDelegationT

Re: [VOTE] KIP-512: make Record Headers available in onAcknowledgement and onComplete

2024-08-29 Thread Lianet M.
Hi all, I'll re-cast my vote here :) +1 (binding) Thanks Rich! On Fri, Aug 23, 2024, 10:32 p.m. Chia-Ping Tsai wrote: > +1 (binding) > > On 2024/08/10 17:28:45 "Rich C." wrote: > > Hi all, > > > > After incorporating the feedback received > >

Re: [ANNOUNCE] New committer: Lianet Magrans

2024-08-28 Thread Lianet M.
Thank you very much everyone! It truly takes the great shared knowledge you all put out there with amazing reviews and discussions. Looking forward to continuing working with you all! Lianet On Wed, Aug 28, 2024, 7:12 p.m. Sophie Blee-Goldman wrote: > Congrats Lianet! Well deserved > > On Wed,

Re: [DISCUSS] KIP-1082: Enable ID Generation for Clients over the ConsumerGroupHeartbeat RPC

2024-08-28 Thread Lianet M.
Hello TengYao! Thanks for taking on this issue, we've been going around it for a while. LM1: About the title of the KIP: "Enable ID Generation for Clients over the ConsumerGroupHeartbeat RPC". I find it confusing because it hints that we're adding it as an alternative (which was discussed and disc

Re: [VOTE] KIP-512: make Record Headers available in onAcknowledgement and onComplete

2024-08-13 Thread Lianet M.
Hello Rich, Sorry for the late reply, but thanks for your answers on the discussion thread and updates, it makes sense to me and the final proposal looks right. +1 (non-binding) Thanks! Lianet On Mon, Aug 12, 2024 at 10:29 AM Andrew Schofield wrote: > Hi Rich, > Thanks for the KIP. Looks goo

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

2024-08-02 Thread Lianet M.
beat RPC. I > would be in favor of making the initialize RPC independent from the > heartbeat RPC. That would allow to initialize a streams group explicitly > with an admin tool. > > > > LM6. I think it affects streams and streams should behave as the > consumer group. &

Re: [DISCUSS] KIP-512: make Record Headers available in onAcknowledgement

2024-07-30 Thread Lianet M.
Hello Rich, thanks for resurrecting the KIP, seems to fill a gap indeed. LM1. Specifically related to motivation#1. ProducerRecord already has a timestamp, passed into the RecordMetadata, that represents the creation time provided on new ProducerRecord, so couldn't we reuse it to avoid the extra c

Re: [VOTE] KIP-1068: New metrics for the new KafkaConsumer

2024-07-25 Thread Lianet M.
Hi Brenden, +1 (non-binding) from me. Thanks for the KIP! Lianet On Thu, Jul 25, 2024 at 3:18 AM Bruno Cadonna wrote: > Hi Brenden, > > Thanks for the KIP! > > +1 (binding) > > Best, > Bruno > > On 7/24/24 11:55 PM, Brenden Deluna wrote: > > Hello everyone, > > > > I would like to start the v

Re: [DISCUSS] KIP-1068: KIP-1068: New JMX Metrics for AsyncKafkaConsumer

2024-07-23 Thread Lianet M.
of > > >>>> metrics, I will get that added. > > >>>> > > >>>> > > >>>> LM3. Again great idea, that would certainly be helpful. Will add > that > > >> as > > >>>> well. > > >>>> > >

Re: [DISCUSS] KIP-1043: Administration of groups

2024-07-23 Thread Lianet M.
d use this: > >> > >> bin/kafka-groups.sh --protocol consumer > >> > >> When there are no classic consumer groups, you could do: > >> > >> bin/kafka-groups.sh --group-type consumer > >> > >> However, this only gives a

Re: [DISCUSS] KIP-1071: Streams Rebalance Protocol

2024-07-19 Thread Lianet M.
Hi Lucas/Bruno, thanks for the great KIP! First comments: LM1. Related to where the KIP says: *“Group ID, member ID, member epoch are sent with each heartbeat request. Any other information that has not changed since the last heartbeat can be omitted.”. *I expect all the other info also needs to

Re: [DISCUSS] KIP-1043: Administration of groups

2024-07-16 Thread Lianet M.
s a confection made by filtering on both group type and > protocol). > > I’ve changed the KIP accordingly. Let me know what you think. > > Thanks, > Andrew > > > > On 12 Jul 2024, at 21:48, Lianet M. wrote: > > > > Hey Andrew, thanks for the KIP, we

Re: [DISCUSS] KIP-1043: Administration of groups

2024-07-12 Thread Lianet M.
Hey Andrew, thanks for the KIP, we definitely need visibility from a higher level now that groups are growing. LM1. Should we have the existing org.apache.kafka.clients.admin.ConsumerGroupListing extend the GroupListing you’re proposing? ConsumerGroupListing already exists with a very similar shap

Re: [DISCUSS] KIP-1068: KIP-1068: New JMX Metrics for AsyncKafkaConsumer

2024-07-12 Thread Lianet M.
Hey Brenden, thanks for the KIP! Great to get more visibility into the new consumer. LM1. +1 on Lucas's suggestion for including the unit in the name, seems clearer and consistent (I do see several time metrics including ms) LM2. What about a new metric for application-event-queue-time-ms. It wou

Re: [DISCUSS] KIP-1059: Enable the Producer flush() method to clear the latest send() error

2024-06-20 Thread Lianet M.
Hi all, thanks for the KIP Alieh! LM1. Totally agree with Artem's point about the config not being the most explicit/flexible way to express this capability. Getting then to Matthias 4 options, what I don't like about 3 and 4 is that it seems they might not age very well? Aren't we going to be wan

Re: [VOTE] KIP-1033: Add Kafka Streams exception handler for exceptions occurring during processing

2024-05-14 Thread Lianet M.
+1 (non-binding) Thanks for the KIP and updates! Lianet On Tue, May 14, 2024, 12:03 a.m. Matthias J. Sax wrote: > +1 (binding) > > On 5/13/24 5:54 PM, Sophie Blee-Goldman wrote: > > Thanks for the KIP guys! > > > > +1 (binding) > > > > On Mon, May 13, 2024 at 6:02 AM Bill Bejeck wrote: > > >

Re: [DISCUSS] KIP-1033: Add Kafka Streams exception handler for exceptions occuring during processing

2024-05-01 Thread Lianet M.
Hi all, thanks Damien for the KIP! After looking into the KIP and comments, my only concern is aligned with one of Matthias comments, around the ImmutableHeaders introduction, with the motivation not being clear enough. The existing handlers already expose the headers (indirectly). Ex. ProductionE

Re: [VOTE] 3.6.2 RC2

2024-04-03 Thread Lianet M.
Hi Manikumar, I did the following checks: - downloaded and built from src - ran all unit test and integration test for clients - ran quickstart with Kraft mode - ran simple workloads with the console consumer/producer - checked all links All looks good to me with this. +1 (non-binding) Thanks!

Re: [VOTE] KIP-932: Queues for Kafka

2024-03-18 Thread Lianet M.
Hi Andrew, Happy to see this KIP unleashing the capabilities of Kafka, from the core up, to elegantly bring in a new, long wanted consumption pattern. +1 (non-binding) Lianet On Sun, Mar 17, 2024, 7:06 p.m. Andrew Schofield < andrew_schofield_j...@outlook.com> wrote: > Hi, > I’ve been working

Re: [ANNOUNCE] New committer: Lucas Brutschy

2023-09-21 Thread Lianet M.
Congratulations Lucas! On Thu, Sept 21, 2023, 11:45 a.m. Bruno Cadonna wrote: > Hi all, > > The PMC of Apache Kafka is pleased to announce a new Kafka committer > Lucas Brutschy. > > Lucas' major contributions are around Kafka Streams. > > Lucas' significantly contributed to the state updater >

Request to contribute to Kafka

2023-05-04 Thread Lianet M.
Wiki ID: lianetmr Jira ID: lianetm Both on email liane...@gmail.com Thanks! Lianet Magrans