Nag! Feedback needed for KAFKA-8676

2019-07-28 Thread Liu Luying
Hi, I have opened a JIRA ticket and a corresponding pull request for it. I think the problems mentioned in the JIRA ticket has been resolved in the pull request. Could someone review the change? Thanks in advance. Best, Luying

Re: Stopping All Tasks When a New Connector Added

2019-07-22 Thread Liu Luying
your jira account id on a separate email, so one of the committers can add you to the project. Then you or someone else will be able to assign this ticket to you. I'll review the fix some time this week. Thanks! Konstantine On Mon, Jul 22, 2019 at 5:13 AM Liu Luying wrote: > Hi Adam, >

Re: Stopping All Tasks When a New Connector Added

2019-07-21 Thread Liu Luying
Friday, July 19, 2019 10:36 To: dev@kafka.apache.org Subject: Re: Stopping All Tasks When a New Connector Added Hi Luying Would you be willing to make a PR to address this? It seems that you have already done most of the work. Thanks Adam On Thu, Jul 18, 2019 at 11:00 PM Liu Luying wrote: &

Stopping All Tasks When a New Connector Added

2019-07-18 Thread Liu Luying
Hi all, I have noticed that Kafka Connect 2.3.0 will stop all existing tasks and then start all the tasks, including the new tasks and the existing ones when adding a new connector or changing a connector configuration. However, I do not think it is a must. Only the new connector and tasks need