On Dec. 10, 2014, 12:37 a.m., Neha Narkhede wrote:
Can you add unit tests for this?
Mayuresh Gharat wrote:
Sure. I will try and add unit tests for this.
This part of the code was tested by Clark here, when had encountered an issue
where we had to fetch offsets from kafka
[
https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14238736#comment-14238736
]
Mayuresh Gharat commented on KAFKA-1784:
Yes. We are planning to do that. Actually
/OffsetClientConfig.scala PRE-CREATION
Diff: https://reviews.apache.org/r/28793/diff/
Testing
---
Thanks,
Mayuresh Gharat
/OffsetClientConfig.scala PRE-CREATION
Diff: https://reviews.apache.org/r/28793/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14237248#comment-14237248
]
Mayuresh Gharat commented on KAFKA-1784:
Created reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1784:
---
Attachment: KAFKA-1784.patch
Implement a ConsumerOffsetClient library
[
https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1784:
---
Status: Patch Available (was: Open)
Implement a ConsumerOffsetClient library
[
https://issues.apache.org/jira/browse/KAFKA-1784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14232086#comment-14232086
]
Mayuresh Gharat commented on KAFKA-1784:
Separating out the client
[
https://issues.apache.org/jira/browse/KAFKA-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14210190#comment-14210190
]
Mayuresh Gharat commented on KAFKA-1763:
Thanks for the patch.
We tested it out
[
https://issues.apache.org/jira/browse/KAFKA-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14211289#comment-14211289
]
Mayuresh Gharat commented on KAFKA-1763:
Traceback (most recent call last):
File
[
https://issues.apache.org/jira/browse/KAFKA-1763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14207592#comment-14207592
]
Mayuresh Gharat commented on KAFKA-1763:
Yeah we will probably test out today
On Nov. 8, 2014, 3:01 a.m., Mayuresh Gharat wrote:
system_test/utils/kafka_system_test_utils.py, line 2403
https://reviews.apache.org/r/27534/diff/1/?file=747724#file747724line2403
This causes many system tests (approx 98) to fail
Ewen Cheslack-Postava wrote:
Can you give
On Nov. 8, 2014, 3:01 a.m., Mayuresh Gharat wrote:
system_test/utils/kafka_system_test_utils.py, line 2403
https://reviews.apache.org/r/27534/diff/1/?file=747724#file747724line2403
This causes many system tests (approx 98) to fail
Ewen Cheslack-Postava wrote:
Can you give
://reviews.apache.org/r/27534/#comment101864
This causes many system tests (approx 98) to fail
- Mayuresh Gharat
On Nov. 3, 2014, 7:46 p.m., Ewen Cheslack-Postava wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
[
https://issues.apache.org/jira/browse/KAFKA-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat reassigned KAFKA-1742:
--
Assignee: Mayuresh Gharat
ControllerContext removeTopic does not correctly update
/unit/kafka/consumer/PartitionAssignorTest.scala
9ceae222ca5bf63e8131de0db2a94126c8b57b59
Diff: https://reviews.apache.org/r/26291/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1648:
---
Attachment: KAFKA-1648_2014-10-09_11:56:44.patch
Round robin consumer balance throws an NPE
[
https://issues.apache.org/jira/browse/KAFKA-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14165549#comment-14165549
]
Mayuresh Gharat commented on KAFKA-1648:
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14164465#comment-14164465
]
Mayuresh Gharat commented on KAFKA-1648:
Updated reviewboard https
8ea7368dc394a497164ea093ff8e9f2e6a94b1de
core/src/main/scala/kafka/consumer/ZookeeperConsumerConnector.scala
fbc680fde21b02f11285a4f4b442987356abd17b
Diff: https://reviews.apache.org/r/26291/diff/
Testing
---
Thanks,
Mayuresh Gharat
://reviews.apache.org/r/26291/#review55456
---
On Oct. 9, 2014, 12:29 a.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26291
/PartitionAssignorTest.scala
9ceae222ca5bf63e8131de0db2a94126c8b57b59
Diff: https://reviews.apache.org/r/26291/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1648:
---
Attachment: KAFKA-1648_2014-10-08_17:46:45.patch
Round robin consumer balance throws an NPE
[
https://issues.apache.org/jira/browse/KAFKA-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14164487#comment-14164487
]
Mayuresh Gharat commented on KAFKA-1648:
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1648:
---
Attachment: KAFKA-1648_2014-10-04_17:40:47.patch
Round robin consumer balance throws an NPE
[
https://issues.apache.org/jira/browse/KAFKA-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat reassigned KAFKA-1669:
--
Assignee: Mayuresh Gharat
Default rebalance retries and backoff should be higher
/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1669:
---
Attachment: KAFKA-1669.patch
Default rebalance retries and backoff should be higher
[
https://issues.apache.org/jira/browse/KAFKA-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14158639#comment-14158639
]
Mayuresh Gharat commented on KAFKA-1669:
Created reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-1669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1669:
---
Status: Patch Available (was: Open)
Default rebalance retries and backoff should be higher
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1610:
---
Attachment: KAFKA-1610_2014-10-02_12:07:01.patch
Local modifications to collections
/server/LeaderElectionTest.scala
c2ba07c5fdbaf0e65ca033b2e4d88f45a8a15b2e
Diff: https://reviews.apache.org/r/25136/diff/
Testing
---
Ran the unit tests and everything passed and the build succeeeded
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14156991#comment-14156991
]
Mayuresh Gharat commented on KAFKA-1610:
Updated reviewboard https
/unit/kafka/server/LeaderElectionTest.scala
c2ba07c5fdbaf0e65ca033b2e4d88f45a8a15b2e
Diff: https://reviews.apache.org/r/25136/diff/
Testing
---
Ran the unit tests and everything passed and the build succeeeded
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157000#comment-14157000
]
Mayuresh Gharat commented on KAFKA-1610:
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1610:
---
Attachment: KAFKA-1610_2014-10-02_12:09:46.patch
Local modifications to collections
fbc680fde21b02f11285a4f4b442987356abd17b
Diff: https://reviews.apache.org/r/26291/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157333#comment-14157333
]
Mayuresh Gharat commented on KAFKA-1648:
Created reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1648:
---
Status: Patch Available (was: Open)
Round robin consumer balance throws an NPE when
[
https://issues.apache.org/jira/browse/KAFKA-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1648:
---
Attachment: KAFKA-1648.patch
Round robin consumer balance throws an NPE when
/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1013:
---
Attachment: KAFKA-1013_2014-10-02_22:42:58.patch
Modify existing tools as per the changes
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14157699#comment-14157699
]
Mayuresh Gharat commented on KAFKA-1013:
Updated reviewboard https
://reviews.apache.org/r/25136/diff/
Testing
---
Ran the unit tests and everything passed and the build succeeeded
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14154426#comment-14154426
]
Mayuresh Gharat commented on KAFKA-1610:
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1013:
---
Attachment: KAFKA-1013_2014-10-01_21:05:00.patch
Modify existing tools as per the changes
: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1013:
---
Attachment: KAFKA-1013_2014-09-26_18:52:09.patch
Modify existing tools as per the changes
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944/#review54609
---
On Sept. 23, 2014, 5:48 p.m., Mayuresh Gharat wrote
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944/#review54329
---
On Sept. 23, 2014, 5:48 p.m., Mayuresh Gharat wrote
---
On Sept. 23, 2014, 5:48 p.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944
PRE-CREATION
Diff: https://reviews.apache.org/r/25942/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145012#comment-14145012
]
Mayuresh Gharat commented on KAFKA-1013:
Created reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1013:
---
Attachment: KAFKA-1013.patch
Modify existing tools as per the changes in KAFKA-1000
/tools/OffsetClient.scala PRE-CREATION
core/src/main/scala/kafka/tools/SreOffsetTool.scala PRE-CREATION
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
/#comment94288
Please discard this
core/src/main/scala/kafka/tools/SreOffsetTool.scala
https://reviews.apache.org/r/25944/#comment94289
Please discard this!!
- Mayuresh Gharat
On Sept. 23, 2014, 5:18 p.m., Mayuresh Gharat wrote
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145060#comment-14145060
]
Mayuresh Gharat commented on KAFKA-1013:
Created reviewboard https
core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1013:
---
Attachment: KAFKA-1013_2014-09-23_10:45:59.patch
Modify existing tools as per the changes
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145110#comment-14145110
]
Mayuresh Gharat commented on KAFKA-1013:
Updated reviewboard https
/ExportOffsets.scala PRE-CREATION
core/src/main/scala/kafka/tools/ImportOffsets.scala PRE-CREATION
core/src/main/scala/kafka/tools/OffsetClient.scala PRE-CREATION
Diff: https://reviews.apache.org/r/25944/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1013:
---
Attachment: KAFKA-1013_2014-09-23_10:48:07.patch
Modify existing tools as per the changes
/#comment94290
Please discard this file for review
- Mayuresh Gharat
On Sept. 23, 2014, 5:48 p.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25944
[
https://issues.apache.org/jira/browse/KAFKA-1013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14145116#comment-14145116
]
Mayuresh Gharat commented on KAFKA-1013:
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat reassigned KAFKA-1648:
--
Assignee: Mayuresh Gharat (was: Neha Narkhede)
Round robin consumer balance throws
[
https://issues.apache.org/jira/browse/KAFKA-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat resolved KAFKA-1592.
Resolution: Duplicate
Reviewer: Guozhang Wang
Closing a duplicate as the changes were
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1610:
---
Attachment: KAFKA-1610_2014-09-16_13:08:17.patch
Local modifications to collections
af4783646803e58714770c21f8c3352370f26854
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala
c2ba07c5fdbaf0e65ca033b2e4d88f45a8a15b2e
Diff: https://reviews.apache.org/r/25136/diff/
Testing
---
Ran the unit tests and everything passed and the build succeeeded
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14136111#comment-14136111
]
Mayuresh Gharat commented on KAFKA-1610:
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1610:
---
Attachment: KAFKA-1610_2014-09-16_15:23:27.patch
Local modifications to collections
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14136372#comment-14136372
]
Mayuresh Gharat commented on KAFKA-1610:
Updated reviewboard https
,
Mayuresh Gharat
, visit:
https://reviews.apache.org/r/25136/#review53391
---
On Sept. 3, 2014, 6:27 p.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit:
https
/
Testing
---
Ran the unit tests and everything passed and the build succeeeded
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1610:
---
Attachment: KAFKA-1610_2014-09-03_11:27:50.patch
Local modifications to collections
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14120214#comment-14120214
]
Mayuresh Gharat commented on KAFKA-1610:
Updated reviewboard https
. To reply, visit:
https://reviews.apache.org/r/25136/#review51909
---
On Aug. 29, 2014, 5:04 p.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit
and everything passed and the build succeeeded
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1610:
---
Attachment: KAFKA-1610_2014-08-29_09:51:51.patch
Local modifications to collections
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14115459#comment-14115459
]
Mayuresh Gharat commented on KAFKA-1610:
Updated reviewboard https
and the build succeeeded
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14115478#comment-14115478
]
Mayuresh Gharat commented on KAFKA-1610:
Updated reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1610:
---
Attachment: KAFKA-1610_2014-08-29_10:03:55.patch
Local modifications to collections
)
---
Ran the unit tests and everything passed and the build succeeeded
Thanks,
Mayuresh Gharat
/#review51793
---
On Aug. 28, 2014, 6:12 p.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25136
---
On Aug. 28, 2014, 6:12 p.m., Mayuresh Gharat wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25136
[
https://issues.apache.org/jira/browse/KAFKA-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14112534#comment-14112534
]
Mayuresh Gharat commented on KAFKA-1591:
Hi Abhishek,
Are you working
[
https://issues.apache.org/jira/browse/KAFKA-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat reassigned KAFKA-1592:
--
Assignee: Mayuresh Gharat
Some INFO level logging needs to be DEBUG
/scala/kafka/tools/ReplicaVerificationTool.scala
af4783646803e58714770c21f8c3352370f26854
core/src/test/scala/unit/kafka/server/LeaderElectionTest.scala
c2ba07c5fdbaf0e65ca033b2e4d88f45a8a15b2e
Diff: https://reviews.apache.org/r/25136/diff/
Testing
---
Thanks,
Mayuresh Gharat
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1610:
---
Status: Patch Available (was: Open)
Local modifications to collections generated from
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat updated KAFKA-1610:
---
Attachment: KAFKA-1610.patch
Local modifications to collections generated from mapValues
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14113232#comment-14113232
]
Mayuresh Gharat commented on KAFKA-1610:
Created reviewboard https
[
https://issues.apache.org/jira/browse/KAFKA-1610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mayuresh Gharat reassigned KAFKA-1610:
--
Assignee: Mayuresh Gharat
Local modifications to collections generated from mapValues
501 - 593 of 593 matches
Mail list logo