Patch review KAFKA-9887

2020-11-03 Thread Michael Carter
HI there, Are there any committers interested in reviewing this pull request (It is a bugfix for the way some of the Kafka Connect metrics are recorded)? https://github.com/apache/kafka/pull/8844 Thanks, Michael

Re: First time patch submitter advice

2020-06-21 Thread Michael Carter
The guide is a bit outdated. Thank you for pointing it out. I updated the >> guide. >> >> As Gwen stated above: >> >>> Unfortunately, you need to get a committer to approve running the tests. >> >> So, yes a committer has to comment on the PR. >&g

Re: First time patch submitter advice

2020-06-18 Thread Michael Carter
com/apache/kafka/pull/8844>) like the contributing guidelines state. Unfortunately, no tests seem to have been run. Does a committer have to comment on the PR instead? Thanks, Michael > On 16 Jun 2020, at 9:33 am, Michael Carter > wrote: > > Great, thanks Luke. > I’ve undon

Re: First time patch submitter advice

2020-06-15 Thread Michael Carter
/jira/browse/KAFKA-10147 > > So, maybe you can ignore the test errors and mention the issue number in PR. > Thanks. > > Luke > > On Mon, Jun 15, 2020 at 3:23 PM Michael Carter < > michael.car...@instaclustr.com> wrote: > >> Thanks for the response Gwen, tha

Re: First time patch submitter advice

2020-06-15 Thread Michael Carter
n 3 > parallel builds, if some of them pass and the committer confirms that > failures are not related to your code, we are ok to merge. Obviously, if > you end up tracking them down and fixing, everyone will be very grateful. > > Hope this helps, > > Gwen > > On Su

First time patch submitter advice

2020-06-14 Thread Michael Carter
Hi all, I’ve submitted a patch for the first time(https://github.com/apache/kafka/pull/8844 ), and I have a couple of questions that I’m hoping someone can help me answer. I’m a little unclear what happens after that patch has been submitted. The

Re: Dynamic configuration of interbroker SSL certificates

2019-08-12 Thread Michael Carter
this since the > overhead seems to be low. The update interval can also be configured. > > Best, > Colin > > On Sun, Aug 11, 2019, at 16:43, Michael Carter wrote: >> Hi Rajini, >> >> I just thought I'd let you know I've sorted through my issue now. It turns &g

Re: Dynamic configuration of interbroker SSL certificates

2019-08-11 Thread Michael Carter
019, at 3:33 pm, Michael Carter > wrote: > > Hi Rajini, > > Thanks for the good suggestions. I’ve investigated further and confirmed that > the issue continues to occur even with hostname verification turned off. > I put in the ssl debug option and got some interesting infor

Re: Dynamic configuration of interbroker SSL certificates

2019-08-04 Thread Michael Carter
w the certs > used as well as more details about the handshake failure. > > Regards, > > Rajini > > > > On Fri, Aug 2, 2019 at 8:49 AM Michael Carter < > michael.car...@instaclustr.com> wrote: > >> Hi Rajini, >> >> Thanks for your response. I've

Dynamic configuration of interbroker SSL certificates

2019-07-31 Thread Michael Carter
Hi all, I'm having an issue with dynamic configuration of interbroker SSL certificates (in Kafka 2.3.0) that I'm hoping someone can give me insight on. I've previously posted something similar on the Users email list, but I think it will need some help from developers experienced with how the

Request to be a contributor

2019-07-30 Thread Michael Carter
Hi dev, Can I please be added to the contributor list? My JIRA username is michael_carter Cheers, Michael