[jira] [Resolved] (KAFKA-4280) Document REST resource for showing available connector plugin configs

[ https://issues.apache.org/jira/browse/KAFKA-4280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-4280. -- Resolution: Fixed The `GET /connector-plugins` endpoint has since been documented on https

[jira] [Resolved] (KAFKA-4278) Undocumented REST resources

[ https://issues.apache.org/jira/browse/KAFKA-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-4278. -- Resolution: Fixed These have since been documented. > Undocumented REST resour

[jira] [Resolved] (KAFKA-4598) Create new SourceTask commit callback method that takes offsets param

[ https://issues.apache.org/jira/browse/KAFKA-4598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-4598. -- Resolution: Implemented Marking as implemented via KAFKA-7500, via

[jira] [Resolved] (KAFKA-5067) java.sql.SQLDataException on TimeStamp column when using AWS Redshift as a JDBC source

[ https://issues.apache.org/jira/browse/KAFKA-5067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-5067. -- Resolution: Invalid Resolving as INVALID since the reported problem is not on an Apache Kafka

[jira] [Resolved] (KAFKA-5741) Prioritize threads in Connect distributed worker process

[ https://issues.apache.org/jira/browse/KAFKA-5741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-5741. -- Resolution: Won't Fix Resolving as WONTFIX, since there is no clear indication

[jira] [Resolved] (KAFKA-5740) Use separate file for HTTP logs

[ https://issues.apache.org/jira/browse/KAFKA-5740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-5740. -- Resolution: Won't Fix Resolving as WONTFIX > Use separate file for HTTP l

[jira] [Resolved] (KAFKA-5828) Allow explicitly setting polling interval for Kafka connectors

[ https://issues.apache.org/jira/browse/KAFKA-5828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-5828. -- Resolution: Won't Fix Use quotas instead. > Allow explicitly setting polling inter

[jira] [Resolved] (KAFKA-5938) Oracle jdbc-source-connector with kafka-connect distributed mode will result in http 500 error

[ https://issues.apache.org/jira/browse/KAFKA-5938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-5938. -- Resolution: Invalid Resolving as INVALID since this issue appears to report a problem

[jira] [Resolved] (KAFKA-7529) Kafka Connect JDBC doesn't push new records to Kafka Topic unless the connector is restarted

[ https://issues.apache.org/jira/browse/KAFKA-7529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-7529. -- Resolution: Invalid Resolving as INVALID since this issue does indeed appear

[jira] [Resolved] (KAFKA-8974) Sink Connectors can't handle topic list with whitespaces

[ https://issues.apache.org/jira/browse/KAFKA-8974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8974. -- Fix Version/s: 2.3.1 2.4.0 2.2.2 2.1.2

[jira] [Resolved] (KAFKA-6290) Kafka Connect cast transformation should support logical types

[ https://issues.apache.org/jira/browse/KAFKA-6290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-6290. -- Fix Version/s: 2.3.1 2.4.0 2.2.2 2.1.2

[jira] [Resolved] (KAFKA-8523) InsertField transformation fails when encountering tombstone event

[ https://issues.apache.org/jira/browse/KAFKA-8523?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8523. -- Fix Version/s: 2.3.1 2.4.0 2.2.2 2.1.2

[jira] [Resolved] (KAFKA-8804) Internal Connect REST endpoints are insecure

[ https://issues.apache.org/jira/browse/KAFKA-8804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8804. -- Fix Version/s: 2.4.0 Reviewer: Randall Hauch Resolution: Fixed [KIP-507|https

[jira] [Resolved] (KAFKA-5609) Connect log4j should log to file by default

[ https://issues.apache.org/jira/browse/KAFKA-5609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-5609. -- Fix Version/s: 2.4.0 Reviewer: Randall Hauch Resolution: Fixed This required

[jira] [Resolved] (KAFKA-7772) Dynamically adjust log level in Connect workers

[ https://issues.apache.org/jira/browse/KAFKA-7772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-7772. -- Reviewer: Randall Hauch Resolution: Fixed > Dynamically adjust log level in Conn

[jira] [Resolved] (KAFKA-8595) Support SerDe of Decimals in JSON that are not HEX encoded

[ https://issues.apache.org/jira/browse/KAFKA-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8595. -- Fix Version/s: 2.4.0 Reviewer: Randall Hauch Resolution: Fixed KIP-481

Re: [DISCUSS] Notify SourceTask of ACK'd offsets, metadata

There seems to be two discussion threads for this KIP, and I replied to the other thread that includes the KIP number. Shall I repeat it here? Also, the link to the discussion thread on https://cwiki.apache.org/confluence/display/KAFKA/KIP-416%3A+Notify+SourceTask+of+ACK%27d+offsets%2C+metadata

Re: [DISCUSS] KIP-416: Notify SourceTask of ACK'd offsets, metadata

Apologies for the late entry -- I entirely missed this KIP and discussion. :-( Thanks for creating the KIP and proposing this change. I do think it's useful for source connector tasks to get more information about the acknowledgement after the record was written. However, given the KIPs

Re: [DISCUSS] 2.2.2 Bug Fix Release

e consider the proposal accepted, what implies that we > > can move forward with the 2.2.2 release. > > > > > > -Matthias > > > > On 9/13/19 5:23 PM, Randall Hauch wrote: > >> Thanks, Matthias. I'll get things ready locally but won't cut a releas

Re: [DISCUSS] Apache Kafka 2.4.0 release

Hi, Manikumar. Thanks for acting as release manager. Can we please add the following KIPs that have all been approved with PRs either merged or in progress: - https://cwiki.apache.org/confluence/display/KAFKA/KIP-415%3A+Incremental+Cooperative+Rebalancing+in+Kafka+Connect -

[jira] [Resolved] (KAFKA-7273) Converters should have access to headers.

[ https://issues.apache.org/jira/browse/KAFKA-7273?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-7273. -- Fix Version/s: 2.4.0 Reviewer: Randall Hauch Resolution: Fixed [KIP-440|https

Re: [VOTE] KIP-507: Securing Internal Connect REST Endpoints

Thanks, Chris! +1 (binding) On Thu, Sep 19, 2019 at 7:43 PM Chris Egerton wrote: > Hi all, > > I'd like to begin voting on KIP-507: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-507%3A+Securing+Internal+Connect+REST+Endpoints > > Thanks to Ryanne, Magesh, Konstantine, Greg, and

Re: [VOTE] KIP-521: Redirect Connect log4j messages also to a file by default

+1 (binding) Great work, Konstantine. On Thu, Sep 19, 2019 at 11:50 AM Gwen Shapira wrote: > +1 (binding) > > On Thu, Sep 19, 2019 at 8:53 AM Konstantine Karantasis > wrote: > > > > I'd like to start the vote on KIP-521. > > > > The proposal seems straightforward and no major concerns came up

Re: [DISCUSS] KIP-521: Enable redirection of Connect's log4j messages to a file by default

> So I think we agree, MDC still remains only one line change away but soon > will become the default option. > Thanks for your thoughts! > > Konstantine > > On Mon, Sep 16, 2019 at 6:42 PM Randall Hauch wrote: > > > Thanks for tackling this, Konstantine. > >

Re: [VOTE] KIP-495: Dynamically Adjust Log Levels in Connect

+1 (binding). Thanks for adding this, Arjun! On Thu, Sep 12, 2019 at 11:58 AM Gwen Shapira wrote: > +1 (binding) - Thank you. Love the new REST API for logs. > > On Tue, Aug 20, 2019 at 3:05 PM Konstantine Karantasis > wrote: > > > > Thanks for the updates on the KIP Arjun! > > > > +1 by me

Re: [DISCUSS] KIP-495: Dynamically Adjust Log Levels in Connect

Looks great. Thanks again, Arjun! On Tue, Sep 17, 2019 at 1:17 AM Arjun Satish wrote: > Answers inline > > On Mon, Sep 16, 2019 at 5:06 PM Randall Hauch wrote: > > > Thanks for the updates, Arjun. If possible, it'd be great to have the KIP > > clarify a few things: >

Re: [DISCUSS] KIP-495: Dynamically Adjust Log Levels in Connect

set, and how they affect child classes, if any. > > Let me know what you think. > > Best, > > On Thu, Sep 12, 2019 at 5:02 PM Randall Hauch wrote: > > > Thanks for the KIP, Arjun. It's going to be really nice to be able to set > > the log levels dynamically, especially t

Re: [DISCUSS] KIP-481: SerDe Improvements for Connect Decimal type in JSON

deserialize any floating point number first as a BigDecimal. > > > and then get the proper value type using that schema type's converter? > > That's exactly the proposal. I think this will be clear in the code. > > Almog > > On Fri, Aug 30, 2019 at 8:00 AM Randall Hauch wrot

Re: [VOTE] KIP-481: SerDe Improvements for Connect Decimal type in JSON

Thanks for the nice improvement, Almog! +1 (binding) Randall On Thu, Aug 15, 2019 at 11:59 AM Konstantine Karantasis < konstant...@confluent.io> wrote: > Thanks Almog! > Nicely designed and concise KIP. > > +1 non-binding > > Konstantine > > On Tue, Aug 6, 2019 at 11:44 PM Almog Gavra wrote:

Re: [DISCUSS] KIP-521: Enable redirection of Connect's log4j messages to a file by default

Thanks for tackling this, Konstantine. The KIP looks great. My only question is about whether to enable the recent MDC variable in the file log format, but for backward compatibility reasons keep it as-is for the console. I suspect using the same format in the log files and the console would be

Re: [DISCUSS] KIP-507: Securing Internal Connect REST Endpoints

on a mailing > list. > > > Do we need a JMX metric that shows the protocol that each worker is > configured to use, and whether the workers are using session keys? This > would be a great way to monitor the cluster's use of this feature. > I think exposing the connect protocol in us

Re: [DISCUSS] KIP-507: Securing Internal Connect REST Endpoints

tted explaining that > the > > Connect cluster will be vulnerable because internal request signing is > > disabled, and providing information on how to enable request signing if > > desired. > > 2) A worker with connect.protocol set to "sessioned" (or, in the futur

Re: [DISCUSS] 2.2.2 Bug Fix Release

can release 2.2.2. > > I sent an email about this (subject `[DISCUSS] Streams-Broker > compatibility regression in 2.2.1 release`) couple of days ago. > > > -Matthias > > On 9/12/19 4:03 PM, Randall Hauch wrote: > > Hey everyone, > > > > I'd like to

Re: [DISCUSS] KIP-495: Dynamically Adjust Log Levels in Connect

Thanks for the KIP, Arjun. It's going to be really nice to be able to set the log levels dynamically, especially through the REST API. However, I think it's not clear what behavior the KIP is actually proposing with respect to which loggers are exposed (just those that are used, or common

[DISCUSS] 2.2.2 Bug Fix Release

Hey everyone, I'd like to volunteer for the release manager of the 2.2.2 bug fix release. Kafka 2.2.1 was released on June 3 and so far 25 issues have been fixed since then. Here is a complete list:

Re: [DISCUSS] KIP-507: Securing Internal Connect REST Endpoints

Thanks for putting this KIP together, Chris. It's thorough and well thought out, and you've done a great job responding to comments. It is indeed going to be nice to harden the REST API a bit more. I do have a few questions/concerns/comments, all of which I think can be incorporated relatively

[jira] [Resolved] (KAFKA-8676) Avoid Stopping Unnecessary Connectors and Tasks

[ https://issues.apache.org/jira/browse/KAFKA-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8676. -- Fix Version/s: (was: 2.3.0) 2.3.1 2.4.0

Re: [DISCUSS] KIP-481: SerDe Improvements for Connect Decimal type in JSON

o BigDecimal to avoid precision loss. > * "The resulting application, however, may need to handle a wider range of > numeric values." Unless I misunderstand what you're saying, I don't think > this is correct. The resulting application will still receive exactly the > same Con

Re: [DISCUSS] KIP-481: SerDe Improvements for Connect Decimal type in JSON

Thanks for all the work, Almog. For the most part, I think this KIP will be a great improvement, and IMO is almost ready to go. However, I do have a few suggestions that affect the wording more than the intent. First, the name of the `json.decimal.serialization.format` property is pretty long,

[jira] [Resolved] (KAFKA-8586) Source task producers silently fail to send records

[ https://issues.apache.org/jira/browse/KAFKA-8586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8586. -- Reviewer: Randall Hauch Resolution: Fixed > Source task producers silently fail to s

[jira] [Resolved] (KAFKA-7941) Connect KafkaBasedLog work thread terminates when getting offsets fails because broker is unavailable

[ https://issues.apache.org/jira/browse/KAFKA-7941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-7941. -- Resolution: Fixed Reviewer: Randall Hauch Fix Version/s: 2.3.1

[jira] [Resolved] (KAFKA-8774) Connect REST API exposes plaintext secrets in tasks endpoint if config value contains additional characters

[ https://issues.apache.org/jira/browse/KAFKA-8774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8774. -- Resolution: Fixed Reviewer: Randall Hauch Fix Version/s: 2.3.1

[jira] [Resolved] (KAFKA-8550) Connector validation fails with aliased converters

[ https://issues.apache.org/jira/browse/KAFKA-8550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8550. -- Resolution: Fixed Thanks, [~ChrisEgerton]! > Connector validation fails with alia

Re: [VOTE] KIP-440: Extend Connect Converter to support headers

If my math is right, we have 3 non-binding +1 votes and 2 binding +1 votes. This is a simple but really beneficial KIP for Connect. Can we get another review and vote by a committer? Thanks! Randall On Fri, May 31, 2019 at 3:37 PM sapie...@gmail.com wrote: > Hey everyone, just bumping this

[jira] [Resolved] (KAFKA-7157) Connect TimestampConverter SMT doesn't handle null values

[ https://issues.apache.org/jira/browse/KAFKA-7157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-7157. -- Resolution: Fixed Fix Version/s: 2.3.1 2.4.0 2.2.2

[jira] [Resolved] (KAFKA-6605) Flatten SMT does not properly handle fields that are null

[ https://issues.apache.org/jira/browse/KAFKA-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-6605. -- Resolution: Fixed Reviewer: Randall Hauch Fix Version/s: 2.3.1

Re: [VOTE] KIP-475: New Metric to Measure Number of Tasks on a Connector

Thanks, Cyrus. +1 (binding) Randall Hauch On Wed, Jun 5, 2019 at 10:36 AM Andrew Schofield wrote: > +1 (non-binding) > > Andrew Schofield > > On 05/06/2019, 14:04, "Ryanne Dolan" wrote: > > +1 (non-binding) > > Thanks > Ryanne > >

Re: [DISCUSS] KIP-475: New Metric to Measure Number of Tasks on a Connector

al tasks count > > (even though might be redundant, it is robust against new/missed > connector > > states, and is a useful metric in its own right), yes? > > > > Cyrus > > > > On Tue, Jun 4, 2019 at 12:24 PM Randall Hauch wrote: > > > >> Thank

Re: [DISCUSS] KIP-475: New Metric to Measure Number of Tasks on a Connector

Thanks, Cyrus -- this will be quite useful. I do have a few comments/requests. Can you please be more specific about the public details about the metric? What is the MBean name on which the metric will appear? For example, the AK documentation

[jira] [Resolved] (KAFKA-8473) Adjust Connect system tests for incremental cooperative rebalancing and enable them for both eager and incremental cooperative rebalancing

[ https://issues.apache.org/jira/browse/KAFKA-8473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8473. -- Resolution: Fixed Reviewer: Randall Hauch > Adjust Connect system tests for incremen

[jira] [Resolved] (KAFKA-8463) Fix redundant reassignment of tasks when leader worker leaves

[ https://issues.apache.org/jira/browse/KAFKA-8463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8463. -- Resolution: Fixed Reviewer: Randall Hauch Merged to `trunk` and backported to the `2.3

[jira] [Resolved] (KAFKA-8418) Connect System tests are not waiting for REST resources to be registered

[ https://issues.apache.org/jira/browse/KAFKA-8418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8418. -- Resolution: Fixed Reviewer: Randall Hauch Merged and backported all the way to `1.0

[jira] [Resolved] (KAFKA-8407) Connector client overrides broken on client configs with type 'Class' or 'List'

[ https://issues.apache.org/jira/browse/KAFKA-8407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8407. -- Resolution: Fixed Reviewer: Randall Hauch Fix Version/s: 2.3.0 Merged onto

[jira] [Resolved] (KAFKA-8415) Interface ConnectorClientConfigOverridePolicy needs to be excluded from class loading isolation

[ https://issues.apache.org/jira/browse/KAFKA-8415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8415. -- Resolution: Fixed Reviewer: Randall Hauch Merged onto the `trunk` and `2.3` branches

[jira] [Resolved] (KAFKA-8309) KIP-465: Add Consolidated Connector Endpoint to Connect REST API

[ https://issues.apache.org/jira/browse/KAFKA-8309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8309. -- Resolution: Fixed Assignee: dan norwood Reviewer: Randall Hauch Fix

[jira] [Resolved] (KAFKA-8320) Connect Error handling is using the RetriableException from common package

[ https://issues.apache.org/jira/browse/KAFKA-8320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8320. -- Resolution: Fixed Fix Version/s: 2.2.1 2.1.2 2.3.0

[jira] [Resolved] (KAFKA-5505) Connect: Do not restart connector and existing tasks on task-set change

[ https://issues.apache.org/jira/browse/KAFKA-5505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-5505. -- Resolution: Fixed Reviewer: Randall Hauch > Connect: Do not restart connec

[jira] [Resolved] (KAFKA-5061) client.id should be set for Connect producers/consumers

[ https://issues.apache.org/jira/browse/KAFKA-5061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-5061. -- Resolution: Fixed > client.id should be set for Connect producers/consum

[jira] [Created] (KAFKA-8370) Kafka Connect should check for existence of internal topics before attempting to create them

Randall Hauch created KAFKA-8370: Summary: Kafka Connect should check for existence of internal topics before attempting to create them Key: KAFKA-8370 URL: https://issues.apache.org/jira/browse/KAFKA-8370

[jira] [Created] (KAFKA-8368) Errors when attempting to use connectors that are in multiple Kafka Connect plugins

Randall Hauch created KAFKA-8368: Summary: Errors when attempting to use connectors that are in multiple Kafka Connect plugins Key: KAFKA-8368 URL: https://issues.apache.org/jira/browse/KAFKA-8368

[jira] [Resolved] (KAFKA-7847) KIP-421: Automatically resolve external configurations.

[ https://issues.apache.org/jira/browse/KAFKA-7847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-7847. -- Resolution: Fixed Reviewer: Randall Hauch > KIP-421: Automatically resolve exter

[jira] [Resolved] (KAFKA-8363) Config provider parsing is broken

[ https://issues.apache.org/jira/browse/KAFKA-8363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8363. -- Resolution: Fixed Reviewer: Randall Hauch > Config provider parsing is bro

[jira] [Resolved] (KAFKA-8352) Connect System Tests are failing with 404

[ https://issues.apache.org/jira/browse/KAFKA-8352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8352. -- Resolution: Fixed Thanks, [~mageshn]! > Connect System Tests are failing with

Re: [VOTE] KIP-464: Defaults for AdminClient#createTopic

partitions > > > > > > > - just replicas > > > > > > > > > > > > > > I see good use cases for the first two - the third (just > > replicas) > > > > > seems > > > > > > > less necessary but complicates the API a bit

Re: [VOTE] KIP-464: Defaults for AdminClient#createTopic

le, but I can also > understand > > Ismael's argument for keeping the KIP minimal. > > > > best, > > Colin > > > > > > On Thu, May 9, 2019, at 08:09, Randall Hauch wrote: > > > I'm fine with simplifying the KIP by removing the Builder (which seems &g

[jira] [Resolved] (KAFKA-8231) Expansion of ConnectClusterState interface

[ https://issues.apache.org/jira/browse/KAFKA-8231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8231. -- Resolution: Fixed > Expansion of ConnectClusterState interf

Re: [VOTE] KIP-458: Connector Client Config Override Policy

oolean useOverrides()` in the interface which was introduced for > > the purpose of backward compatibility. > > > > On Thu, May 9, 2019 at 3:27 PM Randall Hauch wrote: > > > >> I have also seen users include in connector configs the `producer.*` and > >> `cons

Re: [VOTE] KIP-458: Connector Client Config Override Policy

;> necessary? > >> > >> Can you add some details about what happens if a > >> PolicyValidationException is thrown? I'm assuming that we fail to > create > >> the new Connector, I'm not sure if that's completely spelled out > (unless

Re: [VOT] KIP-449: Add connector contexts to Connect worker logs (vote thread)

+1 (binding) > Makes a lot of sense to me. > > -Bill > > On Thu, May 9, 2019 at 2:05 PM Gwen Shapira wrote: > > > +1 (binding) > > Hell yeah! > > > > On Mon, Apr 29, 2019 at 3:34 PM Randall Hauch wrote: > > > > > I would like

Re: [VOTE] KIP-464: Defaults for AdminClient#createTopic

I'm fine with simplifying the KIP by removing the Builder (which seems ancillary), or keeping the KIP as-is. I'll wait to vote until Almog says which way he'd like to proceed. On Thu, May 9, 2019 at 9:45 AM Ismael Juma wrote: > Hi Almog, > > Adding a Builder seems unrelated to this change. Do

Re: [VOTE] KIP-437: Custom replacement for MaskField SMT

Nice work, Valeria. +1 (binding) Randall On Mon, May 6, 2019 at 4:30 PM Konstantine Karantasis < konstant...@confluent.io> wrote: > I think is is a useful improvement proposal. Thanks Valeria! > > I'm +1 (non-binding) on this KIP > > Konstantine > > On Mon, Apr 15, 2019 at 2:04 AM Valeria

Re: [VOTE] KIP-458: Connector Client Config Override Policy

Nice work, Magesh. +1 (binding) Randall On Wed, May 8, 2019 at 7:22 PM Magesh Nandakumar wrote: > Thanks a lot Chris. So far, the KIP has one non-binding vote and I'm still > looking forward to the KIP to be voted by Friday's deadline. > > On Tue, May 7, 2019 at 10:00 AM Chris Egerton wrote:

Re: [VOTE] KIP-440: Extend Connect Converter to support headers

Thanks, Yaroslav! +1 (binding) Randall On Tue, May 7, 2019 at 1:25 AM Yaroslav Tkachenko wrote: > Hi everyone, > > I'd like to start a vote for KIP-440: Extend Connect Converter to support > headers ( > >

[jira] [Resolved] (KAFKA-8304) Connect susceptible to deadlock while registering REST extensions

[ https://issues.apache.org/jira/browse/KAFKA-8304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8304. -- Resolution: Fixed Merged onto `trunk`, and backported to `2.2`, `2.1`, and `2.0`. > Conn

Re: [VOT] KIP-449: Add connector contexts to Connect worker logs (vote thread)

andall. > > > > > > +1 (non-binding) > > > > > > Thanks, > > > Magesh > > > > > > On Tue, Apr 30, 2019 at 7:19 PM Jeremy Custenborder < > > > jcustenbor...@gmail.com> > > > wrote: > > > > > >

Re: [DISCUSS] KIP-458: Connector Client Config Override Policy

the default `null` I would prefer to fall back to using `Ignore` > > > which > > > > is a misnomer to the interface spec but still gets the job done via > > > > instanceOf checks. The other options I could think of are as below:- > > > > > > > >- have

Re: [DISCUSS] KIP-458: Connector Client Config Override Policy

eturns true in the > interface. The `Ignore` policy would then override it to return false. > `Ignore` will also be the default policy. > > I personally prefer option #2, since it involves one less configuration but > then I'm also open to the other option. > > Thanks, > Magesh &

Re: [DISCUSS] KIP-458: Connector Client Config Override Policy

.connector.config.overrides > >with a default value of false and the default policy can be None > > > > Let me know what you think. > > > > Thanks > > Magesh > > > > On Tue, Apr 30, 2019 at 6:52 PM Randall Hauch wrote: > > > >> Thanks,

Re: [DISCUSS] KIP-440: Extend Connect Converter to support headers

es. > > Thanks for the nicely written KIP! > Konstantine > > > > On Mon, Apr 29, 2019 at 3:39 PM Randall Hauch wrote: > > > Thanks for the update. Yes, IMO this KIP is ready for a vote. > > > > On Fri, Apr 26, 2019 at 12:15 AM sapie...@gmail.com > >

Re: [VOTE] KIP-465: Add Consolidated Connector Endpoint to Connect REST API

Thanks, Dan. As mentioned on the discussion, this is really a nice little addition that was alway missing from the API. +1 (binding) Randall On Mon, May 6, 2019 at 9:23 AM dan wrote: > I would like to start voting for > >

Re: [VOTE] KIP-454: Expansion of the ConnectClusterState interface

Nice job, Chris! +1 (binding) On Thu, May 2, 2019 at 8:16 PM Magesh Nandakumar wrote: > Thanks a lot for the work on this KIP Chris. > > +1(non-binding) > > On Thu, May 2, 2019, 4:56 PM Chris Egerton wrote: > > > Hi all, > > > > I'd like to start a vote for KIP-454: > > > > >

Re: [DISCUSS] KIP-464 Default Replication Factor for AdminClient#createTopic

aps instead of deprecating the Connect builder, > then, we can indeed just subclass it and move some of the less common build > methods (e.g. uncleanLeaderElection) there. > > On Fri, May 3, 2019 at 11:20 AM Randall Hauch wrote: > > > Thanks for updating, Almog. I have a

Re: [DISCUSS] KIP-464 Default Replication Factor for AdminClient#createTopic

osity - updating the KIP to reflect this > now. > > On Thu, May 2, 2019 at 9:28 AM Randall Hauch wrote: > > > I wrote the `NewTopicBuilder` in Connect, and it was simply a convenience > > to more easily set some of the frequently-used properties and the # of > > partiti

Re: [DISCUSS] KIP-464 Default Replication Factor for AdminClient#createTopic

I wrote the `NewTopicBuilder` in Connect, and it was simply a convenience to more easily set some of the frequently-used properties and the # of partitions and replicas for the new topic in the same way. An example is: NewTopic topicDescription = TopicAdmin.defineTopic(topic).

Re: [DISCUSS] KIP-465: Add Consolidated Connector Endpoint to Connect REST API

Thanks for the KIP, Dan! This is a simple change that will make it easier to get the status of all of the connectors running in a Connect cluster, and I like the approach of adding a query parameter to the existing `connectors/` resource to be backward compatible and to avoid introducing another

Re: [DISCUSS] KIP-458: Connector Client Config Override Policy

l. > > Would be interested in your thoughts on this, especially if there's an > alternative that hasn't been proposed yet. > > Cheers, > > Chris > > On Tue, Apr 30, 2019, 18:01 Randall Hauch wrote: > > > On Tue, Apr 30, 2019 at 4:20 PM Magesh Nandakumar > > wrote: &g

Re: [DISCUSS] KIP-458: Connector Client Config Override Policy

's not clear in the KIP. > Why not have a default policy (rather than null) that implements the backward-compatible behavior? It seems strange to have null be the default and for non-policy to allow anything. > > Thanks, > Magesh > > On Mon, Apr 29, 2019 at 4:07 PM Randall Hauch w

Re: [VOTE] KIP-411: Make default Kafka Connect worker task client IDs distinct

Nice simple improvement. Thanks, Paul! +1 (binding) Randall On Mon, Apr 29, 2019 at 5:06 PM Magesh Nandakumar wrote: > Looks good to me and a very useful feature. > > +1 ( non-binding) > > On Mon, Apr 29, 2019, 4:05 PM Arjun Satish wrote: > > > Thanks, Paul! This is very useful. > > > > +1

Re: [DISCUSS] KIP-458: Connector Client Config Override Policy

Per the proposal, a connector configuration can define one or more properties that begin with any of the three prefixes: "producer.override.", "consumer.override.", and "admin.override.". The proposal states: Since the users can specify any of these policies, the connectors itself should not rely

Re: [DISCUSS] KIP-440: Extend Connect Converter to support headers

. > > Thanks! > > On 2019/04/22 21:07:31, Randall Hauch wrote: > > I think it would be helpful to clarify this in the KIP, just so that > > readers are aware that the headers will be the raw header bytes that are > > the same as what is in the Kafka record. > > &g

[VOT] KIP-449: Add connector contexts to Connect worker logs (vote thread)

I would like to start the vote for KIP-258: https://cwiki.apache.org/confluence/display/KAFKA/KIP-449%3A+Add+connector+contexts+to+Connect+worker+logs The KIP uses the Mapped Diagnostic Contexts (MDC) feature of SLF4J API to add more context to log messages from within Connect workers and

Re: [DISCUSS] KIP-449: Add connector contexts to Connect worker logs

Thanks, Chris and Jeremy. I've fixed the errors that Chris mentioned. I agree with Jeremy that this KIP is limited to the framework dealing with these contexts as part of its logging mechanism, and they're not really for connectors to use. Connector implementations that don't have additional

[jira] [Resolved] (KAFKA-8277) Fix NPE in ConnectHeaders

[ https://issues.apache.org/jira/browse/KAFKA-8277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-8277. -- Resolution: Fixed > Fix NPE in ConnectHead

[jira] [Created] (KAFKA-8277) Fix NPE in ConnectHeaders

Randall Hauch created KAFKA-8277: Summary: Fix NPE in ConnectHeaders Key: KAFKA-8277 URL: https://issues.apache.org/jira/browse/KAFKA-8277 Project: Kafka Issue Type: Bug Components

Re: [DISCUSS] KIP-440: Extend Connect Converter to support headers

internal Connect format to Kafka messages (cause there is no other way > to get the headers in this case). > > I can add this to the KIP if it's helpful. > > Randall, what is the alternative approach you're referring to? > > On 2019/04/22 18:09:24, Randall Hauch wrote

Re: [DISCUSS] KIP-440: Extend Connect Converter to support headers

l with the existing > implementation of KIP-145 that introduced headers in Connect. > > Thanks, > Konstantine > > On Mon, Apr 22, 2019 at 9:07 AM Randall Hauch wrote: > > > Thanks for updating the KIP. It looks good to me, and since there haven't > > been any ot

Re: [DISCUSS] KIP-440: Extend Connect Converter to support headers

Thanks for updating the KIP. It looks good to me, and since there haven't been any other issue mentioned in this month-long thread, it's probably fine to start a vote. Best regards, Randall On Tue, Apr 2, 2019 at 3:12 PM Randall Hauch wrote: > Thanks for the submission, Yaros

Re: [VOTE] KIP-421: Automatically resolve external configurations.

+1 Thanks, Tejal. Randall On Thu, Apr 18, 2019 at 3:02 PM TEJAL ADSUL wrote: > Hi All, > > As we have reached a consensus on the design, I would like to start a vote > for KIP-421. Below are the links for this proposal: > > KIP Link: >

Re: [DISCUSSION] KIP-421: Automatically resolve external configurations.

Thanks for making the changes, Tejal. The KIP looks great. Randall On Wed, Apr 17, 2019 at 10:32 AM TEJAL ADSUL wrote: > > Thanks for the feedback Randall. I have incorporated the below changes in > the KIP. > > Thanks, > Tejal > > On 2019/04/17 15:42:31, Randall H

Re: [DISCUSSION] KIP-421: Automatically resolve external configurations.

Overall this looks good. A few specific requests to hopefully improve the clarity of the proposal: 1) The motivation section should more clearly state that this feature will allow it to be reused in multiple components, Connect will use this feature to resolve variables in the worker

<    1   2   3   4   5   6   7   8   >