Re: [DISCUSS] KIP-660: Pluggable ReplicaAssignor

2020-09-11 Thread Robert Barrett
Thanks Mickael, I think adding the new Exception resolves my concerns. On Thu, Sep 3, 2020 at 9:47 AM Mickael Maison wrote: > Thanks Robert and Ryanne for the feedback. > > ReplicaAssignor implementations can throw an exception to indicate an > assignment can't be computed. This is already what

Re: [VOTE] KIP-664: Provide tooling to detect and abort hanging transactions

2020-09-11 Thread Robert Barrett
+1 (non-binding) Thanks Jason! On Tue, Sep 8, 2020 at 5:28 PM Guozhang Wang wrote: > +1. Thanks! > > Guozhang > > On Tue, Sep 8, 2020 at 3:04 PM Ron Dagostino wrote: > > > +1 (non-binding) -- Thanks, Jason! > > > > Ron > > > > On Tue, Sep 8, 2020 at 2:04 PM Jason Gustafson > wrote: > > > > >

Re: [DISCUSS] KIP-664: Provide tooling to detect and abort hanging transactions

2020-08-28 Thread Robert Barrett
Hi Jason, Thanks for this KIP, I think this will be a huge operational improvement and overall it looks great to me. I'm not sure how much value the MaxActiveTransactionDuration metric adds, given that we have the --find-hanging option in the tool. As you mention, instances of these transactions

Re: [DISCUSS] KIP-660: Pluggable ReplicaAssignor

2020-08-28 Thread Robert Barrett
Hi Mickael, Thanks for the KIP! One question I have is around failure cases. Are ReplicaAssignor implementations expected to always compute an assignment, or is it possible for them to have unsatisfiable conditions? One example I can think of is a requirement that at least one partition be placed

Re: [VOTE] KIP-352: Distinguish URPs caused by reassignment

2019-08-21 Thread Robert Barrett
+1 (non-binding) This will be great to have, thanks Jason! On Wed, Aug 21, 2019 at 4:29 AM Manikumar wrote: > +1 (binding). > > Thanks for the KIP. LGTM. > > > On Wed, Aug 21, 2019 at 3:12 PM Satish Duggana > wrote: > > > Hi Jason, > > +1 (non binding) Thanks for the KIP! > > > > Do we need to

Re: [VOTE] KIP-503: deleted topics metric

2019-08-14 Thread Robert Barrett
+1 (non-binding) This will be good to have, thanks David! Bob On Wed, Aug 14, 2019 at 6:08 AM Mickael Maison wrote: > +1 non binding > Thank you! > > On Tue, Aug 13, 2019 at 9:07 PM Stanislav Kozlovski > wrote: > > > > +1 (non-binding) > > > > Thanks for the simple but very useful KIP! > > Be

Re: [VOTE] KIP-455: Create an Administrative API for Replica Reassignment

2019-07-19 Thread Robert Barrett
+1 (non-binding). Thanks for the KIP! On Thu, Jul 18, 2019 at 5:59 PM George Li wrote: > +1 (non-binding) > > > > Thanks for addressing the comments. > George > > On Thursday, July 18, 2019, 05:03:58 PM PDT, Gwen Shapira < > g...@confluent.io> wrote: > > Renewing my +1, thank you Colin and

Re: [VOTE] KIP-455: Create an Administrative API for Replica Reassignment

2019-05-09 Thread Robert Barrett
+1 (non-binding) Thanks for the KIP, Colin! On Thu, May 9, 2019 at 8:27 AM Colin McCabe wrote: > Hi Viktor, > > There is a jira -- KAFKA-8345. The PR is not quite ready yet, but > hopefully soon :) > > best, > Colin > > On Thu, May 9, 2019, at 01:13, Viktor Somogyi-Vass wrote: > > +1 (non-bind

Re: [DISCUSS] KIP-455: Create an Administrative API for Replica Reassignment

2019-04-17 Thread Robert Barrett
Thanks for the KIP, Colin. I have a couple questions: 1. What's the reasoning for requiring cancellation of a reassignment before submitting a new one? It seems like overriding an existing reassignment could be done with a single update to /brokers/topics/[topic]/partitions/[partitionId]/state and

Re: [ANNOUNCE] New committer: Colin McCabe

2018-09-25 Thread Robert Barrett
Congratulations Colin! On Tue, Sep 25, 2018 at 1:51 PM Matthias J. Sax wrote: > Congrats Colin! The was over due for some time :) > > -Matthias > > On 9/25/18 1:51 AM, Edoardo Comar wrote: > > Congratulations Colin ! > > -- > > > > Edoardo Comar >