Re: [VOTE] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-03-28 Thread Ted Yu
+1 On Wed, Mar 28, 2018 at 12:05 PM, Mickael Maison wrote: > +1 (non binding) > Thanks for the KIP > > On Wed, Mar 28, 2018 at 6:25 PM, Gwen Shapira wrote: > > +1 (binding) > > > > On Wed, Mar 28, 2018 at 9:55 AM, Allen Wang >

Re: [ANNOUNCE] New Committer: Dong Lin

2018-03-28 Thread Ted Yu
Congratulations, Dong. On Wed, Mar 28, 2018 at 10:58 AM, Becket Qin wrote: > Hello everyone, > > The PMC of Apache Kafka is pleased to announce that Dong Lin has accepted > our invitation to be a new Kafka committer. > > Dong started working on Kafka about four years ago,

Re: [VOTE] KIP-268: Simplify Kafka Streams Rebalance Metadata Upgrade

2018-03-26 Thread Ted Yu
Congratulations. BTW I believe 孙振亚 and Zhenya is the same person - Zhenya is the PinYin of 振亚 Cheers On Mon, Mar 26, 2018 at 12:51 PM, Matthias J. Sax wrote: > +1 (binding) > > > I am also cloeing this vote. The KIP is accepted with > > +7 non-binding (Richard, Ted,

[jira] [Created] (KAFKA-6716) discardChannel should be released in MockSelector#completeSend

2018-03-26 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-6716: - Summary: discardChannel should be released in MockSelector#completeSend Key: KAFKA-6716 URL: https://issues.apache.org/jira/browse/KAFKA-6716 Project: Kafka Issue Type

Re: [VOTE] 1.1.0 RC4

2018-03-24 Thread Ted Yu
> after running the test a 100 times. Was it a one-off transient failure or > does it fail consistently for you? > > > On Sat, Mar 24, 2018 at 2:51 AM, Ted Yu <yuzhih...@gmail.com> wrote: > > > When I ran test suite, I got one failure: > > > >

Re: [VOTE] 1.1.0 RC4

2018-03-23 Thread Ted Yu
When I ran test suite, I got one failure: kafka.api.PlaintextConsumerTest > testAsyncCommit FAILED java.lang.AssertionError: expected:<5> but was:<1> at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.failNotEquals(Assert.java:834) at

Re: Gradle strategy for exposing and using public test-utils modules

2018-03-22 Thread Ted Yu
+1 Original message From: "Matthias J. Sax" Date: 3/22/18 9:07 PM (GMT-08:00) To: dev@kafka.apache.org Subject: Re: Gradle strategy for exposing and using public test-utils modules +1 from my side. -Matthias On 3/22/18 5:12 PM, John Roesler wrote: >

Re: [VOTE] KIP-257 - Configurable Quota Management

2018-03-22 Thread Ted Yu
+1 Original message From: Rajini Sivaram Date: 3/22/18 2:56 PM (GMT-08:00) To: dev Subject: [VOTE] KIP-257 - Configurable Quota Management Hi all, I would like to start vote on KIP-257 to enable customisation of client quota

Re: [DISCUSS] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-03-21 Thread Ted Yu
nt solution, clean >> implementation and it addresses a real need, especially during upgrades. >> >> On Tue, Mar 20, 2018 at 2:49 PM, Ted Yu <yuzhih...@gmail.com> wrote: >> >>> Thanks for the response. >>> >>> Assuming number of client ver

[jira] [Created] (KAFKA-6698) ConsumerBounceTest#testClose sometimes fails

2018-03-21 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-6698: - Summary: ConsumerBounceTest#testClose sometimes fails Key: KAFKA-6698 URL: https://issues.apache.org/jira/browse/KAFKA-6698 Project: Kafka Issue Type: Test

Re: [VOTE] KIP-268: Simplify Kafka Streams Rebalance Metadata Upgrade

2018-03-20 Thread Ted Yu
+1 On Tue, Mar 20, 2018 at 5:56 PM, Richard Yu wrote: > Hi Matthias, > Thanks for setting up the upgrade path. > > +1 (non-binding) > > On Tue, Mar 20, 2018 at 3:42 PM, Matthias J. Sax > wrote: > > > Hi, > > > > I would like to start the vote

Re: [DISCUSS] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-03-20 Thread Ted Yu
map for "produce" requests mapping from version to meter. Of > course, hash map always have additional memory overhead. > > Thanks, > Allen > > > On Mon, Mar 19, 2018 at 3:49 PM, Ted Yu <yuzhih...@gmail.com> wrote: > > > bq. *additional hash lookup is n

Re: [DISCUSS] KIP-272: Add API version tag to broker's RequestsPerSec metric

2018-03-19 Thread Ted Yu
bq. *additional hash lookup is needed when updating the metric to locate the metric * *Do you have estimate how much memory is needed for maintaining the hash map ?* *Thanks* On Mon, Mar 19, 2018 at 3:19 PM, Allen Wang wrote: > Hi all, > > I have created KIP-272: Add API

Re: [DISCUSS] KIP-268: Simplify Kafka Streams Rebalance Metadata Upgrade

2018-03-19 Thread Ted Yu
bq. some snippet like ProduceRequest / ProduceRequest Did you mean ProduceRequest / Response ? Cheers On Mon, Mar 19, 2018 at 9:51 AM, Guozhang Wang wrote: > Hi Matthias, > > About 2: yeah I guess this is a subjective preference. My main concern > about keeping the config

Re: [DISCUSS] KIP-270 A Scala wrapper library for Kafka Streams

2018-03-19 Thread Ted Yu
scala only depends on the Scala standard library and > > Kafka > > > Streams 1.0.0. > > > > > > Should this be 1.2 (maybe it's even better to not put any version at > > all) > > > > > > > > > 2) In 1.1 release, we add a new modu

[jira] [Created] (KAFKA-6678) Upgrade dependencies with later release versions

2018-03-18 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-6678: - Summary: Upgrade dependencies with later release versions Key: KAFKA-6678 URL: https://issues.apache.org/jira/browse/KAFKA-6678 Project: Kafka Issue Type: Improvement

Re: [DISCUSS] KIP-270 A Scala wrapper library for Kafka Streams

2018-03-16 Thread Ted Yu
Import renames seem to be fine. The class names with trailing 'S' look clean. Cheers On Fri, Mar 16, 2018 at 11:04 AM, Ismael Juma wrote: > If this is rare (as it sounds), relying on import renames seems fine to me. > Let's see what others think. > > Ismael > > On Fri, Mar

Re: Subject: [VOTE] 1.1.0 RC3

2018-03-15 Thread Ted Yu
+1 Ran test suite which passed. Checked signatures. On Thu, Mar 15, 2018 at 7:50 AM, Damian Guy wrote: > Hello Kafka users, developers and client-developers, > > This is the fourth candidate for release of Apache Kafka 1.1.0. > >

Re: [VOTE] 1.1.0 RC2

2018-03-14 Thread Ted Yu
+1 Ran test suite - passed (apart from testMetricsLeak which is flaky). On Wed, Mar 14, 2018 at 3:30 AM, Damian Guy wrote: > Thanks for pointing out Satish. Links updated: > > > > Hello Kafka users, developers and

Re: [DISCUSS] KIP-258: Allow to Store Record Timestamps in RocksDB

2018-03-09 Thread Ted Yu
similar auto-detection of broker > capabilities and automatically do a switchover from old/new versions. > > > > -James > > > > > >> On Mar 9, 2018, at 10:38 AM, Bill Bejeck <bbej...@gmail.com> wrote: > >> > >> Matthias, > >> > >>

Re: [VOTE] KIP-267: Add Processor Unit Test Support to Kafka Streams Test Utils

2018-03-09 Thread Ted Yu
+1 Original message From: Bill Bejeck Date: 3/9/18 12:29 PM (GMT-08:00) To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-267: Add Processor Unit Test Support to Kafka Streams Test Utils Thanks for the KIP. +1 -Bill On Fri, Mar 9, 2018 at 3:16 PM, John

Re: [DISCUSS] KIP-258: Allow to Store Record Timestamps in RocksDB

2018-03-08 Thread Ted Yu
ou get the same > > benefits without altering the high-level directory structure. > > > > It may not matter, but I could imagine people running scripts to monitor > > rocksdb disk usage for each task, or other such use cases. > > > > Thanks, > > -John

Re: [DISCUSS] KIP-258: Allow to Store Record Timestamps in RocksDB

2018-03-08 Thread Ted Yu
Matthias: Nicely written KIP. "in_place" : can this be "in-place" ? Underscore may sometimes be miss typed (as '-'). I think using '-' is more friendly to user. public interface ReadOnlyKeyValueTimestampStore { Is ReadOnlyKeyValueStoreWithTimestamp better name for the class ? Thanks On

Re: [VOTE] KIP-186: Increase offsets retention default to 7 days

2018-03-07 Thread Ted Yu
+1 Original message From: Guozhang Wang Date: 3/7/18 9:17 PM (GMT-08:00) To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-186: Increase offsets retention default to 7 days +1 (binding). On Wed, Mar 7, 2018 at 5:04 PM, James Cheng

Re: [DISCUSSION] KIP-266: Add TimeoutException to KafkaConsumer#position()

2018-03-06 Thread Ted Yu
bq. The most flexible option is to add overloads to the consumer This option is flexible. Looking at the tail of SPARK-18057, Spark dev voiced the same choice. +1 for adding overload with timeout parameter. Cheers On Mon, Mar 5, 2018 at 2:42 PM, Jason Gustafson wrote: >

Re: [VOTE] KIP-265: Make Windowed Serde to public APIs

2018-03-05 Thread Ted Yu
+1 On Mon, Mar 5, 2018 at 1:46 PM, Guozhang Wang wrote: > Hello all, > > I'd like to start voting on KIP-265, on making windowed serde to public > APIs of Kafka Streams. It involves a couple of new configs, plus a few new > public classes for windowed serializer and

Re: Hello

2018-02-28 Thread Ted Yu
Impressive work. Under 3.4.1, New Consumer Configs, there are several entries which are not translated. Is there plan to translate them ? Cheers On Tue, Feb 27, 2018 at 1:48 AM, 程威 wrote: > Hello,we are a Open source Chinese document organization ,now we are > spending time

Re: [DISCUSS] KIP-264: Add a consumer metric to record raw fetch size

2018-02-27 Thread Ted Yu
There is raw-bytes-consumed in the sample code. Can you add description for that ? Looks good overall. On Tue, Feb 27, 2018 at 12:42 PM, Vahid S Hashemian < vahidhashem...@us.ibm.com> wrote: > Hi all, > > I started a short, and hopefully trivial, KIP to add a KafkaConsumer > metric: >

Re: [VOTE] KIP-261: Add Single Value Fetch in Window Stores

2018-02-24 Thread Ted Yu
+1 On Sat, Feb 24, 2018 at 11:10 AM, Guozhang Wang wrote: > Hi all, > > I want to start voting on KIP-261 to add a new API for window stores in > order to optimize our current windowed aggregation implementations inside > Streams DSL: > >

Re: [VOTE] 1.1.0 RC0

2018-02-24 Thread Ted Yu
+1 Ran test suite where (known flaky) testMetricsLeak failed - the other tests passed. On Sat, Feb 24, 2018 at 8:16 AM, Damian Guy wrote: > Hello Kafka users, developers and client-developers, > > This is the first candidate for release of Apache Kafka 1.1.0. > > This is

Re: [DISCUSS] KIP-261: Add Single Value Fetch in Window Stores

2018-02-22 Thread Ted Yu
+1 There were some typos: CachingWindowedStore -> CachingWindowStore RocksDBWindowedStore -> RocksDBWindowStore KStreamWindowedAggregate -> KStreamWindowAggregate KStreamWindowedReduce -> KStreamWindowReduce Cheers On Thu, Feb 22, 2018 at 1:34 PM, Guozhang Wang wrote: > Hi

Re: [VOTE] 1.0.1 RC2

2018-02-22 Thread Ted Yu
+1 MetricsTest#testMetricsLeak failed but it is flaky test On Wed, Feb 21, 2018 at 4:06 PM, Ewen Cheslack-Postava wrote: > Hello Kafka users, developers and client-developers, > > This is the third candidate for release of Apache Kafka 1.0.1. > > This is a bugfix release for

[jira] [Resolved] (KAFKA-6228) Intermittent test failure in FetchRequestTest.testDownConversionWithConnectionFailure

2018-02-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved KAFKA-6228. --- Resolution: Cannot Reproduce > Intermittent test fail

Re: [DISCUSS] KIP-255: OAuth Authentication via SASL/OAUTHBEARER

2018-02-14 Thread Ted Yu
Nicely written KIP. Can you add link to this thread and fill in JIRA number ? For ExpiringCredential, why does expireTimeMillis() return long while other methods return Long ? Can you add some comment for WindowJitter in RefreshConfig ? Thanks On Wed, Feb 14, 2018 at 3:38 PM, Ron Dagostino

Re: [VOTE] KIP-251: Allow timestamp manipulation in Processor API

2018-02-08 Thread Ted Yu
+1 Original message From: "Matthias J. Sax" Date: 2/8/18 6:05 PM (GMT-08:00) To: dev@kafka.apache.org Subject: [VOTE] KIP-251: Allow timestamp manipulation in Processor API Hi, I want to start the vote for KIP-251:

Re: Query on min.insync.replicas property

2018-02-06 Thread Ted Yu
That should include the leader node. On Tue, Feb 6, 2018 at 8:46 PM, rishi jain wrote: > Hi, > > I have an doubt on min.insync.replicas property in kafka server.properties > files. > If we set any value for "min.insync.replicas" property, is that including > leader node

[jira] [Reopened] (KAFKA-5889) MetricsTest is flaky

2018-02-06 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu reopened KAFKA-5889: --- As of 332e698ac9c74ce29317021b03a54512c92ac8b3 , I got: {code} kafka.metrics.MetricsTest > testMetricsLeak FAI

Re: [VOTE] 1.0.1 RC0

2018-02-06 Thread Ted Yu
the release process, but I've never seen any > > indication of a reliable amount of time for it to show up. Didn't want to > > hold up the process waiting for it so I sent the email, but if it doesn't > > show up for too long or we need a follow up RC, I'll just extend/restar

Re: [VOTE] 1.0.1 RC0

2018-02-05 Thread Ted Yu
Ewen: Do you know how long it takes for maven repo to be populated ? Looking at: https://repository.apache.org/content/groups/staging/org/apache/kafka/kafka-clients/ I don't see 1.0.1 version. Cheers On Mon, Feb 5, 2018 at 7:48 PM, Ewen Cheslack-Postava wrote: > Hello

description of unclean leader election

2018-02-05 Thread Ted Yu
Hi, I am reading unclean leader election in Kafka Definitive Guide. On page 120: ... with offsets 100-200 to replica 2 (then the leader). Now replica 3 is unavailable ... It seems 'replica 3' was meant to be 'replica 2'. Cheers

[jira] [Created] (KAFKA-6531) SocketServerTest#closingChannelException fails sometimes

2018-02-04 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-6531: - Summary: SocketServerTest#closingChannelException fails sometimes Key: KAFKA-6531 URL: https://issues.apache.org/jira/browse/KAFKA-6531 Project: Kafka Issue Type: Test

Re: [DISCUSS] KIP-251: Allow timestamp manipulation in Processor API

2018-02-01 Thread Ted Yu
; > context.forward(key, value, To.child("processorX").withTimestamp(5)); > > > context.forward(key, value, To.child(1).withTimestamp(10)); > > > > Without specifying the downstream child processor: > > > > > context.forward(key, value, To.a

Re: [DISCUSS] KIP-251: Allow timestamp manipulation in Processor API

2018-02-01 Thread Ted Yu
I like Bill's idea (pending a better name for the Forwarded). Cheers On Thu, Feb 1, 2018 at 7:47 AM, Bill Bejeck wrote: > Hi Matthias, > > Thanks for the KIP! > > Could we consider taking an approach similar to what was done in KIP-182 > with regards to overloading? > >

[jira] [Resolved] (KAFKA-6232) SaslSslAdminClientIntegrationTest sometimes fails

2018-01-28 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved KAFKA-6232. --- Resolution: Cannot Reproduce > SaslSslAdminClientIntegrationTest sometimes fa

Re: [VOTE] KIP-206: Add support for UUID serialization and deserialization

2018-01-26 Thread Ted Yu
+1 On Fri, Jan 26, 2018 at 7:00 AM, Brandon Kirchner < brandon.kirch...@gmail.com> wrote: > Hi all, > > I would like to (re)start the voting process for KIP-206: > > *https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 206%3A+Add+support+for+UUID+serialization+and+deserialization >

Re: [VOTE] KIP-86: Configurable SASL callback handlers

2018-01-24 Thread Ted Yu
Login class configurable. > > > > > > The PR for the KIP has been rebased and updated ( > > > https://github.com/apache/kafka/pull/2022) > > > > > > Thank you, > > > > > > Rajini > > > > > > > > > > >

Re: [VOTE] KIP-145: Expose Record Headers in Kafka Connect

2018-01-22 Thread Ted Yu
+1 On Mon, Jan 22, 2018 at 2:48 PM, Gwen Shapira wrote: > +1 (binding) > > This is going to be HUGE! Thank you Randall. > > On Mon, Jan 22, 2018 at 1:18 PM Konstantine Karantasis < > konstant...@confluent.io> wrote: > > > Great addition! > > > > +1 (non-binding) > > > >

[jira] [Resolved] (KAFKA-5889) MetricsTest is flaky

2018-01-20 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved KAFKA-5889. --- Resolution: Cannot Reproduce > MetricsTest is flaky > > >

Re: [VOTE] KIP-222 - Add "describe consumer group" to KafkaAdminClient

2018-01-18 Thread Ted Yu
s > > > good > > > > overall. > > > > > > > > > > > > Guozhang > > > > > > > > On Tue, Nov 14, 2017 at 10:02 AM, Jorge Esteban Quilcate Otoya < > > > > quilcate.jo...@gmail.com> wrote:

Re: [ANNOUNCE] New Kafka PMC Member: Rajini Sivaram

2018-01-17 Thread Ted Yu
Congratulations Rajini ! On Wed, Jan 17, 2018 at 10:54 AM, Vahid S Hashemian < vahidhashem...@us.ibm.com> wrote: > Great news! Congratulations Rajini! > > --Vahid > > > > From: Gwen Shapira > To: "dev@kafka.apache.org" , Users >

Re: [DISCUSS] KIP-249: Add Delegation Token Operations to Kafka Admin Client

2018-01-16 Thread Ted Yu
Looks like DelegationTokenOwnerMismatchException would be thrown if token expiration is issued by non-owner. On Tue, Jan 16, 2018 at 11:16 AM, Ted Yu <yuzhih...@gmail.com> wrote: > For createDelegationToken, what's the default value for maxLifeTimeMs ? > > For expireDelega

Re: [DISCUSS] KIP-249: Add Delegation Token Operations to Kafka Admin Client

2018-01-16 Thread Ted Yu
For createDelegationToken, what's the default value for maxLifeTimeMs ? For expireDelegationToken, what exception would be thrown if the operation is not permitted ? Thanks On Tue, Jan 16, 2018 at 10:03 AM, Manikumar wrote: > Hi all, > > I have created a KIP to add

[jira] [Resolved] (KAFKA-6384) TransactionsTest#testFencingOnSendOffsets sometimes fails with ProducerFencedException

2018-01-16 Thread Ted Yu (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-6384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ted Yu resolved KAFKA-6384. --- Resolution: Cannot Reproduce > TransactionsTest#testFencingOnSendOffsets sometimes fa

Re: [VOTE] KIP-229: DeleteGroups API

2018-01-15 Thread Ted Yu
+1 On Mon, Jan 15, 2018 at 12:22 PM, Jeff Widman wrote: > +1 (non-binding) > > On Jan 15, 2018 10:23 AM, "Vahid S Hashemian" > wrote: > > > Happy Monday, > > > > I believe the concerns on this KIP have been addressed in the current > > version of

Re: [ANNOUNCE] New committer: Matthias J. Sax

2018-01-12 Thread Ted Yu
Congratulations, Matthias. On Fri, Jan 12, 2018 at 2:59 PM, Guozhang Wang wrote: > Hello everyone, > > The PMC of Apache Kafka is pleased to announce Matthias J. Sax as our > newest Kafka committer. > > Matthias has made tremendous contributions to Kafka Streams API since

Re: Another bug

2018-01-12 Thread Ted Yu
Can you provide more information ? release of Kafka relevant configs sequence of operation that led to the exception Thanks On Fri, Jan 12, 2018 at 11:22 AM, Peter Holm wrote: > This occurs, when the heartbeat thread is stopped forcibly > >

Re: [VOTE] KIP-174 Deprecate and remove internal converter configs in WorkerConfig

2018-01-08 Thread Ted Yu
+1 On Mon, Jan 8, 2018 at 4:27 AM, UMESH CHAUDHARY wrote: > Hello All, > Since there are no outstanding comments on this, so I'd like to start a > vote. > > Please find the KIP here >

[jira] [Created] (KAFKA-6424) QueryableStateIntegrationTest#queryOnRebalance should be accept raw text

2018-01-04 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-6424: - Summary: QueryableStateIntegrationTest#queryOnRebalance should be accept raw text Key: KAFKA-6424 URL: https://issues.apache.org/jira/browse/KAFKA-6424 Project: Kafka

Re: Pull Request emails are not being sent to the mailing list

2018-01-02 Thread Ted Yu
pull request emails, at least the initial one, are recorded on the underlying JIRA. For the time being, you can get to pull request(s) of interest thru JIRA. FYI On Tue, Jan 2, 2018 at 1:30 PM, James Cheng wrote: > Since Dec 21st, it seems that email notifications of

Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable

2018-01-01 Thread Ted Yu
Gentle reminder: one more binding vote is needed for the KIP to pass. Cheers On Thu, Dec 21, 2017 at 4:13 AM, Damian Guy <damian@gmail.com> wrote: > +1 > > On Wed, 20 Dec 2017 at 21:09 Ted Yu <yuzhih...@gmail.com> wrote: > > > Ping for more (binding) votes. >

[jira] [Created] (KAFKA-6413) ReassignPartitionsCommand#parsePartitionReassignmentData() should give better error message when JSON is malformed

2018-01-01 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-6413: - Summary: ReassignPartitionsCommand#parsePartitionReassignmentData() should give better error message when JSON is malformed Key: KAFKA-6413 URL: https://issues.apache.org/jira/browse/KAFKA

[jira] [Created] (KAFKA-6412) Improve synchronization in CachingKeyValueStore methods

2017-12-30 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-6412: - Summary: Improve synchronization in CachingKeyValueStore methods Key: KAFKA-6412 URL: https://issues.apache.org/jira/browse/KAFKA-6412 Project: Kafka Issue Type

Re: [DISCUSS] KIP-242: Mask password fields in Kafka Connect REST response

2017-12-28 Thread Ted Yu
For the last point you raised, can you come up with a unit test that shows what you observed ? Cheers On Mon, Dec 18, 2017 at 11:14 AM, Vincent Meng wrote: > Hi all, > > I've created KIP-242, a proposal to secure credentials in kafka connect > rest endpoint. > >

Re: Unable to start Sink connectors[Confluent Kafka]

2017-12-28 Thread Ted Yu
Looking at https://docs.confluent.io/3.0.0/control-center/docs/clients.html#adding-the-interceptor-to-your-kafka-consumer , it seems that the class name in interceptor.classes had a typo (extra 'e'). Can you double check ? Cheers On Tue, Dec 19, 2017 at 11:00 PM, Somasundaram Sekar <

Re: [VOTE] KIP-233: Simplify StreamsBuilder#addGlobalStore

2017-12-27 Thread Ted Yu
+1 On Wed, Dec 27, 2017 at 12:15 PM, Bill Bejeck wrote: > +1 > > On Wed, Dec 27, 2017 at 3:07 PM, Matthias J. Sax > wrote: > > > +1 > > > > On 12/26/17 9:00 PM, Panuwat Anawatmongkhon wrote: > > > Hi all, > > > I would like to start the vote thread. >

Re: Vote for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams constructor

2017-12-26 Thread Ted Yu
ms ok to me. > > > > -Matthias > > > @Boyang: it's recommended to use this format for the subject > > "[VOTE] KIP-245: ..." > > Same for DISCUSS threads. People are used to those headlines and they > pay more attention than. For this KIP, just leave it as

Re: Vote for KIP-245: Use Properties instead of StreamsConfig in KafkaStreams constructor

2017-12-26 Thread Ted Yu
Normally a DISCUSS thread precedes VOTE thread so that people have ample time examining the proposal. Original message From: Boyang Chen Date: 12/26/17 1:22 AM (GMT-07:00) To: dev@kafka.apache.org Subject: Vote for KIP-245: Use Properties instead of

Re: [VOTE] KIP-239 Add queryableStoreName() to GlobalKTable

2017-12-20 Thread Ted Yu
Ping for more (binding) votes. The pull request is ready. On Fri, Dec 15, 2017 at 12:57 PM, Guozhang Wang <wangg...@gmail.com> wrote: > +1 (binding), thanks! > > On Fri, Dec 15, 2017 at 11:56 AM, Ted Yu <yuzhih...@gmail.com> wrote: > > > Hi, > > Here is

[jira] [Created] (KAFKA-6384) TransactionsTest#testFencingOnSendOffsets sometimes fails with ProducerFencedException

2017-12-18 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-6384: - Summary: TransactionsTest#testFencingOnSendOffsets sometimes fails with ProducerFencedException Key: KAFKA-6384 URL: https://issues.apache.org/jira/browse/KAFKA-6384 Project

Re: [VOTE] KIP-243: Make ProducerConfig and ConsumerConfig constructors public

2017-12-18 Thread Ted Yu
+1 nit: via "copy and past" an 'e' is missing at the end. On Mon, Dec 18, 2017 at 2:38 PM, Matthias J. Sax wrote: > Hi, > > I want to propose the following KIP: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- >

[VOTE] KIP-239 Add queryableStoreName() to GlobalKTable

2017-12-15 Thread Ted Yu
Hi, Here is the discussion thread: http://search-hadoop.com/m/Kafka/uyzND12QnH514pPO9?subj=Re+DISCUSS+KIP+239+Add+queryableStoreName+to+GlobalKTable Please vote on this KIP. Thanks

Re: [VOTE] KIP-238: Expose Kafka cluster ID in Connect REST API

2017-12-15 Thread Ted Yu
+1 On Fri, Dec 15, 2017 at 10:49 AM, Ewen Cheslack-Postava wrote: > Discussion seems to have tapered off, so I'd like to start the vote on > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 238%3A+Expose+Kafka+cluster+ID+in+Connect+REST+API > > Obviously +1 (binding)

Re: [DISCUSS] KIP-240: AdminClient.listReassignments AdminClient.describeReassignments

2017-12-15 Thread Ted Yu
Please create corresponding JIRA. For class Reassignment, it seems you forgot to include set of brokers. For class DescribeReassignmentsResult: public KafkaFuture reassignments(); the return value should be a Collection. On Fri, Dec 15, 2017 at 10:16 AM, Tom Bentley

[jira] [Created] (KAFKA-6370) MirrorMakerIntegrationTest#testCommaSeparatedRegex may fail due to NullPointerException

2017-12-14 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-6370: - Summary: MirrorMakerIntegrationTest#testCommaSeparatedRegex may fail due to NullPointerException Key: KAFKA-6370 URL: https://issues.apache.org/jira/browse/KAFKA-6370 Project

Re: Queries on Kafka Capacity

2017-12-14 Thread Ted Yu
It seems this should help (coming in 1.1 release): https://cwiki.apache.org/confluence/display/KAFKA/KIP-113%3A+Support+replicas+movement+between+log+directories On Wed, Dec 13, 2017 at 11:37 PM, ajay chaudhary < juniora...@yahoo.com.invalid> wrote: > Hi Team, > This is Ajay working with Yodlee

Re: Reg. beginner issues for a new contributor

2017-12-14 Thread Ted Yu
Have you seen this ? http://search-hadoop.com/m/Kafka/uyzND14PPsT5THhN1?subj=Re+Contributing+to+Kafka On Thu, Dec 14, 2017 at 8:55 AM, Abhinav Koppula wrote: > Hi Team, > I wanted to get started with contributing to Kafka and learn more about its > internals. Can

Re: [DISCUSS] KIP-236 Interruptible Partition Reassignment

2017-12-13 Thread Ted Yu
Tom: bq. create a znode /admin/reassignments/$topic-$partition Looks like the tree structure above should be: /admin/reassignments/$topic/$partition bq. The controller removes /admin/reassignment/$topic/$partition Note the lack of 's' for reassignment. It would be good to make zookeeper paths

[DISCUSS] KIP-239 Add queryableStoreName() to GlobalKTable

2017-12-12 Thread Ted Yu
Hi, Please kindly provide feedback on the following KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-239+Add+queryableStoreName%28%29+to+GlobalKTable Thanks

Re: [VOTE] KIP-226 - Dynamic Broker Configuration

2017-12-12 Thread Ted Yu
+1 On Tue, Dec 12, 2017 at 5:44 AM, Rajini Sivaram wrote: > Since there are no more outstanding comments, I would like to start vote > for KIP-226: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 226+-+Dynamic+Broker+Configuration > > > The KIP enables

Re: [DISCUSS] KIP-238: Expose Kafka cluster ID in Connect REST API

2017-12-11 Thread Ted Yu
ou wouldn't be able to load the configs or > status topics, etc). > > -Ewen > > On Mon, Dec 11, 2017 at 4:35 PM, Ted Yu <yuzhih...@gmail.com> wrote: > > > Looks good overall. > > > > Currently lookupKafkaClusterId() is called synchronously. Have you > > consi

Re: [DISCUSS] KIP-238: Expose Kafka cluster ID in Connect REST API

2017-12-11 Thread Ted Yu
Looks good overall. Currently lookupKafkaClusterId() is called synchronously. Have you considered making the call asynchronous (normally the GET / request comes sometime after worker start) ? Thanks On Mon, Dec 11, 2017 at 3:40 PM, Ewen Cheslack-Postava wrote: > I'd like to

Re: [VOTE] KIP-86: Configurable SASL callback handlers

2017-12-11 Thread Ted Yu
+1 Original message From: Tom Bentley Date: 12/11/17 6:06 AM (GMT-08:00) To: dev@kafka.apache.org Subject: Re: [VOTE] KIP-86: Configurable SASL callback handlers +1 (non-binding) On 5 May 2017 at 11:57, Mickael Maison wrote:

Re: [DISCUSS] KIP-236 Interruptible Partition Reassignment

2017-12-09 Thread Ted Yu
For the znodes created under /admin/reassignments/, would it be better if the partition znodes for the same topic are put under subtree headed by topic name ? In Tom's example, instead of: /admin/reassignments/mytopic-42 the znode would be: /admin/reassignments/mytopic/42 Cheers On Fri, Dec

[jira] [Created] (KAFKA-6335) SimpleAclAuthorizerTest#testHighConcurrencyModificationOfResourceAcls fails intermittently

2017-12-08 Thread Ted Yu (JIRA)
Ted Yu created KAFKA-6335: - Summary: SimpleAclAuthorizerTest#testHighConcurrencyModificationOfResourceAcls fails intermittently Key: KAFKA-6335 URL: https://issues.apache.org/jira/browse/KAFKA-6335 Project

Re: [VOTE] KIP-218: Make KafkaFuture.Function java 8 lambda compatible

2017-12-08 Thread Ted Yu
+1 On Fri, Dec 8, 2017 at 3:49 AM, Steven Aerts wrote: > Hello everybody, > > > I think KIP-218 is crystallized enough to start voting. > > KIP documentation: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- >

Re: [DISCUSS] KIP-237: More Controller Health Metrics

2017-12-06 Thread Ted Yu
Thanks for the KIP. Can you add description for EventRateAndQueueTimeMs ? Cheers On Wed, Dec 6, 2017 at 6:21 PM, Dong Lin wrote: > Hi all, > > I have created KIP-237: More Controller Health Metrics > https://cwiki.apache.org/confluence/display/KAFKA/KIP- >

Re: [DISCUSS] KIP-228 Negative record timestamp support

2017-12-06 Thread Ted Yu
bq. Using deltas will probably cause lots of headaches The downside of my initial proposal for using delta is that it didn't keep the natural ordering among negative timestamps. Here is variation of using delta : -1 is still kept as how it is treated today. The delta is calculated based on:

Re: [DISCUSS] KIP-228 Negative record timestamp support

2017-12-05 Thread Ted Yu
bq. you can add X to the timestamp before you produce Kafka message This assumes the earliest timestamp (for user application) is known beforehand. However, what if this earliest timestamp shifts even earlier (e.g. due to some discovery) ? Cheers On Tue, Dec 5, 2017 at 6:36 PM, Dong Lin

Re: [DISCUSS] KIP-228 Negative record timestamp support

2017-12-05 Thread Ted Yu
What if the negative timestamp is stored this way ? Long.MIN_VALUE + delta (where delta is positvie) and calculated this way when used: 1/1/1970 - delta This approach avoids the ambiguity of -1 timestamp since -1 would be stored as Long.MIN_VALUE+1 Log retention can handle such format with

Re: [DISCUSS] KIP-227: Introduce Incremental FetchRequests to Increase Partition Scalability

2017-12-05 Thread Ted Yu
c 5, 2017, at 11:24, Ted Yu wrote: > > bq. We also have a tunable for total number of cache slots. We never > > cache > > more than this number of incremental fetch sessions. > > > > Is it possible to manage the cache based on heap consumption instead of > > numbe

Re: [DISCUSS] KIP-228 Negative record timestamp support

2017-12-05 Thread Ted Yu
I made a relevant changes to the KIP. > > > On Dec 5, 2017, at 11:59 AM, Ted Yu <yuzhih...@gmail.com> wrote: > > > > In KeepTimestampOnInvalidTimestamp, there should be check that > timestamp is > > < 0. > > This would protect against future change to onInva

Re: [DISCUSS] KIP-227: Introduce Incremental FetchRequests to Increase Partition Scalability

2017-12-05 Thread Ted Yu
bq. We also have a tunable for total number of cache slots. We never cache more than this number of incremental fetch sessions. Is it possible to manage the cache based on heap consumption instead of number of slots ? It seems heap estimation can be done by counting PartitionData (along with

Re: [DISCUSS] KIP-228 Negative record timestamp support

2017-12-05 Thread Ted Yu
In KeepTimestampOnInvalidTimestamp, there should be check that timestamp is < 0. This would protect against future change to onInvalidTimestamp() callback. Wednesday, December 31, 1969 11:59:59 PM UTC was in the past. Can you enrich Motivation section on why the proposal is made (writing data

Re: [DISCUSS] KIP-233: Simplify StreamsBuilder#addGlobalStore

2017-12-05 Thread Ted Yu
gt; Thanks a lot for the KIP! > > > > Just one nit: `does not follow provide a good` -> spelling: remove > > `follow` ? > > > > Otherwise, looks good to me. > > > > > > -Matthias > > > > > > > > On

Re: [DISCUSS] KIP-231: Improve the Required ACL of ListGroups API

2017-12-04 Thread Ted Yu
and your point about "The user should know > which group(s) he / she is allowed to describe." in relationship to the > KIP. Perhaps you can clarify? > > Thanks. > --Vahid > > > > > From: Ted Yu <yuzhih...@gmail.com> > To: dev@kafka.apache.org

Re: [DISCUSS] KIP-231: Improve the Required ACL of ListGroups API

2017-12-04 Thread Ted Yu
I agree with Dong on maintaining the semantics. The user should know which group(s) he / she is allowed to describe. Cheers On Mon, Dec 4, 2017 at 1:40 PM, Dong Lin wrote: > Hey Vahid, > > Thanks for the KIP. If I understand the you correctly, you want client to > be able

Re: [DISCUSS] KIP-232: Detect outdated metadata by adding ControllerMetadataEpoch field

2017-12-04 Thread Ted Yu
gt; Thanks, > Dong > > On Sat, Dec 2, 2017 at 3:05 PM, Ted Yu <yuzhih...@gmail.com> wrote: > > > bq. It the controller_epoch of the incoming MetadataResponse, or if the > > controller_epoch is the same but the controller_metadata_epoch > > > > Can yo

Re: [DISCUSS] KIP-233: Simplify StreamsBuilder#addGlobalStore

2017-12-04 Thread Ted Yu
lStreamsBuilder# > globalTable > > On Mon, 4 Dec 2560 at 23:10 Ted Yu <yuzhih...@gmail.com> wrote: > > > Can you describe how sourceName is inferred based on the new API ? > > > > Please fill out JIRA number. > > > > BTW here is the URL for the KIP:

Re: [DISCUSS] KIP-234: add support for getting topic defaults from AdminClient

2017-12-04 Thread Ted Yu
In the example, resources is derived from ConfigResource. It would be clearer if you show the derivation. Cheers On Mon, Dec 4, 2017 at 9:51 AM, dan <dan.norw...@gmail.com> wrote: > I added sample usage as well as a WIP commit to the KIP. > > dan > > On Mon, Dec 4, 20

Re: [DISCUSS] KIP-234: add support for getting topic defaults from AdminClient

2017-12-04 Thread Ted Yu
Can you add some code snippet showing how ConfigResource delivers topic defaults with the proposed change ? Cheers On Mon, Dec 4, 2017 at 9:25 AM, dan wrote: > I would like to start a discussion about KIP-234 > https://cwiki.apache.org/confluence/display/KAFKA/KIP- >

<    1   2   3   4   5   >