Re: Operator order

2016-06-20 Thread Yasuhiro Matsuda
You can do a conditional branching by using KStream.branch(Predicate...). You can then merge multiple streams using KStreamBuilder.merge(KStream...). -Yasuhiro On Mon, Jun 20, 2016 at 4:45 AM, Jeyhun Karimov wrote: > Hi Guozhang, > > Thank you for your reply. Yes, it is correct. Your solution i

Re: KStream/KTable prioritization/initial offset

2016-03-25 Thread Yasuhiro Matsuda
It may not be ideal, but there is a way to prioritize particular topics. It is to set the record timestamps to zero. This can be done by using a custom TimestampExtractor. Kafka Streams tries to synchronize multiple streams using the extracted timestamps. So, records with the timestamp 0 have great

[jira] [Created] (KAFKA-3395) prefix job id to internal topic names

2016-03-14 Thread Yasuhiro Matsuda (JIRA)
Yasuhiro Matsuda created KAFKA-3395: --- Summary: prefix job id to internal topic names Key: KAFKA-3395 URL: https://issues.apache.org/jira/browse/KAFKA-3395 Project: Kafka Issue Type: Sub

[jira] [Created] (KAFKA-3271) Notification upon unclean leader election

2016-02-23 Thread Yasuhiro Matsuda (JIRA)
Yasuhiro Matsuda created KAFKA-3271: --- Summary: Notification upon unclean leader election Key: KAFKA-3271 URL: https://issues.apache.org/jira/browse/KAFKA-3271 Project: Kafka Issue Type

[jira] [Updated] (KAFKA-3262) Make KafkaStreams debugging friendly

2016-02-22 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-3262: Description: Current KafkaStreams polls records in the same thread as the data processing

[jira] [Created] (KAFKA-3262) Make KafkaStreams debugging friendly

2016-02-22 Thread Yasuhiro Matsuda (JIRA)
Yasuhiro Matsuda created KAFKA-3262: --- Summary: Make KafkaStreams debugging friendly Key: KAFKA-3262 URL: https://issues.apache.org/jira/browse/KAFKA-3262 Project: Kafka Issue Type: Sub

[jira] [Created] (KAFKA-3245) need a way to specify the number of replicas for change log topics

2016-02-17 Thread Yasuhiro Matsuda (JIRA)
Yasuhiro Matsuda created KAFKA-3245: --- Summary: need a way to specify the number of replicas for change log topics Key: KAFKA-3245 URL: https://issues.apache.org/jira/browse/KAFKA-3245 Project

[jira] [Created] (KAFKA-3153) Serializer/Deserializer Registration and Type inference

2016-01-26 Thread Yasuhiro Matsuda (JIRA)
Yasuhiro Matsuda created KAFKA-3153: --- Summary: Serializer/Deserializer Registration and Type inference Key: KAFKA-3153 URL: https://issues.apache.org/jira/browse/KAFKA-3153 Project: Kafka

[jira] [Updated] (KAFKA-3108) KStream custom StreamPartitioner for windowed key

2016-01-14 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-3108: Priority: Minor (was: Major) > KStream custom StreamPartitioner for windowed

[jira] [Updated] (KAFKA-3108) KStream custom StreamPartitioner for windowed key

2016-01-14 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-3108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-3108: Summary: KStream custom StreamPartitioner for windowed key (was: KStream custom

[jira] [Created] (KAFKA-3108) KStream custom Partitioner for windowed key

2016-01-14 Thread Yasuhiro Matsuda (JIRA)
Yasuhiro Matsuda created KAFKA-3108: --- Summary: KStream custom Partitioner for windowed key Key: KAFKA-3108 URL: https://issues.apache.org/jira/browse/KAFKA-3108 Project: Kafka Issue Type

[jira] [Created] (KAFKA-3060) Refactor MeteredXXStore

2016-01-04 Thread Yasuhiro Matsuda (JIRA)
Yasuhiro Matsuda created KAFKA-3060: --- Summary: Refactor MeteredXXStore Key: KAFKA-3060 URL: https://issues.apache.org/jira/browse/KAFKA-3060 Project: Kafka Issue Type: Sub-task

[jira] [Created] (KAFKA-3016) Add KStream-KStream window joins

2015-12-18 Thread Yasuhiro Matsuda (JIRA)
Yasuhiro Matsuda created KAFKA-3016: --- Summary: Add KStream-KStream window joins Key: KAFKA-3016 URL: https://issues.apache.org/jira/browse/KAFKA-3016 Project: Kafka Issue Type: Sub-task

[jira] [Updated] (KAFKA-2984) KTable should send old values along with new values to downstreams

2015-12-11 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2984: Summary: KTable should send old values along with new values to downstreams (was: KTable

[jira] [Created] (KAFKA-2984) KTable should send old values to downstreams

2015-12-11 Thread Yasuhiro Matsuda (JIRA)
Yasuhiro Matsuda created KAFKA-2984: --- Summary: KTable should send old values to downstreams Key: KAFKA-2984 URL: https://issues.apache.org/jira/browse/KAFKA-2984 Project: Kafka Issue Type

[jira] [Updated] (KAFKA-2962) Add Simple Join API

2015-12-08 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2962: Description: Stream-Table and Table-Table joins > Add Simple Join

[jira] [Updated] (KAFKA-2962) Add Simple Join API

2015-12-08 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2962: Summary: Add Simple Join API (was: Add Join API) > Add Simple Join

[jira] [Created] (KAFKA-2962) Add Join API

2015-12-08 Thread Yasuhiro Matsuda (JIRA)
Yasuhiro Matsuda created KAFKA-2962: --- Summary: Add Join API Key: KAFKA-2962 URL: https://issues.apache.org/jira/browse/KAFKA-2962 Project: Kafka Issue Type: Sub-task Components

Re: Possible StreamingConfig Bug

2015-11-27 Thread Yasuhiro Matsuda
The group id is removed from the restore consumer config because the restore consumer should not participate in the specified consumer group. I don't know why it is failing. On Fri, Nov 27, 2015 at 12:37 PM, Guozhang Wang wrote: > Hello Bill, > > Thanks for reporting it, this is a valid issue, c

[jira] [Created] (KAFKA-2856) add KTable

2015-11-17 Thread Yasuhiro Matsuda (JIRA)
Yasuhiro Matsuda created KAFKA-2856: --- Summary: add KTable Key: KAFKA-2856 URL: https://issues.apache.org/jira/browse/KAFKA-2856 Project: Kafka Issue Type: Sub-task Components

[jira] [Assigned] (KAFKA-2811) Add standby tasks

2015-11-11 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda reassigned KAFKA-2811: --- Assignee: Yasuhiro Matsuda > Add standby ta

[jira] [Created] (KAFKA-2811) Add standby tasks

2015-11-11 Thread Yasuhiro Matsuda (JIRA)
Yasuhiro Matsuda created KAFKA-2811: --- Summary: Add standby tasks Key: KAFKA-2811 URL: https://issues.apache.org/jira/browse/KAFKA-2811 Project: Kafka Issue Type: Sub-task

[jira] [Assigned] (KAFKA-2763) Reduce stream task migrations and initialization costs

2015-11-11 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda reassigned KAFKA-2763: --- Assignee: Yasuhiro Matsuda > Reduce stream task migrations and initialization co

[jira] [Created] (KAFKA-2763) Reduce stream task migrations and initialization costs

2015-11-06 Thread Yasuhiro Matsuda (JIRA)
Yasuhiro Matsuda created KAFKA-2763: --- Summary: Reduce stream task migrations and initialization costs Key: KAFKA-2763 URL: https://issues.apache.org/jira/browse/KAFKA-2763 Project: Kafka

[jira] [Updated] (KAFKA-2727) initialize only the part of the topology relevant to the task

2015-11-03 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2727: Description: Currently each streaming task initializes the entire topology regardless of

[jira] [Created] (KAFKA-2727) initialize only the part of the topology relevant to the task

2015-11-02 Thread Yasuhiro Matsuda (JIRA)
Yasuhiro Matsuda created KAFKA-2727: --- Summary: initialize only the part of the topology relevant to the task Key: KAFKA-2727 URL: https://issues.apache.org/jira/browse/KAFKA-2727 Project: Kafka

[jira] [Updated] (KAFKA-2707) Make KStream processor names deterministic

2015-10-29 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2707: Description: Currently KStream processor names are generated from AtomicInteger static

[jira] [Created] (KAFKA-2707) Make KStream processor names deteministic

2015-10-29 Thread Yasuhiro Matsuda (JIRA)
Yasuhiro Matsuda created KAFKA-2707: --- Summary: Make KStream processor names deteministic Key: KAFKA-2707 URL: https://issues.apache.org/jira/browse/KAFKA-2707 Project: Kafka Issue Type

[jira] [Updated] (KAFKA-2707) Make KStream processor names deterministic

2015-10-29 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2707: Summary: Make KStream processor names deterministic (was: Make KStream processor names

[jira] [Created] (KAFKA-2706) Make state stores first class citizens in the processor DAG

2015-10-29 Thread Yasuhiro Matsuda (JIRA)
Yasuhiro Matsuda created KAFKA-2706: --- Summary: Make state stores first class citizens in the processor DAG Key: KAFKA-2706 URL: https://issues.apache.org/jira/browse/KAFKA-2706 Project: Kafka

[jira] [Resolved] (KAFKA-2592) Stop Writing the Change-log in store.put() / delete() for Non-transactional Store

2015-10-28 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda resolved KAFKA-2592. - Resolution: Won't Fix > Stop Writing the Change-log in store.put() / delete()

[jira] [Updated] (KAFKA-2694) Make a task id be a composite id of a topic group id and a partition id

2015-10-26 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2694: Summary: Make a task id be a composite id of a topic group id and a partition id (was

[jira] [Assigned] (KAFKA-2694) Make a task id be a composite id of a topic group id and a partition id

2015-10-26 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda reassigned KAFKA-2694: --- Assignee: Yasuhiro Matsuda > Make a task id be a composite id of a topic group

[jira] [Updated] (KAFKA-2694) Make a task id be a composite id of a task group id and a partition id

2015-10-26 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2694?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2694: Issue Type: Sub-task (was: Task) Parent: KAFKA-2590 > Make a task id b

[jira] [Created] (KAFKA-2694) Make a task id be a composite id of a task group id and a partition id

2015-10-26 Thread Yasuhiro Matsuda (JIRA)
Yasuhiro Matsuda created KAFKA-2694: --- Summary: Make a task id be a composite id of a task group id and a partition id Key: KAFKA-2694 URL: https://issues.apache.org/jira/browse/KAFKA-2694 Project

Re: KIP-28 does not allow Processor to specify partition of output message

2015-10-14 Thread Yasuhiro Matsuda
t; The bottom line is that *different* topics will likely need to be > partitioned differently. > > On October 14, 2015 at 12:57:37 PM, Yasuhiro Matsuda ( > yasuhiro.mats...@gmail.com) wrote: > > A partitioning scheme should be a cluster wide thing. Letting each sink > have a d

Re: KIP-28 does not allow Processor to specify partition of output message

2015-10-14 Thread Yasuhiro Matsuda
A partitioning scheme should be a cluster wide thing. Letting each sink have a different partitioning scheme does not make sense to me. A partitioning scheme is not specific to a stream job, each task or a sink. I think specifying it at sink level is more error prone. If a user wants to customize

Re: [DISCUSS] KIP-27 - Conditional Publish

2015-08-04 Thread Yasuhiro Matsuda
t; > >> >> > For 1, yes, when there is a transient leader change, > it's > > > >> > > guaranteed > > > >> > > >> >> that a > > > >> > > >> >> > prefix of the messages in a request will be co

[jira] [Commented] (KAFKA-2350) Add KafkaConsumer pause capability

2015-07-24 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14640958#comment-14640958 ] Yasuhiro Matsuda commented on KAFKA-2350: - Throwing exceptions makes sense

Re: [DISCUSS] KIP-28 - Add a transform client for data processing

2015-07-24 Thread Yasuhiro Matsuda
Jay, I understand that. Context can provide more information without breaking the compatibility if needed. Also I am not sure ConsumerRecord is the right abstraction of data for stream processing. After transformation or join, what is the topic and the offset? It is odd to use ConsumerRecord. We ca

Re: [DISCUSS] KIP-28 - Add a transform client for data processing

2015-07-24 Thread Yasuhiro Matsuda
The goal of this KIP is to provide a lightweight/embeddable streaming framework, and allows Kafka users to start using stream processing easily. DSL is not covered in this KIP. But, DSL is a very attractive option to have. > In the proposed KafkaProcessor API, there is no interface like Collector

[jira] [Commented] (KAFKA-2350) Add KafkaConsumer pause capability

2015-07-23 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14639460#comment-14639460 ] Yasuhiro Matsuda commented on KAFKA-2350: - Suppose we are using auto assign

[jira] [Commented] (KAFKA-2350) Add KafkaConsumer pause capability

2015-07-22 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637219#comment-14637219 ] Yasuhiro Matsuda commented on KAFKA-2350: - I think overloading subsc

Re: [DISCUSS] KIP-27 - Conditional Publish

2015-07-21 Thread Yasuhiro Matsuda
n general, being able to get the offsets from the producer interface > > does sound convenient. > > > > > We plan to have a KIP discussion meeting tomorrow at 11am PST. Perhaps > > you > > > can describe this KIP a bit then? > > > > Sure, happy to join

[jira] [Commented] (KAFKA-2350) Add KafkaConsumer pause capability

2015-07-20 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634322#comment-14634322 ] Yasuhiro Matsuda commented on KAFKA-2350: - To me the state preservation is n

[jira] [Commented] (KAFKA-2350) Add KafkaConsumer pause capability

2015-07-20 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14634229#comment-14634229 ] Yasuhiro Matsuda commented on KAFKA-2350: - Can we have TopicPartition rather

[jira] [Comment Edited] (KAFKA-2260) Allow specifying expected offset on produce

2015-07-17 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632259#comment-14632259 ] Yasuhiro Matsuda edited comment on KAFKA-2260 at 7/18/15 4:1

[jira] [Commented] (KAFKA-2260) Allow specifying expected offset on produce

2015-07-17 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14632259#comment-14632259 ] Yasuhiro Matsuda commented on KAFKA-2260: - Here is the outline of the variant

[jira] [Updated] (KAFKA-2226) NullPointerException in TestPurgatoryPerformance

2015-05-29 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2226: Attachment: KAFKA-2226_2015-05-29_15:10:24.patch > NullPointerException

[jira] [Commented] (KAFKA-2226) NullPointerException in TestPurgatoryPerformance

2015-05-29 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565538#comment-14565538 ] Yasuhiro Matsuda commented on KAFKA-2226: - Updated reviewboard h

Re: Review Request 34734: Patch for KAFKA-2226

2015-05-29 Thread Yasuhiro Matsuda
/r/34734/diff/ Testing --- Thanks, Yasuhiro Matsuda

Re: Review Request 34734: Patch for KAFKA-2226

2015-05-29 Thread Yasuhiro Matsuda
/r/34734/diff/ Testing --- Thanks, Yasuhiro Matsuda

[jira] [Updated] (KAFKA-2226) NullPointerException in TestPurgatoryPerformance

2015-05-29 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2226: Attachment: KAFKA-2226_2015-05-29_15:04:35.patch > NullPointerException

[jira] [Commented] (KAFKA-2226) NullPointerException in TestPurgatoryPerformance

2015-05-29 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565522#comment-14565522 ] Yasuhiro Matsuda commented on KAFKA-2226: - Updated reviewboard h

Re: Review Request 34734: Patch for KAFKA-2226

2015-05-29 Thread Yasuhiro Matsuda
led" is a legitimate spelling in American English. - Yasuhiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34734/#review85764 ---

Re: Review Request 34734: Patch for KAFKA-2226

2015-05-29 Thread Yasuhiro Matsuda
ms that we can add > > the entry either when it's created for the first time or when it's removed > > from the current list and needs to be added to a new list during reinsert. > > In both cases, the list in the entry will be null and there is no need to > > remove

[jira] [Commented] (KAFKA-2226) NullPointerException in TestPurgatoryPerformance

2015-05-29 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14565133#comment-14565133 ] Yasuhiro Matsuda commented on KAFKA-2226: - Updated reviewboard h

Re: Review Request 34734: Patch for KAFKA-2226

2015-05-29 Thread Yasuhiro Matsuda
; remove the entry from the list. I will remove this. - Yasuhiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34734/#review85596 ---------

[jira] [Updated] (KAFKA-2226) NullPointerException in TestPurgatoryPerformance

2015-05-29 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2226: Attachment: KAFKA-2226_2015-05-29_10:49:34.patch > NullPointerException

Re: Review Request 34734: Patch for KAFKA-2226

2015-05-29 Thread Yasuhiro Matsuda
/r/34734/diff/ Testing --- Thanks, Yasuhiro Matsuda

Re: Review Request 34734: Patch for KAFKA-2226

2015-05-29 Thread Yasuhiro Matsuda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34734/#review85665 --- On May 29, 2015, 12:19 a.m., Yasuhiro Matsuda wrote: > > --

[jira] [Commented] (KAFKA-2226) NullPointerException in TestPurgatoryPerformance

2015-05-28 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14563965#comment-14563965 ] Yasuhiro Matsuda commented on KAFKA-2226: - Updated reviewboard h

Re: Review Request 34734: Patch for KAFKA-2226

2015-05-28 Thread Yasuhiro Matsuda
/r/34734/diff/ Testing --- Thanks, Yasuhiro Matsuda

[jira] [Updated] (KAFKA-2226) NullPointerException in TestPurgatoryPerformance

2015-05-28 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2226: Attachment: KAFKA-2226_2015-05-28_17:18:55.patch > NullPointerException

Re: Review Request 34734: Patch for KAFKA-2226

2015-05-28 Thread Yasuhiro Matsuda
> > 134 is called and the entry is not removed since list is now null, (4) line > > 133 is tested again and since list is now null, we quit the loop, (5) the > > reinsert process adds the entry to a new list. > > > > At this point, a completed entry still exi

Re: Review Request 34734: Patch for KAFKA-2226

2015-05-28 Thread Yasuhiro Matsuda
> > 134 is called and the entry is not removed since list is now null, (4) line > > 133 is tested again and since list is now null, we quit the loop, (5) the > > reinsert process adds the entry to a new list. > > > > At this point, a completed entry still exi

Re: Review Request 34734: Patch for KAFKA-2226

2015-05-28 Thread Yasuhiro Matsuda
e-mail. To reply, visit: https://reviews.apache.org/r/34734/#review85596 --- On May 27, 2015, 9 p.m., Yasuhiro Matsuda wrote: > > --- > This is an automatically generated

Re: Review Request 34734: Patch for KAFKA-2226

2015-05-28 Thread Yasuhiro Matsuda
apache.org/r/34734/#review85530 --- On May 27, 2015, 9 p.m., Yasuhiro Matsuda wrote: > > --- > This is an automatically generated e-mail. To reply, vis

[jira] [Updated] (KAFKA-2226) NullPointerException in TestPurgatoryPerformance

2015-05-27 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2226: Status: Patch Available (was: Open) > NullPointerException in TestPurgatoryPerforma

[jira] [Commented] (KAFKA-2226) NullPointerException in TestPurgatoryPerformance

2015-05-27 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561724#comment-14561724 ] Yasuhiro Matsuda commented on KAFKA-2226: - Created reviewboard h

Review Request 34734: Patch for KAFKA-2226

2015-05-27 Thread Yasuhiro Matsuda
, Yasuhiro Matsuda

[jira] [Updated] (KAFKA-2226) NullPointerException in TestPurgatoryPerformance

2015-05-27 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2226: Attachment: KAFKA-2226.patch > NullPointerException in TestPurgatoryPerforma

[jira] [Commented] (KAFKA-1989) New purgatory design

2015-05-27 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561470#comment-14561470 ] Yasuhiro Matsuda commented on KAFKA-1989: - Thanks. I am looking into it. W

Re: Review Request 33071: Dynamically load JRE-specific class in TestPurgatoryPerformance

2015-04-16 Thread Yasuhiro Matsuda
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33071/#review80342 --- Cool! It looks good to me. - Yasuhiro Matsuda On April 10, 2015

[jira] [Commented] (KAFKA-2112) make overflowWheel volatile

2015-04-09 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14487830#comment-14487830 ] Yasuhiro Matsuda commented on KAFKA-2112: - Created reviewboard h

[jira] [Updated] (KAFKA-2112) make overflowWheel volatile

2015-04-09 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2112: Attachment: KAFKA-2112.patch > make overflowWheel volat

[jira] [Updated] (KAFKA-2112) make overflowWheel volatile

2015-04-09 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2112: Assignee: Yasuhiro Matsuda (was: Joel Koshy) Status: Patch Available (was: Open

Review Request 33028: Patch for KAFKA-2112

2015-04-09 Thread Yasuhiro Matsuda
/33028/diff/ Testing --- Thanks, Yasuhiro Matsuda

[jira] [Created] (KAFKA-2112) make overflowWheel volatile

2015-04-09 Thread Yasuhiro Matsuda (JIRA)
Yasuhiro Matsuda created KAFKA-2112: --- Summary: make overflowWheel volatile Key: KAFKA-2112 URL: https://issues.apache.org/jira/browse/KAFKA-2112 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-1989) New purgatory design

2015-04-08 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14486099#comment-14486099 ] Yasuhiro Matsuda commented on KAFKA-1989: - Updated reviewboard h

[jira] [Updated] (KAFKA-1989) New purgatory design

2015-04-08 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-1989: Attachment: KAFKA-1989_2015-04-08_14:29:51.patch > New purgatory des

Re: Review Request 31568: Patch for KAFKA-1989

2015-04-08 Thread Yasuhiro Matsuda
-CREATION Diff: https://reviews.apache.org/r/31568/diff/ Testing --- Thanks, Yasuhiro Matsuda

[jira] [Updated] (KAFKA-1989) New purgatory design

2015-04-08 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-1989: Attachment: KAFKA-1989_2015-04-08_13:27:59.patch > New purgatory des

[jira] [Commented] (KAFKA-1989) New purgatory design

2015-04-08 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14485950#comment-14485950 ] Yasuhiro Matsuda commented on KAFKA-1989: - Updated reviewboard h

Re: Review Request 31568: Patch for KAFKA-1989

2015-04-08 Thread Yasuhiro Matsuda
-CREATION Diff: https://reviews.apache.org/r/31568/diff/ Testing --- Thanks, Yasuhiro Matsuda

Re: Review Request 31568: Patch for KAFKA-1989

2015-04-08 Thread Yasuhiro Matsuda
multiple executor threads in the pool. I agree! - Yasuhiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31568/#review79408 -------

Re: Review Request 31568: Patch for KAFKA-1989

2015-04-08 Thread Yasuhiro Matsuda
- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31568/#review79269 --- On April 7, 2015, 9:59 p.m., Yasuhiro Matsuda wrote: > >

Re: Review Request 31568: Patch for KAFKA-1989

2015-04-08 Thread Yasuhiro Matsuda
only if it returns > > true, run onExpiration(). > > Yasuhiro Matsuda wrote: > This came from the original ExpiredOperationReaper.expireNext(). Also the > comment on onExpiration says, "Call-back to execute when a delayed operation > expires, but before completion.

Re: Review Request 31568: Patch for KAFKA-1989

2015-04-07 Thread Yasuhiro Matsuda
single null compare (no method call, no synchronization), which is the cheapest. - Yasuhiro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31568/#review79257 ------

[jira] [Commented] (KAFKA-1989) New purgatory design

2015-04-07 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484170#comment-14484170 ] Yasuhiro Matsuda commented on KAFKA-1989: - Updated reviewboard h

[jira] [Updated] (KAFKA-1989) New purgatory design

2015-04-07 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-1989: Attachment: KAFKA-1989_2015-04-07_14:59:33.patch > New purgatory des

Re: Review Request 31568: Patch for KAFKA-1989

2015-04-07 Thread Yasuhiro Matsuda
-CREATION Diff: https://reviews.apache.org/r/31568/diff/ Testing --- Thanks, Yasuhiro Matsuda

Re: Review Request 31568: Patch for KAFKA-1989

2015-04-07 Thread Yasuhiro Matsuda
n why that is better? It will trigger a lot more purge calls. And the frequency of calls depends on how many keys each request has. When the average number of keys per operation is large, it is possible to have a case that the total number of watchers exceeds the threshold, but there are only a

[jira] [Updated] (KAFKA-1989) New purgatory design

2015-04-01 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-1989: Attachment: KAFKA-1989_2015-04-01_13:49:58.patch > New purgatory des

[jira] [Commented] (KAFKA-1989) New purgatory design

2015-04-01 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-1989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14391422#comment-14391422 ] Yasuhiro Matsuda commented on KAFKA-1989: - Updated reviewboard h

Re: Review Request 31568: Patch for KAFKA-1989

2015-04-01 Thread Yasuhiro Matsuda
-CREATION Diff: https://reviews.apache.org/r/31568/diff/ Testing --- Thanks, Yasuhiro Matsuda

Re: Review Request 31568: Patch for KAFKA-1989

2015-04-01 Thread Yasuhiro Matsuda
gt; > > > > Not quite sure what this is testing. It's not clear to me why the > > sharedCounter won't increase after add. Perhaps, we can add some comments. It is testing that reinserting the existing tasks doesn't change the task count. I will add comments.

Re: Review Request 31893: Patch for KAFKA-2013

2015-03-31 Thread Yasuhiro Matsuda
enerated e-mail. To reply, visit: https://reviews.apache.org/r/31893/#review76975 --- On April 1, 2015, 12:31 a.m., Yasuhiro Matsuda wrote: > > --- > This is an automatically generated e-mail.

[jira] [Updated] (KAFKA-2013) benchmark test for the purgatory

2015-03-31 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yasuhiro Matsuda updated KAFKA-2013: Attachment: KAFKA-2013_2015-03-31_17:30:56.patch > benchmark test for the purgat

[jira] [Commented] (KAFKA-2013) benchmark test for the purgatory

2015-03-31 Thread Yasuhiro Matsuda (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-2013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389764#comment-14389764 ] Yasuhiro Matsuda commented on KAFKA-2013: - Updated reviewboard h

  1   2   >