[GitHub] kafka pull request #1652: KAFKA-2394: move to RollingFileAppender by default...

2017-12-12 Thread cotedm
Github user cotedm closed the pull request at: https://github.com/apache/kafka/pull/1652 ---

[GitHub] kafka pull request #3153: MINOR: clarify partition option behavior for conso...

2017-05-26 Thread cotedm
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/3153 MINOR: clarify partition option behavior for console consumer Console Consumer help doesn't say that ``--partition`` option needs ``--offset`` otherwise will consume from the end of the partition

[GitHub] kafka pull request #2537: MINOR: Improve LogCleaner buffer size change loggi...

2017-02-10 Thread cotedm
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/2537 MINOR: Improve LogCleaner buffer size change logging Right now it looks like the buffer size only grows if you are watching the cleaner logs. It would be nice if we also logged when the buffer size

[GitHub] kafka pull request #2534: Update SimpleAclAuthorizer.scala

2017-02-10 Thread cotedm
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/2534 Update SimpleAclAuthorizer.scala Comments had the wrong name for the Group znode, updating ConsumerGroup-->Group in the comments to match what's actually coded. @ijuma if you can rev

[GitHub] kafka pull request #1681: KAFKA-3590: KafkaConsumer fails with "Messages are...

2016-09-08 Thread cotedm
Github user cotedm closed the pull request at: https://github.com/apache/kafka/pull/1681 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] kafka pull request #1829: KAFKA-4134: log ConnectException at WARN

2016-09-06 Thread cotedm
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1829 KAFKA-4134: log ConnectException at WARN Simply log the connection refused instance. If we're worried about spamming users, I can add a flag to make sure we only log this exception once

[GitHub] kafka pull request #1797: KAFKA-4062: Require --print-data-log if --offsets-...

2016-08-29 Thread cotedm
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1797 KAFKA-4062: Require --print-data-log if --offsets-decoder is enabled for DumpLogOffsets set print-data-log option when offset-decoder is set. @hachikuji we had talked about this one before, does

[GitHub] kafka pull request #1796: KAFKA-4092: retention.bytes should not be allowed ...

2016-08-29 Thread cotedm
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1796 KAFKA-4092: retention.bytes should not be allowed to be less than segment.bytes adding a LogConfig value validator. @gwenshap or @junrao would you mind taking a look? You can merge this pull

[GitHub] kafka pull request #1795: KAFKA-3129: Console producer issue when request-re...

2016-08-29 Thread cotedm
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1795 KAFKA-3129: Console producer issue when request-required-acks=0 change console producer default acks to 1, update acks docs. Also added the -1 config to the acks docs since that question comes up

[GitHub] kafka pull request #1691: MINOR: lower logging severity for offset reset

2016-08-01 Thread cotedm
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1691 MINOR: lower logging severity for offset reset When resetting the first dirty offset to the log start offset, we currently log an ERROR which makes users think the log cleaner has a problem

[GitHub] kafka pull request #1681: KAFKA-3590: KafkaConsumer fails with "Messages are...

2016-07-29 Thread cotedm
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1681 KAFKA-3590: KafkaConsumer fails with "Messages are rejected since there are fewer in-sync replicas than required." when polling This just improves the error message since it's

[GitHub] kafka pull request #1653: KAFKA-2932: Adjust importance level of Kafka Conne...

2016-07-22 Thread cotedm
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1653 KAFKA-2932: Adjust importance level of Kafka Connect configs @ewencp I went down the list of connect configs and it looks like only the internal converter configs are mismarked. It looks like

[GitHub] kafka pull request #1652: KAFKA-2394: move to RollingFileAppender by default...

2016-07-22 Thread cotedm
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1652 KAFKA-2394: move to RollingFileAppender by default for log4j You can merge this pull request into a Git repository by running: $ git pull https://github.com/cotedm/kafka KAFKA-2394

[GitHub] kafka pull request #1434: KAFKA-2394: move to RollingFileAppender by default...

2016-07-22 Thread cotedm
Github user cotedm closed the pull request at: https://github.com/apache/kafka/pull/1434 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] kafka pull request: KAFKA-2394: move to RollingFileAppender by def...

2016-05-26 Thread cotedm
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1434 KAFKA-2394: move to RollingFileAppender by default for log4j This PR sets up the default max log size to be about 1GB. That default should probably be vetted. You can merge this pull request

[GitHub] kafka pull request: KAFKA-3683: Add file descriptor recommendation...

2016-05-09 Thread cotedm
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1353 KAFKA-3683: Add file descriptor recommendation to ops guide Adding sizing recommendations for file descriptors to the ops guide. You can merge this pull request into a Git repository by running

[GitHub] kafka pull request: Update links for new consumer API

2016-05-06 Thread cotedm
GitHub user cotedm opened a pull request: https://github.com/apache/kafka/pull/1331 Update links for new consumer API Pull request to update the consumer API links in the docs. You can merge this pull request into a Git repository by running: $ git pull https://github.com