[jira] [Commented] (KAFKA-2419) Allow certain Sensors to be garbage collected after inactivity

[ https://issues.apache.org/jira/browse/KAFKA-2419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804893#comment-14804893 ] Joel Koshy commented on KAFKA-2419: --- Re: the options in https://issues.apache.org/

[jira] [Commented] (KAFKA-1215) Rack-Aware replica assignment option

[ https://issues.apache.org/jira/browse/KAFKA-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804835#comment-14804835 ] Joel Koshy commented on KAFKA-1215: --- [~allenxwang] you should have access now. &g

[jira] [Commented] (KAFKA-2552) Certain admin commands such as partition assignment fail on large clusters

[ https://issues.apache.org/jira/browse/KAFKA-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804600#comment-14804600 ] Joel Koshy commented on KAFKA-2552: --- Reported in KAFKA-1599 as well? > Certai

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804570#comment-14804570 ] Joel Koshy commented on KAFKA-2120: --- Actually some of the confusion on my sid

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14803291#comment-14803291 ] Joel Koshy commented on KAFKA-2120: --- I see test failure

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14803251#comment-14803251 ] Joel Koshy commented on KAFKA-2120: --- [~mgharat] yes I'm seeing the same thing

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791284#comment-14791284 ] Joel Koshy commented on KAFKA-2120: --- Hmm.. actually after rerunning tests I'm

[jira] [Reopened] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy reopened KAFKA-2120: --- > Add a request timeout to NetworkClient > -- > >

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791049#comment-14791049 ] Joel Koshy commented on KAFKA-2120: --- Yes I did note failures in the RB, but those

[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-2120: -- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks [~mgharat] for the patch, and

Re: Review Request 36858: Patch for KAFKA-2120

consistently. (I haven't checked trunk though) ``` KafkaConsumerTest. testConstructorClose KafkaProducerTest. testConstructorFailureCloseResource SelectorTest. testNoRouteToHost ``` - Joel Koshy On Sept. 16, 2015, 1:57 a.m., Mayuresh Gharat

Re: Review Request 36858: Patch for KAFKA-2120

is is unrelated to expiration right? core/src/main/scala/kafka/tools/ProducerPerformance.scala (line 126) <https://reviews.apache.org/r/36858/#comment155996> revert! - Joel Koshy On Sept. 11, 2015, 9:54 p.m., Mayuresh Gharat wrote: > >

Re: [DISCUSS] KIP-31 - Message format change proposal

tion / attempt to map the design space led >> to some confusion! >> >> -Ewen >> >> >> On Thu, Sep 10, 2015 at 5:48 PM, Jay Kreps wrote: >> >> > Ah, I see, I think I misunderstood about MM, it was called out in the >> > proposal and I thought yo

Re: [DISCUSS] KIP-31 - Message format change proposal

iginal instinct was that it also avoids a backwards incompatible change (but it does not because we also have the relative offset change). Thanks, Joel > > > > On Thu, Sep 10, 2015 at 3:36 PM, Joel Koshy wrote: > >> I just wanted to comment on a few points made earlier in thi

[jira] [Commented] (KAFKA-2529) Brokers should write current version to log when they first start

[ https://issues.apache.org/jira/browse/KAFKA-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739774#comment-14739774 ] Joel Koshy commented on KAFKA-2529: --- Yes this was done in KAFKA-1901, but one issu

[jira] [Commented] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14739766#comment-14739766 ] Joel Koshy commented on KAFKA-2120: --- Thanks for the updated patch - I will review a

Re: [DISCUSS] KIP-31 - Message format change proposal

I just wanted to comment on a few points made earlier in this thread: Concerns on clock skew: at least for the original proposal's scope (which was more for honoring retention broker-side) this would only be an issue when spanning leader movements right? i.e., leader migration latency has to be mu

Re: [kafka-clients] [VOTE] 0.8.2.2 Candidate 1

+1 binding On Thu, Sep 3, 2015 at 9:22 AM, Jun Rao wrote: > This is the first candidate for release of Apache Kafka 0.8.2.2. This only > fixes two critical issues (KAFKA-2189 and KAFKA-2308) related to snappy in > 0.8.2.1. > > Release Notes for the 0.8.2.2 release > https://people.apache.org/~jun

Re: Maybe 0.8.3 should really be 0.9.0?

+1 on 0.9 - we may want to adjust our ApiVersions accordingly (i.e., 0.8.3 -> 0.9.0) On Tue, Sep 8, 2015 at 2:02 PM, Guozhang Wang wrote: > +1 on 0.9 as well. > > On Tue, Sep 8, 2015 at 1:32 PM, Aditya Auradkar < > aaurad...@linkedin.com.invalid> wrote: > >> +1 on 0.9 >> >> On Tue, Sep 8, 2015 a

[jira] [Resolved] (KAFKA-2437) Controller does not handle zk node deletion correctly.

[ https://issues.apache.org/jira/browse/KAFKA-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-2437. --- Resolution: Fixed Fix Version/s: 0.8.3 > Controller does not handle zk node deletion correc

[jira] [Updated] (KAFKA-2502) Quotas documentation for 0.8.3

[ https://issues.apache.org/jira/browse/KAFKA-2502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-2502: -- Description: Complete quotas documentation Also, https://cwiki.apache.org/confluence/display/KAFKA/A

[jira] [Updated] (KAFKA-2332) Add quota metrics to old producer and consumer

[ https://issues.apache.org/jira/browse/KAFKA-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-2332: -- Resolution: Fixed Fix Version/s: 0.8.3 Status: Resolved (was: Patch Available) Issue

Re: [DISCUSS] Client-side Assignment for New Consumer

hat > assumption. > > On Fri, Aug 28, 2015 at 6:33 AM, Neha Narkhede wrote: > >> Thanks for re-reviewing Joel. >> >> >> >> >> >> >> On Fri, Aug 28, 2015 at 2:51 AM -0700, "Joel Koshy" >> wrote: >> >> >> &

Re: [DISCUSS] Client-side Assignment for New Consumer

scaling the co-ordinator out to all nodes and making the > co-ordination vastly cheaper. No proposal, of course, gets rid of the fact > that all clients rejoin at once when there is a membership change, but that > is kind of fundamental to the problem. > > -Jay > > On Thu,

Re: [DISCUSS] Client-side Assignment for New Consumer

I actually feel these set of tests (whatever they may be) are somewhat irrelevant here. My main concern with the current client-side proposal (i.e., without Becket's follow-up suggestions) is that it makes a significant compromise to the original charter of the new consumer - i.e., reduce/eliminate

Re: Review Request 36858: Patch for KAFKA-2120

/RecordAccumulator.java (line 240) <https://reviews.apache.org/r/36858/#comment152173> Also, per the KIP agreement, the request timeout will reset for retries - are you handling that? - Joel Koshy On Aug. 12, 2015, 5:59 p.m., Mayuresh Gharat

[jira] [Updated] (KAFKA-2120) Add a request timeout to NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-2120: -- Status: In Progress (was: Patch Available) > Add a request timeout to NetworkCli

Re: Review Request 36858: Patch for KAFKA-2120

apache.org/r/36858/#comment152170> typo in comment clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java (line 221) <https://reviews.apache.org/r/36858/#comment152172> If you do a reverse iteration and a batch has _not_ expired, then w

Re: Review Request 33378: Patch for KAFKA-2136

> On Aug. 21, 2015, 12:13 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/api/FetchResponse.scala, line 175 > > <https://reviews.apache.org/r/33378/diff/12/?file=1043787#file1043787line175> > > > > Since (in the event of multiple calls) this grouping

[jira] [Commented] (KAFKA-2136) Client side protocol changes to return quota delays

[ https://issues.apache.org/jira/browse/KAFKA-2136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14712324#comment-14712324 ] Joel Koshy commented on KAFKA-2136: --- Thanks for the patches - pushed to trunk. Can

Re: Review Request 33378: Patch for KAFKA-2136

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33378/#review96470 --- Ship it! Ship It! - Joel Koshy On Aug. 25, 2015, 6:30 p.m

[jira] [Updated] (KAFKA-2351) Brokers are having a problem shutting down correctly

[ https://issues.apache.org/jira/browse/KAFKA-2351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-2351: -- Resolution: Fixed Status: Resolved (was: Patch Available) Committed to trunk. > Brokers

Re: Review Request 36652: Patch for KAFKA-2351

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36652/#review96463 --- Ship it! Ship It! - Joel Koshy On Aug. 24, 2015, 10:50 p.m

Re: Review Request 33378: Patch for KAFKA-2136

> On Aug. 22, 2015, 12:45 a.m., Joel Koshy wrote: > > clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java, > > line 107 > > <https://reviews.apache.org/r/33378/diff/12-13/?file=1043780#file1043780line107> > > > > This will probab

Re: Review Request 33378: Patch for KAFKA-2136

a (line 356) <https://reviews.apache.org/r/33378/#comment151508> Can you use this pattern: `groupBy { case (topicAndPartition, _) => topicAndPartition.topic },...` - Joel Koshy On Aug. 24, 2015, 5:33 p.m., A

Re: Review Request 33378: Patch for KAFKA-2136

s is done in the Scala response) - i.e., when we move the broker over to use these protocol schemas. - Joel Koshy On Aug. 21, 2015, 11:30 p.m., Aditya Auradkar wrote: > > --- > This is an automatically generated e-mail. To

Re: Review Request 33378: Patch for KAFKA-2136

> On Aug. 21, 2015, 12:13 a.m., Joel Koshy wrote: > > core/src/main/scala/kafka/api/FetchResponse.scala, line 175 > > <https://reviews.apache.org/r/33378/diff/12/?file=1043787#file1043787line175> > > > > Since (in the event of multiple calls) this grouping

[jira] [Updated] (KAFKA-2442) QuotasTest should not fail when cpu is busy

[ https://issues.apache.org/jira/browse/KAFKA-2442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-2442: -- Reviewer: Joel Koshy will do > QuotasTest should not fail when cpu is b

Re: Review Request 36652: Patch for KAFKA-2351

cross the board? - Joel Koshy On Aug. 13, 2015, 8:10 p.m., Mayuresh Gharat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 36652: Patch for KAFKA-2351

/kafka/network/SocketServer.scala (line 265) <https://reviews.apache.org/r/36652/#comment151267> Yes, but we don't need to do that now. - Joel Koshy On Aug. 13, 2015, 8:10 p.m., Mayuresh Gharat wrote: > > --- >

[jira] [Commented] (KAFKA-2454) Dead lock between delete log segment and shutting down.

[ https://issues.apache.org/jira/browse/KAFKA-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14707091#comment-14707091 ] Joel Koshy commented on KAFKA-2454: --- Thanks - got it. Will take a look at your p

[jira] [Commented] (KAFKA-2454) Dead lock between delete log segment and shutting down.

[ https://issues.apache.org/jira/browse/KAFKA-2454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14706019#comment-14706019 ] Joel Koshy commented on KAFKA-2454: --- I'm a bit unclear on the root cause

Re: Review Request 33378: Patch for KAFKA-2136

119) <https://reviews.apache.org/r/33378/#comment151209> Maybe make this explicitly zero, and `delayTime` can move below as a `val` core/src/main/scala/kafka/server/ClientQuotaManager.scala (line 142) <https://reviews.apache.org/r/33378/#comment151208> any specific reason for this cha

[jira] [Updated] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1901: -- Resolution: Fixed Status: Resolved (was: Patch Available) Thanks for the patch - committed to

Re: Review Request 35867: Patch for KAFKA-1901

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35867/#review96003 --- Ship it! Ship It! - Joel Koshy On Aug. 20, 2015, 7:08 a.m

Re: Review Request 35867: Patch for KAFKA-1901

may as well drop this fingerprint. If we want to add it later, we can - and it may be useful to take the actual numeric value of the leading eight bytes since it makes it easier to instantly associate with a commit hash (otherwise we would need to tabulate commits to their hashCode for easy looku

Re: Review Request 35867: Patch for KAFKA-1901

> On July 21, 2015, 1:58 p.m., Ismael Juma wrote: > > clients/src/main/java/org/apache/kafka/common/utils/AppInfoParser.java, > > line 27 > > > > > > Why isn't this "unknown" like `version`? > > Manikumar Reddy O wr

[jira] [Resolved] (KAFKA-2446) KAFKA-2205 causes existing Topic config changes to be lost

[ https://issues.apache.org/jira/browse/KAFKA-2446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-2446. --- Resolution: Fixed Pushed to trunk. > KAFKA-2205 causes existing Topic config changes to be l

[jira] [Commented] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703965#comment-14703965 ] Joel Koshy commented on KAFKA-2084: --- Actually I did not mean full-fledged [scalas

[jira] [Commented] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14703921#comment-14703921 ] Joel Koshy commented on KAFKA-2084: --- I pushed a trivial commit to address this. How

Re: Review Request 36652: Patch for KAFKA-2351

tal as Becket suggested. I'm leaning toward the latter but I agree we could revisit this. - Joel Koshy On Aug. 13, 2015, 8:10 p.m., Mayuresh Gharat wrote: > > --- > This is an automatically generated e-mail. To reply, v

Re: Review Request 33620: Patch for KAFKA-1690

ng to yield a `BUFFER_OVERFLOW`. I had trouble finding it - can you point me to javadoc/grepcode/equivalent? - Joel Koshy On Aug. 19, 2015, 12:24 a.m., Sriharsha Chintalapani wrote: > > --- > This is an automatic

[jira] [Resolved] (KAFKA-2084) byte rate metrics per client ID (producer and consumer)

[ https://issues.apache.org/jira/browse/KAFKA-2084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy resolved KAFKA-2084. --- Resolution: Fixed Thanks for the patches - committed to trunk. > byte rate metrics per client

Re: Review Request 33049: Patch for KAFKA-2084

/src/main/scala/kafka/server/ClientQuotaManager.scala (line 122) <https://reviews.apache.org/r/33049/#comment150532> can remove core/src/main/scala/kafka/server/ClientQuotaManager.scala (line 148) <https://reviews.apache.org/r/33049/#comment150531> Can omit `return` - Joe

Re: Review Request 33049: Patch for KAFKA-2084

; > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33049/ > --- > > (Updated Aug. 14, 2015, 2:20 a.m.) > > > Review request for kafka, Joel

Re: Review Request 33049: Patch for KAFKA-2084

> On Aug. 13, 2015, 11:13 p.m., Joel Koshy wrote: > > build.gradle, line 383 > > <https://reviews.apache.org/r/33049/diff/25/?file=1039165#file1039165line383> > > > > I don't think these changes 383-385 are needed. > > > > Also, (

Re: Review Request 33049: Patch for KAFKA-2084

049/#comment150256> I don't think these changes 383-385 are needed. Also, (unrelated to this change) I'm seeing NPE errors in running unit tests (e.g., QuotasTest) - can you verify? - Joel Koshy On Aug. 13, 2015, 4:25 a.m., Adity

[jira] [Commented] (KAFKA-2336) Changing offsets.topic.num.partitions after the offset topic is created breaks consumer group partition assignment

[ https://issues.apache.org/jira/browse/KAFKA-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694558#comment-14694558 ] Joel Koshy commented on KAFKA-2336: --- Sorry I should not have assigned it to my

Re: Review Request 33049: Patch for KAFKA-2084

- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33049/ > --- > > (Updated Aug. 12, 2015, 7:09 p.m.) > > > Review request for kafka, Joel Koshy and Jun Rao. > >

Re: Review Request 33049: Patch for KAFKA-2084

> On June 17, 2015, 4:40 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/ClientQuotaMetrics.scala, line 1 > > <https://reviews.apache.org/r/33049/diff/15/?file=983845#file983845line1> > > > > Why was MockTime moved from test to main? > >

Re: Review Request 33049: Patch for KAFKA-2084

) <https://reviews.apache.org/r/33049/#comment150058> We can edit on check-in: should be `ClientQuotaManagerConfig` - Joel Koshy On Aug. 12, 2015, 7:09 p.m., Aditya Auradkar wrote: > > --- > This is an automatically g

Re: Review Request 33049: Patch for KAFKA-2084

eviews.apache.org/r/33049/#comment148424> Uncomment? core/src/test/scala/integration/kafka/api/QuotasTest.scala (line 166) <https://reviews.apache.org/r/33049/#comment148426> Similar comments as above. - Joel Koshy On June 30, 2015, 12:54 a.m., Aditya Auradkar wrote:

Re: Review Request 33378: Patch for KAFKA-2136

cessed here? - Joel Koshy On July 13, 2015, 8:36 p.m., Aditya Auradkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Re: Review Request 36722: Patch for KAFKA-2332

/FetchRequestAndResponseStats.scala (line 25) <https://reviews.apache.org/r/36722/#comment148223> unused import - Joel Koshy On July 23, 2015, 7:12 a.m., Dong Lin wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: [VOTE] Drop support for Scala 2.9 for the next release

+1 On Fri, Jul 17, 2015 at 3:26 AM, Ismael Juma wrote: > Hi all, > > I would like to start a vote on dropping support for Scala 2.9 for the next > release. People seemed to be in favour of the idea in previous discussions: > > * http://search-hadoop.com/m/uyzND1uIW3k2fZVfU1 > * http://search-hado

Re: [VOTE] KIP-26 Add Copycat connector framework for data import/export

+1 Thanks, Joel On Tue, Jul 14, 2015 at 2:09 PM, Ewen Cheslack-Postava wrote: > Hi all, > > Let's start a vote on KIP-26: Add Copycat connector framework for data > import/export > > For reference, here's the wiki: > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=58851767 > An

[jira] [Updated] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1901: -- Status: In Progress (was: Patch Available) > Move Kafka version to be generated in code by bu

Re: Review Request 35867: Patch for KAFKA-1901

rter.java (line 254) <https://reviews.apache.org/r/35867/#comment146038> Can we also log the commit id and fingerprint? - Joel Koshy On July 14, 2015, 12:32 p.m., Manikumar Reddy O wrote: > > --- > This is an auto

[jira] [Updated] (KAFKA-2336) Changing offsets.topic.num.partitions after the offset topic is created breaks consumer group partition assignment

[ https://issues.apache.org/jira/browse/KAFKA-2336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-2336: -- Reviewer: Joel Koshy > Changing offsets.topic.num.partitions after the offset topic is crea

Re: kafka git commit: Hot fix for LIKAFKA-3492; force offset commit/fetches to go to kafka regardless of request version

tree/a098de48 > Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/a098de48 > > Branch: refs/heads/hotfix > Commit: a098de48e61bd0e713e88f3429f84cd57b5fb97d > Parents: 9f80665 > Author: Joel Koshy > Authored: Wed Jul 15 22:26:17 2015 -0700 > Commit

[jira] [Commented] (KAFKA-1944) Rename LogCleaner and related classes to LogCompactor

[ https://issues.apache.org/jira/browse/KAFKA-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14628432#comment-14628432 ] Joel Koshy commented on KAFKA-1944: --- Perhaps KIP would be overkill for this. I w

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627474#comment-14627474 ] Joel Koshy commented on KAFKA-1835: --- My earlier comment was more to clarify

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627375#comment-14627375 ] Joel Koshy commented on KAFKA-1835: --- bq. I think case (3) is only for users who

[jira] [Updated] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-1901: -- Reviewer: Joel Koshy > Move Kafka version to be generated in code by build (instead of in manif

[jira] [Commented] (KAFKA-1835) Kafka new producer needs options to make blocking behavior explicit

[ https://issues.apache.org/jira/browse/KAFKA-1835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14627190#comment-14627190 ] Joel Koshy commented on KAFKA-1835: --- bq. Similar proposal applies to KAFKA-2275 h

Re: Review Request 35867: Patch for KAFKA-1901

> On June 25, 2015, 7:01 p.m., Joel Koshy wrote: > > build.gradle, line 386 > > <https://reviews.apache.org/r/35867/diff/1/?file=991942#file991942line386> > > > > I was originally interested in this because it would be a quick way to > > determine

Re: Review Request 35867: Patch for KAFKA-1901

which is weird. The server will also expose app-info via the clients package since it already uses kafka metrics and the associated jmx reporter. - Joel Koshy On July 10, 2015, 11:15 a.m., Manikumar Reddy O wrote: > > --- &g

Re: [Discussion] Limitations on topic names

One way to get around this conflict could be to replace . with _ and _ with __ On Sat, Jul 11, 2015 at 10:33 AM, Todd Palino wrote: > I tend to agree with this as a compromise at this point. The reality is that > this is technical debt that has built up in the project, and it does not go > away

Re: [Discussion] Limitations on topic names

This did come up in the discussion in KAFKA-1902. It is somewhat concerning that something very specific - in this case (what I think is a limitation [1]) in certain metric reporters should drive the decision on what constitutes a legal topic name in Kafka - especially when all the characters in qu

[jira] [Commented] (KAFKA-2275) Add a ListTopics() API to the new consumer

[ https://issues.apache.org/jira/browse/KAFKA-2275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14625095#comment-14625095 ] Joel Koshy commented on KAFKA-2275: --- [~onurkaraman] has also been doing some thin

Re: Review Request 33378: Patch for KAFKA-2136

> On June 25, 2015, 10:55 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 40 > > <https://reviews.apache.org/r/33378/diff/8/?file=981582#file981582line40> > > > > I think we should add throttle time metrics to t

Re: Review Request 33378: Patch for KAFKA-2136

KAFKA-2136 just add a config to enable/disable quotas altogether. core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala (line 81) <https://reviews.apache.org/r/33378/#comment144658> delayTime: Int - Joel Koshy On July 1, 2015, 2:44 a.m., Aditya Auradkar wrote: > > ---

Re: Review Request 34965: Patch for KAFKA-2241

> On July 9, 2015, 7:19 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 76 > > <https://reviews.apache.org/r/34965/diff/2/?file=977751#file977751line76> > > > > You could get around the above by retaining this

[jira] [Commented] (KAFKA-1901) Move Kafka version to be generated in code by build (instead of in manifest)

[ https://issues.apache.org/jira/browse/KAFKA-1901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622332#comment-14622332 ] Joel Koshy commented on KAFKA-1901: --- Will review today. > Move Kafka versio

Re: Review Request 34965: Patch for KAFKA-2241

> On July 9, 2015, 7:19 p.m., Joel Koshy wrote: > > core/src/main/scala/kafka/server/AbstractFetcherThread.scala, line 76 > > <https://reviews.apache.org/r/34965/diff/2/?file=977751#file977751line76> > > > > You could get around the above by retaining this

[jira] [Updated] (KAFKA-2241) AbstractFetcherThread.shutdown() should not block on ReadableByteChannel.read(buffer)

[ https://issues.apache.org/jira/browse/KAFKA-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-2241: -- Status: In Progress (was: Patch Available) > AbstractFetcherThread.shutdown() should not block

Re: Review Request 34965: Patch for KAFKA-2241

(although it would be mostly redundant). However this is still not ideal, since it is a caveat that the user of the (public) forceClose API needs to be aware of. - Joel Koshy On June 3, 2015, 10:30 p.m., Dong Lin wrote: > > --

[jira] [Updated] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-2298: -- Resolution: Fixed Status: Resolved (was: Patch Available) > Client Selector can d

Build failed in Jenkins: KafkaPreCommit #142

Agreed that we should change it to exclude build/** - however, build 142 failure does not seem to be rat-related is it? E.g., compare the console output with an earlier build (138 I think). Sorry I can't verify/debug right now, but can look tomorrow. On Wednesday, July 8, 2015, Ewen Cheslack-Posta

Re: Build failed in Jenkins: KafkaPreCommit #138

> explicitly specify an exclude for build/rat/rat-report.xml (btw, I went ahead with a trivial commit for the above - let me know if there are any concerns) On Tue, Jul 07, 2015 at 09:44:27PM -0700, Joel Koshy wrote: > You can reproduce the rat failure by running: ./gradlew clean &&

Re: Build failed in Jenkins: KafkaPreCommit #138

You can reproduce the rat failure by running: ./gradlew clean && gradlew test If you run gradlew test again it does not report any error. build.gradle uses Grgit to expand the gitignore files to exclude. For a clean build, the build directory does not exist (yet). So it is not excluded by rat.

Re: Review Request 35791: Patch for KAFKA-2298

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35791/#review90847 --- Ship it! Ship It! - Joel Koshy On June 24, 2015, 8 p.m., Dong

Re: [ANNOUNCE] New Committer

Congrats Gwen! On Mon, Jul 06, 2015 at 06:08:11PM -0700, Joe Stein wrote: > I am pleased to announce that the Apache Kafka PMC has voted to invite Gwen > Shapira as a committer and Gwen has accepted. > > Please join me on welcoming and congratulating Gwen. > > Thanks for the contribution both in

[jira] [Commented] (KAFKA-2310) Add config to prevent broker becoming controller

[ https://issues.apache.org/jira/browse/KAFKA-2310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14615922#comment-14615922 ] Joel Koshy commented on KAFKA-2310: --- Is this a dup of KAFKA-1778? h

[jira] [Updated] (KAFKA-2298) Client Selector can drop connections on InvalidReceiveException without notifying NetworkClient

[ https://issues.apache.org/jira/browse/KAFKA-2298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joel Koshy updated KAFKA-2298: -- Reviewer: Joel Koshy > Client Selector can drop connections on InvalidReceiveException with

[jira] [Created] (KAFKA-2309) ISR shrink rate not updated on LeaderAndIsr request with shrunk ISR

Joel Koshy created KAFKA-2309: - Summary: ISR shrink rate not updated on LeaderAndIsr request with shrunk ISR Key: KAFKA-2309 URL: https://issues.apache.org/jira/browse/KAFKA-2309 Project: Kafka

Re: EOL JDK 1.6 for Kafka

+1 On Wednesday, July 1, 2015, Harsha wrote: > Hi, > During our SSL Patch KAFKA-1690. Some of the reviewers/users > asked for support this config > > https://docs.oracle.com/javase/8/docs/api/javax/net/ssl/SSLParameters.html#setEndpointIdentificationAlgorithm-java.lang.String- >

Re: Review Request 33620: Patch for KAFKA-1690

nticator) is a bit misleading? For SSL, the actual authentication takes place in the transport layer (in the SSL handshake). So plain SSL would use the default authenticator and we need to extract the principal from the transport layer. We can discuss this today. - Joel Koshy On June

Re: Review Request 33378: Patch for KAFKA-2136

read.scala (line 40) <https://reviews.apache.org/r/33378/#comment142072> I think we should add throttle time metrics to the old producer and consumer as well. What do you think? - Joel Koshy On June 9, 2015, 5:10 p.m., Aditya Auradkar wrote: > > --

Re: Incomplete Messages

Yes that is a bit of a caveat in using zero-copy when sending FetchResponses. i.e., the broker cannot introspect the message-set and lop off any trailing piece. I think this is just something that needs to be documented clearly on that wiki. So there is some overhead for the client implementation i

<    1   2   3   4   5   6   7   8   9   10   >