[jira] [Created] (KAFKA-8592) Broker Dynamic Configuration fails to resolve variables as per KIP-421

2019-06-24 Thread TEJAL ADSUL (JIRA)
TEJAL ADSUL created KAFKA-8592: -- Summary: Broker Dynamic Configuration fails to resolve variables as per KIP-421 Key: KAFKA-8592 URL: https://issues.apache.org/jira/browse/KAFKA-8592 Project: Kafka

[jira] [Created] (KAFKA-8426) KIP 421 Bug: ConfigProvider configs param inconsistent with KIP-297

2019-05-24 Thread TEJAL ADSUL (JIRA)
TEJAL ADSUL created KAFKA-8426: -- Summary: KIP 421 Bug: ConfigProvider configs param inconsistent with KIP-297 Key: KAFKA-8426 URL: https://issues.apache.org/jira/browse/KAFKA-8426 Project: Kafka

[jira] [Created] (KAFKA-8425) KIP 421 Bug: Modifying Immutable Originals Map results in Java exception

2019-05-24 Thread TEJAL ADSUL (JIRA)
TEJAL ADSUL created KAFKA-8425: -- Summary: KIP 421 Bug: Modifying Immutable Originals Map results in Java exception Key: KAFKA-8425 URL: https://issues.apache.org/jira/browse/KAFKA-8425 Project: Kafka

Re: [VOTE] KIP-421: Automatically resolve external configurations.

2019-04-24 Thread TEJAL ADSUL
Thanks Dongjin for taking time to review the KIP and vote Thanks, Tejal On 2019/04/24 01:19:36, Dongjin Lee wrote: > @Colin I see. Thanks for the correction! > @Tejal Thanks for the excellent proposal! +1k! > > Thanks, > Dongjin > > On Mon, Apr 22, 2019 at 10:26 P

Re: [VOTE] KIP-421: Automatically resolve external configurations.

2019-04-22 Thread TEJAL ADSUL
Hi all, This KIP passes with three +1 (binding) - thanks Colin, Randall and Gwen! For those interested, feel free to check out and join the ongoing PR review here: https://github.com/apache/kafka/pull/6467 Thanks, Tejal On 2019/04/22 17:26:05, TEJAL ADSUL wrote: > Hi Folks, > &g

Re: [VOTE] KIP-421: Automatically resolve external configurations.

2019-04-22 Thread TEJAL ADSUL
Hi Folks, Just a reminder that I will be closing the vote for KIP-421 by today EOD, please cast your votes by today. Thanks Colin, Randall, Gwen for the votes. Thanks, Tejal On 2019/04/19 22:43:25, "Colin McCabe" wrote: > +1. Thanks, Tejal. > > best, > Colin >

[VOTE] KIP-421: Automatically resolve external configurations.

2019-04-18 Thread TEJAL ADSUL
/a2f834d876e9f8fb3977db794bf161818c97f7f481edd1b10449d89f@%3Cdev.kafka.apache.org%3E Thanks, Tejal

Re: [DISCUSSION] KIP-421: Automatically resolve external configurations.

2019-04-17 Thread TEJAL ADSUL
ture so it dint add anything. Please could you'll review the KIP and let me know if it has addressed your concerns and any other feedback. Thanks, Tejal On 2019/04/17 23:34:37, TEJAL ADSUL wrote: > > Thanks for the feedback Colin. And agree we should enable it for all the > compo

Re: [DISCUSSION] KIP-421: Automatically resolve external configurations.

2019-04-17 Thread TEJAL ADSUL
Thanks for the feedback Colin. And agree we should enable it for all the components as this feature is going to benefit all the components and not just Connect. I have updated the KIP to enable it for all the components. Thanks, Tejal On 2019/04/17 23:22:50, "Colin McCabe" wrote:

Re: [DISCUSSION] KIP-421: Automatically resolve external configurations.

2019-04-17 Thread TEJAL ADSUL
Thanks for the feedback Randall. I have incorporated the below changes in the KIP. Thanks, Tejal On 2019/04/17 15:42:31, Randall Hauch wrote: > Overall this looks good. A few specific requests to hopefully improve the > clarity of the proposal: > > 1) The motivation section

Re: [DISCUSSION] KIP-421: Automatically resolve external configurations.

2019-04-17 Thread TEJAL ADSUL
y the user using the Admin Client. For static configs we dont perform any reloading and happens only at the construction time. Thanks, Tejal On 2019/04/17 14:36:33, TEJAL ADSUL wrote: > Hi Rajini, > > The user wont have the ability to choose whether config value should be > enab

Re: [DISCUSSION] KIP-421: Automatically resolve external configurations.

2019-04-17 Thread TEJAL ADSUL
Hi Rajini, The user wont have the ability to choose whether config value should be enabled/disabled. Its enable/disabled per component by hardcoding the value. I have documented your recommendations in the compatibility sections. Thanks, Tejal

Re: [DISCUSSION] KIP-421: Automatically resolve external configurations.

2019-04-15 Thread Tejal Adsul
Hi All, I have updated the KIP to address the comments in the discussion. I have added the flow as to how dynamic config values will be resolved. Please could you’ll review the updated changes and let me know your feedback. Thanks, Tejal On 2019/03/21 20:38:54, Tejal Adsul wrote: > I h

[DISCUSS] KIP-421: Automatically resolve external configurations.

2019-04-15 Thread TEJAL ADSUL
Hi All, I have updated the KIP to address the comments in the discussion. I have added the flow as to how dynamic config values will be resolved. Please could you’ll review the updated changes and let me know your feedback. Thanks, Tejal On 2019/03/21 20:36:24, Tejal Adsul wrote: > @Co

[Vote] KIP-421: Support resolving externalized secrets in AbstractConfig

2019-03-21 Thread TEJAL ADSUL
Hi All, I would like to start the vote thread for KIP-421: Support resolving externalized secrets in AbstractConfig. https://cwiki.apache.org/confluence/display/KAFKA/KIP-421%3A+Support+resolving+externalized+secrets+in+AbstractConfig Thanks! Regards, Tejal

Re: [DISCUSSION] KIP-421: Support resolving externalized secrets in AbstractConfig

2019-03-21 Thread Tejal Adsul
, ConsumerConfig, ConnectorConfig etc.) will> >be extended to optionally use the new AbstractConfig constructors?> On 2019/03/14 11:49:46, Rajini Sivaram wrote: > Hi Tejal,> > > Thanks for the updates. A few comments:> > > >1. In the standard KIP templ

Re: [DISCUSSION] KIP-421: Support resolving externalized secrets in AbstractConfig

2019-03-21 Thread Tejal Adsul
by using the enable flag. We won’t be using this in broker as its dynamic and we have added it in future section for now. On 2019/03/14 16:36:42, "Colin McCabe" wrote: > Hi Tejal,> > > Thanks for the update.> > > One of the critical parts of the ConfigProvi

Re: [DISCUSSION] KIP-421: Support resolving externalized secrets in AbstractConfig

2019-03-11 Thread Tejal Adsul
Hi Folks, I have accommodated most of the review comments for https://cwiki.apache.org/confluence/display/KAFKA/KIP-421%3A+Support+resolving+externalized+secrets+in+AbstractConfig . Reopening the thread for further discussion. Please let me know your thoughts on it. Thanks, Tejal On 2019/01

Re: [VOTE] KIP-421: Support resolving externalized secrets in AbstractConfig

2019-01-24 Thread TEJAL ADSUL
On 2019/01/24 18:54:13, Rajini Sivaram wrote: > Hi Tejal, > > Thanks for the KIP. I have a couple of comments/questions. > > It sounds like we are addressing password protection for clients, Connect > etc., but not for brokers, even though the changes proposed are in c

Re: [VOTE] KIP-421: Support resolving externalized secrets in AbstractConfig

2019-01-24 Thread TEJAL ADSUL
> > > > On Tue, 22 Jan 2019 at 17:38, te...@confluent.io wrote: > > > Hi all, > > > > We would like to start vote on KIP-421 to to enhance the AbstractConfig > > base class to support replacing variables in configurations just prior to > > parsing and val

Re: [VOTE] KIP-421: Support resolving externalized secrets in AbstractConfig

2019-01-23 Thread TEJAL ADSUL
will be snapshot of what the configuration key was when the constructor was invoked. Thanks, Tejal On 2019/01/23 22:09:02, "Colin McCabe" wrote: > Hi Tejal, > > Looks good overall. > > Can you please add this KIP to the wiki page at > https://cwiki.apache.org/co

[VOTE] KIP-421: Support resolving externalized secrets in AbstractConfig

2019-01-22 Thread tejal
+secrets+in+AbstractConfig Thanks, Tejal

[jira] [Created] (KAFKA-7847) KIP-421: Support resolving externalized secrets in AbstractConfig

2019-01-20 Thread TEJAL ADSUL (JIRA)
TEJAL ADSUL created KAFKA-7847: -- Summary: KIP-421: Support resolving externalized secrets in AbstractConfig Key: KAFKA-7847 URL: https://issues.apache.org/jira/browse/KAFKA-7847 Project: Kafka

[jira] [Created] (KAFKA-7846) KIP-421: Support resolving externalized secrets in AbstractConfig

2019-01-20 Thread TEJAL ADSUL (JIRA)
TEJAL ADSUL created KAFKA-7846: -- Summary: KIP-421: Support resolving externalized secrets in AbstractConfig Key: KAFKA-7846 URL: https://issues.apache.org/jira/browse/KAFKA-7846 Project: Kafka

[DISCUSS] KIP-421: Support resolving externalized secrets in AbstractConfig

2019-01-20 Thread tejal
configurations. Please let me know your insightful feedback. Regards, Tejal

Permissions to create KIP

2019-01-20 Thread Tejal Adsul
Hi, I work at Confluent. Please could you grant me permission to create a KIP for apache kafka, I wanted to propose a change to AbstractConfig in Kafka. Following are my details Full NameTEJAL ADSUL emailte...@confluent.io ID: tejal Thanks, Tejal