[GitHub] kafka pull request #4330: [WIP] KAFKA-6359: KIP-236 interruptible reassignme...

2017-12-15 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/4330 [WIP] KAFKA-6359: KIP-236 interruptible reassignments This is a WIP for KIP-236. All the existing tests (via the `/admin/reassign_partitions` path) still pass, and I've added a couple of tests

[GitHub] kafka pull request #4274: KAFKA-6283: Configuration of custom SCRAM SaslServ...

2017-12-11 Thread tombentley
Github user tombentley closed the pull request at: https://github.com/apache/kafka/pull/4274 ---

[GitHub] kafka pull request #4281: [WIP] KAFKA-5693 rationalise policy interfaces

2017-12-01 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/4281 [WIP] KAFKA-5693 rationalise policy interfaces As described in KIP-201 (not yet accepted), this: * deprecates the CreateTopicPolicy and AlterConfigPolicy * adds a new

[GitHub] kafka pull request #4274: KAFKA-6283: Configuration of custom SCRAM SaslServ...

2017-11-29 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/4274 KAFKA-6283: Configuration of custom SCRAM SaslServer implementations Pass the jaasContext to the ScramServerCallbackHandler, so that custom implementations of a SCRAM SaslServer have access

[GitHub] kafka pull request #4157: KAFKA-6130: VerifiableConsumer with --max-messages

2017-10-30 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/4157 KAFKA-6130: VerifiableConsumer with --max-messages @hachikuji can you review this? Do you know the best place to write a test, since there doesn't seem to be a unit test

[GitHub] kafka-site pull request #99: Rephrase mailing lists section to avoid incorre...

2017-10-18 Thread tombentley
Github user tombentley commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/99#discussion_r145345640 --- Diff: contact.html --- @@ -11,16 +11,16 @@ - us

[GitHub] kafka-site pull request #99: Rephrase mailing lists section to avoid incorre...

2017-10-18 Thread tombentley
Github user tombentley commented on a diff in the pull request: https://github.com/apache/kafka-site/pull/99#discussion_r145344978 --- Diff: contact.html --- @@ -11,16 +11,16 @@ - us

[GitHub] kafka pull request #4065: MINOR: Use OS-assigned port, in case 9092 is alrea...

2017-10-12 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/4065 MINOR: Use OS-assigned port, in case 9092 is already bound I found this by running the tests while I happened to have a kafka broker running. @mjsax please could you review? You can

[GitHub] kafka pull request #4008: MINOR: Add / to connect docs, because HTML ...

2017-10-03 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/4008 MINOR: Add / to connect docs, because HTML render doesn't respect blank lines This just adds / to paragraphs in Kafak Connect docs. @ewencp are you a good person to review this? You

[GitHub] kafka pull request #3972: *WIP* MINOR: Add documentation about each of the m...

2017-09-27 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3972 *WIP* MINOR: Add documentation about each of the messages in the protocol Following recent refactoring of `Protocol` I suggested to add documentation for the messages to explain the purpose

[GitHub] kafka pull request #3937: KAFKA-5856 AdminClient.createPartitions() follow u...

2017-09-21 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3937 KAFKA-5856 AdminClient.createPartitions() follow up Adds support for noop requests. When assignments are given with a request that would be a noop we validate that the given assignments match

[GitHub] kafka pull request #3909: MINOR: Consistent terminal period in Errors.defaul...

2017-09-19 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3909 MINOR: Consistent terminal period in Errors.defaultExceptionMessage Some default messages ended with a period and some didn't, so make things consistent. The contribution is my original

[GitHub] kafka pull request #3870: KAFKA-5856: Add AdminClient.createPartitions()

2017-09-15 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3870 KAFKA-5856: Add AdminClient.createPartitions() See KIP-195. The contribution is my original work and I license the work to the project under the project's open source license

[GitHub] kafka pull request #3848: KAFKA-5692: Change PreferredReplicaLeaderElectionC...

2017-09-13 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3848 KAFKA-5692: Change PreferredReplicaLeaderElectionCommand to use Admin… …Client See also KIP-183. The contribution is my original work and I license the work to the project

[GitHub] kafka pull request #3482: MINOR: Make topic config a section, with TOC entry...

2017-07-05 Thread tombentley
Github user tombentley closed the pull request at: https://github.com/apache/kafka/pull/3482 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] kafka pull request #3486: KAFKA-5554 doc config common

2017-07-04 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3486 KAFKA-5554 doc config common This is more a request for review than it is a request to merge, as I don't think this is complete yet. However, this illustrates the idea of drawing attention

[GitHub] kafka pull request #3482: MINOR: Make topic config a section, with TOC entry...

2017-07-04 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3482 MINOR: Make topic config a section, with TOC entry. You can merge this pull request into a Git repository by running: $ git pull https://github.com/tombentley/kafka minor-doc-topic-config

[GitHub] kafka pull request #3480: MINOR: Define the term tombstone, since it's used ...

2017-07-03 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3480 MINOR: Define the term tombstone, since it's used elsewhere in the docs You can merge this pull request into a Git repository by running: $ git pull https://github.com/tombentley/kafka

[GitHub] kafka pull request #3436: KAFKA-5517: Add id to config HTML tables to allow ...

2017-06-26 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3436 KAFKA-5517: Add id to config HTML tables to allow linking You can merge this pull request into a Git repository by running: $ git pull https://github.com/tombentley/kafka KAFKA-5517

[GitHub] kafka pull request #3407: KAFKA-3881: Remove the replacing logic from "." to...

2017-06-22 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3407 KAFKA-3881: Remove the replacing logic from "." to "_" in Fetcher You can merge this pull request into a Git repository by running: $ git pull https://github.com/to

[GitHub] kafka pull request #3396: KAFKA-4931: stop script fails due 4096 ps output l...

2017-06-21 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3396 KAFKA-4931: stop script fails due 4096 ps output limit This also fixes KAFKA-4389 and KAFKA-4297, which were exactly the same issue but for kafka-server-stop.sh. You can merge this pull

[GitHub] kafka pull request #3395: KAFKA-3575: Use console consumer access topic that...

2017-06-21 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3395 KAFKA-3575: Use console consumer access topic that does not exist, ca… …n not use "Control + C" to exit process A finally block is not guaranteed to execute in the event

[GitHub] kafka pull request #3386: KAFKA-4249: Document how to customize GC logging o...

2017-06-20 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3386 KAFKA-4249: Document how to customize GC logging options for broker Document the KAFKA_GC_LOG_OPTS environment variable as well as the common `kafka-run-class.sh` options

[GitHub] kafka pull request #3385: KAFKA-4059: Documentation still refers to AsyncPro...

2017-06-20 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3385 KAFKA-4059: Documentation still refers to AsyncProducer and SyncProducer Also remove old code snippet which bears little resemblance to the current Producer API. The contribution

[GitHub] kafka pull request #3382: KAFKA-4260: Check for nonroutable address in adver...

2017-06-20 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3382 KAFKA-4260: Check for nonroutable address in advertised.listeners As described in KAFKA-4260, when `listeners=PLAINTEXT://0.0.0.0:9092` (note the 0.0.0.0 "bind all interfaces"

[GitHub] kafka pull request #3381: KAFKA-5479: Tidy up Authorization section of Secur...

2017-06-20 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3381 KAFKA-5479: Tidy up Authorization section of Security docs * Mention the authz is disabled by default and enabled via authorizer.class.name * ACL is an initialism, so spell it ACL not acl

[GitHub] kafka pull request #3369: KAFKA-5479: Improve the documentation around ACLs

2017-06-20 Thread tombentley
Github user tombentley closed the pull request at: https://github.com/apache/kafka/pull/3369 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] kafka pull request #3369: Improve the documentation around ACLs

2017-06-19 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3369 Improve the documentation around ACLs You can merge this pull request into a Git repository by running: $ git pull https://github.com/tombentley/kafka doc-acl Alternatively you can review

[GitHub] kafka pull request #3351: MINOR: Add --help to DumpLogSegments

2017-06-15 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3351 MINOR: Add --help to DumpLogSegments You can merge this pull request into a Git repository by running: $ git pull https://github.com/tombentley/kafka help Alternatively you can review

[GitHub] kafka pull request #3280: Avoid calling interceptors.onSendError() with null...

2017-06-09 Thread tombentley
GitHub user tombentley opened a pull request: https://github.com/apache/kafka/pull/3280 Avoid calling interceptors.onSendError() with null TopicPartition Assign non-null tp as soon as possible once we know the partition. This is so that if ensureValidRecordSize() throws