Re: [DISCUSS] Add TaskId field to StreamsException

2021-10-18 Thread Sophie Blee-Goldman
Ah, thanks. I've updated the KIP On Mon, Oct 18, 2021 at 3:36 PM Matthias J. Sax wrote: > Sophie, > > I think we also need to pass in a `TaskId` into the constructor, which > are also part of the public API. > > Otherwise LGTM. > > -Matthias > > On 10/17/21 9:03 PM, Sophie Blee-Goldman wrote: >

Re: [DISCUSS] Add TaskId field to StreamsException

2021-10-18 Thread Matthias J. Sax
Sophie, I think we also need to pass in a `TaskId` into the constructor, which are also part of the public API. Otherwise LGTM. -Matthias On 10/17/21 9:03 PM, Sophie Blee-Goldman wrote: Hey all, I'd like to propose a very small KIP to add a TaskId field to the StreamsException class. I wil

[DISCUSS] Add TaskId field to StreamsException

2021-10-17 Thread Sophie Blee-Goldman
Hey all, I'd like to propose a very small KIP to add a TaskId field to the StreamsException class. I will be kicking off the voting thread soon, but please review the KIP and let me know if you have any questions or concerns. Links: - KIP-783: Add TaskId field to StreamsException