Re: [DISCUSS] KIP-131 : Add access to OffsetStorageReader from SourceConnector

2017-09-05 Thread Randall Hauch
Thanks for taking into account my suggestions/concerns. I had a few very minor suggestions on the PR regarding documentation, but overall everything looks great to me. I'd encourage anyone else to review https://cwiki.apache.org/confluence/display/KAFKA/KIP-131+-+Add+access+to+OffsetStorageReader+

Re: [DISCUSS] KIP-131 : Add access to OffsetStorageReader from SourceConnector

2017-08-24 Thread Florian Hussonnois
Hi Randall, Thank you for your answer. I will update the KIP and the PR with your last approach which sounds better. Thanks. Le 16 août 2017 00:53, "Randall Hauch" a écrit : Sorry it's taken me so long to come back to this. Have you considered creating a `SourceConnectorContext` interface th

Re: [DISCUSS] KIP-131 : Add access to OffsetStorageReader from SourceConnector

2017-08-15 Thread Randall Hauch
Sorry it's taken me so long to come back to this. Have you considered creating a `SourceConnectorContext` interface that extends `ConnectorContext` and that adds the method to access the offset storage? This would very closely match the existing `SourceTaskContext`. `SourceConnector` implementati

Re: [DISCUSS] KIP-131 : Add access to OffsetStorageReader from SourceConnector

2017-04-05 Thread Florian Hussonnois
Hi All, Is there any feedback regarding that KIP ? https://cwiki.apache.org/confluence/display/KAFKA/KIP-131+-+Add+access+to+OffsetStorageReader+from+SourceConnector Thanks, 2017-03-14 22:51 GMT+01:00 Florian Hussonnois : > Hi Matthias, > > Sorry I didn't know this page. Ths KIP has been added

Re: [DISCUSS] KIP-131 : Add access to OffsetStorageReader from SourceConnector

2017-03-14 Thread Florian Hussonnois
Hi Matthias, Sorry I didn't know this page. Ths KIP has been added to it. Thanks, 2017-03-13 21:30 GMT+01:00 Matthias J. Sax : > Can you please add the KIP to this table: > > https://cwiki.apache.org/confluence/display/KAFKA/ > Kafka+Improvement+Proposals#KafkaImprovementProposals-KIPsunderdisc

Re: [DISCUSS] KIP-131 : Add access to OffsetStorageReader from SourceConnector

2017-03-13 Thread Matthias J. Sax
Can you please add the KIP to this table: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals#KafkaImprovementProposals-KIPsunderdiscussion Thanks, Matthias On 3/7/17 1:24 PM, Florian Hussonnois wrote: > Hi all, > > I've created a new KIP to add access to OffsetStor

[DISCUSS] KIP-131 : Add access to OffsetStorageReader from SourceConnector

2017-03-07 Thread Florian Hussonnois
Hi all, I've created a new KIP to add access to OffsetStorageReader from SourceConnector https://cwiki.apache.org/confluence/display/KAFKA/KIP-131+-+Add+access+to+OffsetStorageReader+from+SourceConnector Thanks. -- Florian HUSSONNOIS