Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API

Thanks, Manikumar. Sounds good. best, Colin On Mon, Aug 6, 2018, at 08:57, Manikumar wrote: > Hi All, > > For this KIP, I will be using "--command-config" option name to specify > config file. > We can handle the naming discrepancies as part of KIP-14. > > Thanks, > > > > > > On Sat, Aug

Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API

Hi All, For this KIP, I will be using "--command-config" option name to specify config file. We can handle the naming discrepancies as part of KIP-14. Thanks, On Sat, Aug 4, 2018 at 4:53 AM Jason Gustafson wrote: > Here's hoping someone has time to pick up KIP-14 again: > >

Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API

Here's hoping someone has time to pick up KIP-14 again: https://cwiki.apache.org/confluence/display/KAFKA/KIP-14+-+Tools+Standardization. The inconsistencies are so irritating. -Jason On Fri, Aug 3, 2018 at 10:27 AM, Rajini Sivaram wrote: > Hi Dong, > > I don't have a preference for the option

Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API

Hi Dong, I don't have a preference for the option itself, but we are using " --command-config" in ConfigCommand, ConsumerGroupCommand, BrokerApiVersionsCommand, DeleteRecordsCommand. So it feels like we should use the same here. I think we are currently only using "--config-file" StreamsResetter.

Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API

Hey Rajini, Manikumar, Currently kafka-streams-application-reset.sh uses "--config-file" and a few other tools uses "--command-config". So the config name will be inconsistent no matter which config name we choose. Not sure we currently distinquish between core commands and non-core commands. I

Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API

Updated the KIP. added a note to KIP-340 discussion thread. On Fri, Aug 3, 2018 at 2:52 PM Rajini Sivaram wrote: > Thanks Manikumar. Can you add a note to the KIP-340 discussion thread? > > On Fri, Aug 3, 2018 at 10:04 AM, Manikumar > wrote: > > > Hi Rajini, > > > > Yes, I too prefer using

Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API

Thanks Manikumar. Can you add a note to the KIP-340 discussion thread? On Fri, Aug 3, 2018 at 10:04 AM, Manikumar wrote: > Hi Rajini, > > Yes, I too prefer using "--command-config" . Recently in one of the other > KIPs (KIP-340), it was suggested to use > "--config-file", So I just followed

Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API

Hi Rajini, Yes, I too prefer using "--command-config" . Recently in one of the other KIPs (KIP-340), it was suggested to use "--config-file", So I just followed the recent suggestion. But I think we should use same name in all tools (at least in core tools). If there are no concerns, I will

Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API

Hi Manikumar, We have some tools already (ConfigCommand, ConsumerGroupCommand, DelegationTokenCommand) which use "--command-config" option to specify config file. Perhaps use should use the same name for AclCommand as well? On Thu, Aug 2, 2018 at 7:23 PM, Colin McCabe wrote: > +1 for starting

Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API

+1 for starting the vote cheers, Colin On Wed, Aug 1, 2018, at 08:46, Manikumar wrote: > Hi all, > > If there are no concerns, I will start the voting process soon. > > Thanks > > On Tue, Jul 31, 2018 at 9:08 AM Manikumar wrote: > > > Hi Colin, > > > > Yes, "--authorizer-properties"

Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API

Hi all, If there are no concerns, I will start the voting process soon. Thanks On Tue, Jul 31, 2018 at 9:08 AM Manikumar wrote: > Hi Colin, > > Yes, "--authorizer-properties" option is not required with > "--bootstrap-server" option. Updated the KIP. > > > Thanks, > > On Tue, Jul 31, 2018 at

Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API

Hi Colin, Yes, "--authorizer-properties" option is not required with "--bootstrap-server" option. Updated the KIP. Thanks, On Tue, Jul 31, 2018 at 1:30 AM Ted Yu wrote: > Look good to me. > > On Mon, Jul 23, 2018 at 7:30 AM Manikumar > wrote: > > > Hi all, > > > > I have created a KIP to

Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API

Look good to me. On Mon, Jul 23, 2018 at 7:30 AM Manikumar wrote: > Hi all, > > I have created a KIP to use AdminClient API in AclCommand (kafka-acls.sh) > > * > https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API* > < >

Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API

Hi Manikumar, It's great that you are taking a look at this! Much needed. Just one note: I assume that --authorizer-properties is no longer required if the --bootstrap-server option is specified. We should probably spell this out somewhere in the KIP. thanks, Colin On Mon, Jul 30, 2018,

Re: [DISCUSS] KIP-332: Update AclCommand to use AdminClient API

Bumping this up! On Mon, Jul 23, 2018 at 8:00 PM Manikumar wrote: > Hi all, > > I have created a KIP to use AdminClient API in AclCommand (kafka-acls.sh) > > > *https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API* > >

[DISCUSS] KIP-332: Update AclCommand to use AdminClient API

Hi all, I have created a KIP to use AdminClient API in AclCommand (kafka-acls.sh) *https://cwiki.apache.org/confluence/display/KAFKA/KIP-332%3A+Update+AclCommand+to+use+AdminClient+API*