Re: [DISCUSS] KIP-474: To deprecate WindowStore#put(key, value)

2019-06-03 Thread Guozhang Wang
I've made a pass on the KIP and it looks good to me as well. I think we can start a voting thread for it. On Thu, May 30, 2019 at 10:27 PM Matthias J. Sax wrote: > Thanks for the KIP Omkar. > > I think this is rather uncontroversial, and I also support this KIP. I > think you can start a VOTE.

Re: [DISCUSS] KIP-474: To deprecate WindowStore#put(key, value)

2019-05-30 Thread Matthias J. Sax
Thanks for the KIP Omkar. I think this is rather uncontroversial, and I also support this KIP. I think you can start a VOTE. People can still chime in on the discuss thread if they have any concerns. -Matthias On 5/27/19 11:50 PM, Dongjin Lee wrote: > Hi Omkar, > > Looks good to me. Thanks! >

Re: [DISCUSS] KIP-474: To deprecate WindowStore#put(key, value)

2019-05-28 Thread Dongjin Lee
Hi Omkar, Looks good to me. Thanks! Is there anyone who has some comments about the KIP? Thanks, Dongjin On Tue, May 28, 2019 at 3:24 PM omkar mestry wrote: > Hi Dongjin, > > I have updated the KIP please have a look and provide feedback on it. > > KIP :- >

Re: [DISCUSS] KIP-474: To deprecate WindowStore#put(key, value)

2019-05-28 Thread omkar mestry
Hi Dongjin, I have updated the KIP please have a look and provide feedback on it. KIP :- https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526545 Thanks & Regards Omkar Mestry On Mon, May 27, 2019 at 6:25 PM Dongjin Lee wrote: > Hi Omkar, > > Thanks for the KIP. However,

Re: [DISCUSS] KIP-474: To deprecate WindowStore#put(key, value)

2019-05-27 Thread Dongjin Lee
Hi Omkar, Thanks for the KIP. However, discussion thread should include a link to the KIP document. Since you omitted it, here is the link. https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526545 As far as I understand, the point of the KIP is the current API can result in

[DISCUSS] KIP-474: To deprecate WindowStore#put(key, value)

2019-05-26 Thread omkar mestry
We propose to deprecate the WindowStore#put(key, value), as it does not have a timestamp as a parameter. The window store requires a timestamp to map the key to a window frame. This method uses the current record timestamp(as specified in the description of the method). There is a method present