Re: [DISCUSS] KIP-475: New Metric to Measure Number of Tasks on a Connector

2019-06-04 Thread Cyrus Vafadari
Thanks, everyone, for the feedback. It looks like there's support, so I'll open the voting thread. Cyrus On Tue, Jun 4, 2019 at 9:02 PM Randall Hauch wrote: > Sorry that I was not clear. Yes, I was suggesting the state-specific counts > were in addition to the simple task count you originally

Re: [DISCUSS] KIP-475: New Metric to Measure Number of Tasks on a Connector

2019-06-04 Thread Randall Hauch
Sorry that I was not clear. Yes, I was suggesting the state-specific counts were in addition to the simple task count you originally proposed. Thanks for taking my suggestion into account -- the updated KIP looks great. Thanks for contributing this improvement, Cyrus! Best regards, Randall On

Re: [DISCUSS] KIP-475: New Metric to Measure Number of Tasks on a Connector

2019-06-04 Thread Cyrus Vafadari
Randall, I've updated the KIP to include all of your recommendations! Cyrus On Tue, Jun 4, 2019 at 2:55 PM Cyrus Vafadari wrote: > Randall, > > I plan to update the public details section and the performance impact as > you recommended. > > Regarding state-specific counts, I do agree this is

Re: [DISCUSS] KIP-475: New Metric to Measure Number of Tasks on a Connector

2019-06-04 Thread Cyrus Vafadari
Randall, I plan to update the public details section and the performance impact as you recommended. Regarding state-specific counts, I do agree this is a useful addition. Before I make the change, I'd like to agree that these state-specific counts should be in addition to the already-proposed

Re: [DISCUSS] KIP-475: New Metric to Measure Number of Tasks on a Connector

2019-06-04 Thread Randall Hauch
Thanks, Cyrus -- this will be quite useful. I do have a few comments/requests. Can you please be more specific about the public details about the metric? What is the MBean name on which the metric will appear? For example, the AK documentation

Re: [DISCUSS] KIP-475: New Metric to Measure Number of Tasks on a Connector

2019-06-02 Thread Ryanne Dolan
Cyrus, I agree this would be useful. Ryanne On Fri, May 31, 2019, 7:10 PM Oleksandr Diachenko wrote: > > > On 2019/05/30 06:06:12, Cyrus Vafadari wrote: > > Hello Dev, > > > > I'd like to start the discussion of KIP-475: New Metric to Measure Number > > of Tasks on a Connector. > > >

Re: [DISCUSS] KIP-475: New Metric to Measure Number of Tasks on a Connector

2019-05-31 Thread Oleksandr Diachenko
On 2019/05/30 06:06:12, Cyrus Vafadari wrote: > Hello Dev, > > I'd like to start the discussion of KIP-475: New Metric to Measure Number > of Tasks on a Connector. > https://cwiki.apache.org/confluence/display/KAFKA/KIP-475%3A+New+Metric+to+Measure+Number+of+Tasks+on+a+Connector > > The

[DISCUSS] KIP-475: New Metric to Measure Number of Tasks on a Connector

2019-05-30 Thread Cyrus Vafadari
Hello Dev, I'd like to start the discussion of KIP-475: New Metric to Measure Number of Tasks on a Connector. https://cwiki.apache.org/confluence/display/KAFKA/KIP-475%3A+New+Metric+to+Measure+Number+of+Tasks+on+a+Connector The proposal is pretty straightforward -- to add a new metric to Connect