Re: [DISCUSS] KIP-499 - Unify connection name flag for command line tool

2019-08-09 Thread Dongjin Lee
@Jason I see. Thanks for the context. @Colin Sure. I also agree limiting the scope of the KIP. Thanks, Dongjin On Fri, 9 Aug 2019 at 6:45 AM Colin McCabe wrote: > I agree that limiting the scope of the KIP would be good. > > The configuration is actually bootstrap.servers with an S, though. >

Re: [DISCUSS] KIP-499 - Unify connection name flag for command line tool

2019-08-08 Thread Colin McCabe
I agree that limiting the scope of the KIP would be good. The configuration is actually bootstrap.servers with an S, though. I actually like --bootstrap-servers slightly better than --bootstrap-server, although I don't feel that strongly about either. ;) best, Colin On Thu, Aug 8, 2019, at 14

Re: [DISCUSS] KIP-499 - Unify connection name flag for command line tool

2019-08-08 Thread Jason Gustafson
@Dongjin Thanks, you raise some good points. I think the intent here is to try and fix one of the more egregious inconsistencies without increasing the scope too much. We tried the big KIP approach with KIP-14 before and I don't think we made much progress. I think it's reasonable to do this on a c

Re: [DISCUSS] KIP-499 - Unify connection name flag for command line tool

2019-08-02 Thread Dongjin Lee
Hello Mitchel, Thanks for the KIP. Sure, This inconsistency is really annoying and causing lots of confusions. Here are some comments: First, there is already a Jira issue about this problem, created by Ismael. https://issues.apache.org/jira/browse/KAFKA-8507 I added the link to the KIP. Add to

Re: [DISCUSS] KIP-499 - Unify connection name flag for command line tool

2019-08-01 Thread Gwen Shapira
+1 for the KIP On Tue, Jul 30, 2019 at 5:25 PM Mitchell wrote: > > Hello, > I have written a proposal to add the command line argument > `--bootstrap-server` to 5 of the existing command line tools that do not > currently use `--broker-list` for passing cluster connection information. > > https:/

Re: [DISCUSS] KIP-499 - Unify connection name flag for command line tool

2019-08-01 Thread Harsha
+1 for the KIP. -Harsha On Thu, Aug 1, 2019, at 3:07 PM, Colin McCabe wrote: > On Wed, Jul 31, 2019, at 05:26, Mitchell wrote: > > Hi Jason, > > Thanks for looking at this! > > > > I wasn't exactly sure what to put in the compatibility section. I wrote > > the KIP thinking that we should probab

Re: [DISCUSS] KIP-499 - Unify connection name flag for command line tool

2019-08-01 Thread Colin McCabe
On Wed, Jul 31, 2019, at 05:26, Mitchell wrote: > Hi Jason, > Thanks for looking at this! > > I wasn't exactly sure what to put in the compatibility section. I wrote > the KIP thinking that we should probably mark the old arguments for > deprecation for a release or two before actually removing t

Re: [DISCUSS] KIP-499 - Unify connection name flag for command line tool

2019-07-31 Thread Mitchell
Hi Jason, Thanks for looking at this! I wasn't exactly sure what to put in the compatibility section. I wrote the KIP thinking that we should probably mark the old arguments for deprecation for a release or two before actually removing them. I'm happy to change this either way if it's preferred.

Re: [DISCUSS] KIP-499 - Unify connection name flag for command line tool

2019-07-30 Thread Jason Gustafson
Hey Mitch, thanks for the KIP! This command line inconsistency frustrates me almost every day. I'm definitely +1 on this. One minor nitpick. The compatibility section mentions there will be no deprecations, but it sounds like we are planning on deprecating the old arguments? Thanks, Jason On Tue

[DISCUSS] KIP-499 - Unify connection name flag for command line tool

2019-07-30 Thread Mitchell
Hello, I have written a proposal to add the command line argument `--bootstrap-server` to 5 of the existing command line tools that do not currently use `--broker-list` for passing cluster connection information. https://cwiki.apache.org/confluence/display/KAFKA/KIP-499+-+Unify+connection+name+fla