Re: [DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-20 Thread Bill Bejeck
Hi Kevin, I'm coming in a little late, but thanks for the KIP, this will be very useful. It's a +1 for me. -Bill On Fri, Sep 20, 2019 at 11:32 AM Kevin Lu wrote: > Hi Jason, > > That is a good point in making the ratio metric consistent with the broker > idle metrics. I have updated the KIP

Re: [DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-20 Thread Kevin Lu
Hi Jason, That is a good point in making the ratio metric consistent with the broker idle metrics. I have updated the KIP to calculate the poll idle ratio as you suggested. Thanks for pointing this out. Regards, Kevin On Fri, Sep 20, 2019 at 10:09 AM Jason Gustafson wrote: > Hi Kevin, > >

Re: [DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-20 Thread Jason Gustafson
Hi Kevin, For the computation of the idle ratio, can we make it consistent with the idle ratios on the broker? Basically we use the following: idle ratio = idle time / total time So when the consumer is idle (i.e waiting for records), then the idle ratio approaches 1. When the application is

Re: [DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-17 Thread Satish Duggana
Hi Kevin, Thanks for adding useful metrics with the KIP. On Wed, 18 Sep, 2019, 1:49 AM Kevin Lu, wrote: > Hi Manikumar, > > Thanks for the support. > > Since we have added a couple additional metrics, I have renamed the KIP > title to reflect the content better: KIP-517: Add consumer metrics

Re: [DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-17 Thread Kevin Lu
Hi Manikumar, Thanks for the support. Since we have added a couple additional metrics, I have renamed the KIP title to reflect the content better: KIP-517: Add consumer metrics to observe user poll behavior

Re: [DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-17 Thread Manikumar
Hi Kevin, Thanks for the KIP. LGTM. This will be useful. Thanks, On Mon, Sep 16, 2019 at 10:17 PM Harsha Chintalapani wrote: > Thanks. +1 LGTM. > > > On Mon, Sep 16, 2019 at 9:19 AM, Kevin Lu wrote: > > > Hi Harsha, > > > > Thanks for the feedback. I have added *last-poll-seconds-ago* to

Re: [DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-16 Thread Harsha Chintalapani
Thanks. +1 LGTM. On Mon, Sep 16, 2019 at 9:19 AM, Kevin Lu wrote: > Hi Harsha, > > Thanks for the feedback. I have added *last-poll-seconds-ago* to the KIP > (being consistent with *last-heartbeat-seconds-ago*). > > Regards, > Kevin > > On Sat, Sep 14, 2019 at 9:44 AM Harsha Chintalapani >

Re: [DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-16 Thread Kevin Lu
Hi Harsha, Thanks for the feedback. I have added *last-poll-seconds-ago* to the KIP (being consistent with *last-heartbeat-seconds-ago*). Regards, Kevin On Sat, Sep 14, 2019 at 9:44 AM Harsha Chintalapani wrote: > Thanks Kevin for the KIP. Overall LGTM. > On you second point, I think the

Re: [DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-14 Thread Harsha Chintalapani
Thanks Kevin for the KIP. Overall LGTM. On you second point, I think the metric will be really useful to indicate the perf bottlenecks on user code vs kakfa consumer/broker. Thanks, Harsha On Fri, Sep 13, 2019 at 2:41 PM, Kevin Lu wrote: > Hi Radai & Jason, > > Thanks for the support and

Re: [DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-13 Thread Kevin Lu
Hi Radai & Jason, Thanks for the support and suggestion. 1. I think ratio is a good additional metric since the current proposed metrics are only absolute times which may not be useful in all scenarios. I have added this to the KIP: *- poll-idle-ratio*: The fraction of time the consumer

Re: [DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-13 Thread Jason Gustafson
Hi Kevin, This looks reasonable to me. I'd also +1 Radai's suggestion if you're willing. Something like an idle ratio for the consumer would be helpful. Thanks, Jason On Fri, Sep 13, 2019 at 10:08 AM radai wrote: > while youre at it another metric that we have found to be useful is % > time

Re: [DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-13 Thread radai
while youre at it another metric that we have found to be useful is % time spent in user code vs time spent in poll() (so time between poll calls / time inside poll calls) - the higher the % value the more indicative of user code being the cause of performance bottlenecks. On Fri, Sep 13, 2019 at

Re: [DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-13 Thread Kevin Lu
Hi All, Happy Friday! Bumping this. Any thoughts? Thanks. Regards, Kevin On Thu, Sep 5, 2019 at 9:35 AM Kevin Lu wrote: > Hi All, > > I'd like to propose a new consumer metric that measures the time between > calls to poll() for use in issues related to hitting max.poll.interval.ms > due to

[DISCUSS] KIP-517: Add consumer metric indicating time between poll calls

2019-09-05 Thread Kevin Lu
Hi All, I'd like to propose a new consumer metric that measures the time between calls to poll() for use in issues related to hitting max.poll.interval.ms due to long processing time.