Re: [DISCUSS] KIP-525 - Return topic metadata and configs in CreateTopics response

2019-09-19 Thread Rajini Sivaram
Thanks Colin! On Thu, Sep 19, 2019 at 9:54 PM Colin McCabe wrote: > +1 for starting the vote. Thanks, Rajini! > > C. > > On Thu, Sep 19, 2019, at 10:47, Rajini Sivaram wrote: > > Thanks, Colin! That makes sense. I have updated the KIP to use separate > > methods. Can you do take a quick look

Re: [DISCUSS] KIP-525 - Return topic metadata and configs in CreateTopics response

2019-09-19 Thread Colin McCabe
+1 for starting the vote. Thanks, Rajini! C. On Thu, Sep 19, 2019, at 10:47, Rajini Sivaram wrote: > Thanks, Colin! That makes sense. I have updated the KIP to use separate > methods. Can you do take a quick look to see if the KIP is ready for voting? > > Thank you, > > Rajini > > On Thu,

Re: [DISCUSS] KIP-525 - Return topic metadata and configs in CreateTopics response

2019-09-19 Thread Rajini Sivaram
Thanks, Colin! That makes sense. I have updated the KIP to use separate methods. Can you do take a quick look to see if the KIP is ready for voting? Thank you, Rajini On Thu, Sep 19, 2019 at 5:22 PM Colin McCabe wrote: > On Thu, Sep 19, 2019, at 06:31, Rajini Sivaram wrote: > > Hi Colin, > >

Re: [DISCUSS] KIP-525 - Return topic metadata and configs in CreateTopics response

2019-09-19 Thread Colin McCabe
On Thu, Sep 19, 2019, at 06:31, Rajini Sivaram wrote: > Hi Colin, > > Thanks for reviewing the KIP! > > I have added default values for the RPC. Since other int fields seem to be > using -1, I used -1 as the default for NumPartitions and ReplicationFactor. > Thanks. > I think a single method

Re: [DISCUSS] KIP-525 - Return topic metadata and configs in CreateTopics response

2019-09-19 Thread Rajini Sivaram
Hi Colin, Thanks for reviewing the KIP! I have added default values for the RPC. Since other int fields seem to be using -1, I used -1 as the default for NumPartitions and ReplicationFactor. I think a single method that returns TopicConfig seems better because tools that are interested in the

Re: [DISCUSS] KIP-525 - Return topic metadata and configs in CreateTopics response

2019-09-18 Thread Colin McCabe
Hi Rajini, Thanks for the KIP. I think this will be a great improvement. For NumPartitions, ReplicationFactor, and Configs, we need some reasonable default value in the RPC which can be used for requests that are too old to contain this information. I'd suggest 0, 0, and null, respectively.

Re: [DISCUSS] KIP-525 - Return topic metadata and configs in CreateTopics response

2019-09-17 Thread Rajini Sivaram
Hi all, Since this is minor KIP, I will start vote tomorrow if there are no concerns. Thank you, Rajini On Fri, Sep 13, 2019 at 10:17 PM Rajini Sivaram wrote: > Hi all, > > I would like to start discussion on KIP-525 to return topic configs in > CreateTopics response: > >- > >

[DISCUSS] KIP-525 - Return topic metadata and configs in CreateTopics response

2019-09-13 Thread Rajini Sivaram
Hi all, I would like to start discussion on KIP-525 to return topic configs in CreateTopics response: - https://cwiki.apache.org/confluence/display/KAFKA/KIP-525+-+Return+topic+metadata+and+configs+in+CreateTopics+response When validateOnly=false, this will be the actual configs of the