Re: [DISCUSS] KIP-533: Add default api timeout to AdminClient

2019-11-20 Thread Jason Gustafson
This seems not very controversial, so I will go ahead and move to a vote in the next couple days. Thanks, Jason On Wed, Nov 13, 2019 at 10:23 AM Jason Gustafson wrote: > Hey Colin, > > Thanks for the suggestions. I've clarified the use of the API overrides > and the request timeout. > > I think

Re: [DISCUSS] KIP-533: Add default api timeout to AdminClient

2019-11-13 Thread Jason Gustafson
Hey Colin, Thanks for the suggestions. I've clarified the use of the API overrides and the request timeout. I think exponential backoff is a great idea. Can we do a separate KIP for this? I think we can add it to the consumer and producer at the same time. -Jason On Mon, Oct 21, 2019 at 2:01 PM

Re: [DISCUSS] KIP-533: Add default api timeout to AdminClient

2019-10-21 Thread Ismael Juma
Thanks for the KIP, this makes sense to me. It will be good to align the AdminClient better with the consumer and producer when it comes to timeouts. Ismael On Wed, Oct 9, 2019 at 12:06 PM Jason Gustafson wrote: > Hi All, > > I wrote a short KIP to address a longstanding issue with timeout beha

Re: [DISCUSS] KIP-533: Add default api timeout to AdminClient

2019-10-21 Thread Colin McCabe
Hi Jason, Thanks for the KIP. I think this is a long-overdue improvement. It would be good to clarify that the "timeout" values for the options classes will now refer to the API timeouts, not to the request timeouts. I think this is implied by the KIP, but it would be good to spell it out. O

[DISCUSS] KIP-533: Add default api timeout to AdminClient

2019-10-09 Thread Jason Gustafson
Hi All, I wrote a short KIP to address a longstanding issue with timeout behavior in the AdminClient: https://cwiki.apache.org/confluence/display/KAFKA/KIP-533%3A+Add+default+api+timeout+to+AdminClient . Take a look and let me know what you think. Thanks, Jason