Re: [DISCUSS] KIP-55: Secure quotas for authenticated users

2016-08-19 Thread Rajini Sivaram
The PR for this KIP is ready for review. JIRA is https://issues.apache.org/jira/browse/KAFKA-3492, PR is https://github.com/apache/kafka/pull/1753. Thanks, Rajini On Tue, Aug 9, 2016 at 1:06 PM, Rajini Sivaram wrote: > Hi Tom, > > Have updated the KIP wiki. Will submit a PR later this week. >

Re: [DISCUSS] KIP-55: Secure quotas for authenticated users

2016-08-09 Thread Rajini Sivaram
Hi Tom, Have updated the KIP wiki. Will submit a PR later this week. Regards, Rajini On Tue, Aug 9, 2016 at 12:30 PM, Tom Crayford wrote: > Seeing as voting passed on this, can somebody with access update the wiki? > > Is there code for this KIP in a PR somewhere that needs merging? > > Thank

Re: [DISCUSS] KIP-55: Secure quotas for authenticated users

2016-08-09 Thread Tom Crayford
Seeing as voting passed on this, can somebody with access update the wiki? Is there code for this KIP in a PR somewhere that needs merging? Thanks Tom Crayford Heroku Kafka On Friday, 1 July 2016, Rajini Sivaram wrote: > Thank you, Jun. > > Hi all, > > Please let me know if you have any commen

Re: [DISCUSS] KIP-55: Secure quotas for authenticated users

2016-06-07 Thread Rajini Sivaram
Jun, Thank you, I will start a vote. On Tue, Jun 7, 2016 at 8:49 PM, Jun Rao wrote: > Rajini, > > Thanks for the updated wiki. It looks good to me. Do you want to start a > vote on this? > > Jun > > On Fri, May 27, 2016 at 11:47 AM, Rajini Sivaram < > rajinisiva...@googlemail.com> wrote: > > >

Re: [DISCUSS] KIP-55: Secure quotas for authenticated users

2016-06-07 Thread Jun Rao
Rajini, Thanks for the updated wiki. It looks good to me. Do you want to start a vote on this? Jun On Fri, May 27, 2016 at 11:47 AM, Rajini Sivaram < rajinisiva...@googlemail.com> wrote: > Jun, > > Thank you for the review and the suggestions. I have updated the KIP with > the changes you sugge

Re: [DISCUSS] KIP-55: Secure quotas for authenticated users

2016-05-27 Thread Rajini Sivaram
Jun, Thank you for the review and the suggestions. I have updated the KIP with the changes you suggested. On Fri, May 27, 2016 at 5:24 PM, Jun Rao wrote: > Rajini, > > Thanks for the updated KIP. Looks good overall. Just a few minor comments. > > 10. For quota related metric names, currently,

Re: [DISCUSS] KIP-55: Secure quotas for authenticated users

2016-05-27 Thread Jun Rao
Rajini, Thanks for the updated KIP. Looks good overall. Just a few minor comments. 10. For quota related metric names, currently, they already have a tag "client-d". It seems that we can just replace it with a similar tag "user" if quota.type is user. The sensor names only have the client-id valu

Re: [DISCUSS] KIP-55: Secure quotas for authenticated users

2016-05-25 Thread Rajini Sivaram
Hi Aditya, Thank you for the review. When *quota.type=user*, quotas are based on the user principal which may be an authenticated or unauthenticated user. For PLAINTEXT, the principal would be "*anonymous*" by default, but can be overridden by supplying a principal builder. Quotas can be applied t

Re: [DISCUSS] KIP-55: Secure quotas for authenticated users

2016-05-25 Thread Aditya Auradkar
Hey Rajini - If the quota.type is set to 'user', what happens to unauthenticated clients? They don't supply a principal, so are they essentially unthrottled? This may be a nit, but I prefer 'quota.type' options to be 'authenticated-user' and 'client-id' as opposed to 'client' and 'user'. For a ne

Re: [DISCUSS] KIP-55: Secure quotas for authenticated users

2016-05-24 Thread Rajini Sivaram
Jun, I have updated the KIP based on your suggestion. Can you take a look? Thank you, Rajini On Tue, May 24, 2016 at 11:20 AM, Rajini Sivaram < rajinisiva...@googlemail.com> wrote: > Jun, > > Thank you for the review. I agree that a simple user principal based quota > is sufficient to allocate

Re: [DISCUSS] KIP-55: Secure quotas for authenticated users

2016-05-24 Thread Rajini Sivaram
Jun, Thank you for the review. I agree that a simple user principal based quota is sufficient to allocate broker resources fairly in a multi-user system. Hierarchical quotas proposed in the KIP currently enables clients of a user to be rate-limited as well. This allows a user to run multiple clien

Re: [DISCUSS] KIP-55: Secure quotas for authenticated users

2016-05-23 Thread Jun Rao
Rajini, Thanks for the KIP. When we first added the quota support, the intention was to be able to add a quota per application. Since at that time, we don't have security yet. We essentially simulated users with client-ids. Now that we do have security. It seems that we just need to have a way to

Re: [DISCUSS] KIP-55: Secure quotas for authenticated users

2016-05-03 Thread Rajini Sivaram
Ewen, Thank you for the review. I agree that ideally we would have one definition of quotas that handles all cases. But I couldn't quite fit all the combinations that are possible today with client-id-based quotas into the new configuration. I think upgrade path is not bad since quotas are per-bro

Re: [DISCUSS] KIP-55: Secure quotas for authenticated users

2016-04-29 Thread Ewen Cheslack-Postava
Rajini, I'm admittedly not very familiar with a lot of this code or implementation, so correct me if I'm making any incorrect assumptions. I've only scanned the KIP, but my main concern is the rejection of the alternative -- unifying client-id and principal quotas. In particular, doesn't this mak

Re: [DISCUSS] KIP-55: Secure quotas for authenticated users

2016-04-22 Thread Rajini Sivaram
The PR for KAFKA-3492 (https://github.com/apache/kafka/pull/1256) contains the code associated with KIP-55. I will keep it updated during the review process. Thanks, Rajini On Mon, Apr 18, 2016 at 4:41 PM, Rajini Sivaram < rajinisiva...@googlemail.com> wrote: > Hi All, > > I have just created K

[DISCUSS] KIP-55: Secure quotas for authenticated users

2016-04-18 Thread Rajini Sivaram
Hi All, I have just created KIP-55 to support quotas based on authenticated user principals. https://cwiki.apache.org/confluence/display/KAFKA/KIP-55%3A+Secure+Quotas+for+Authenticated+Users Comments and feedback are appreciated. Thank you... Regards, Rajini