Re: [DISCUSS] KIP-605 Expand Connect Worker Internal Topic Settings

2020-05-06 Thread Randall Hauch
Thanks, folks. The KIP appears to be satisfactory, so I plan to start a vote thread tomorrow unless there are objections. Best regards, Randall On Mon, May 4, 2020 at 2:56 PM Christopher Egerton wrote: > Hi Randall, > > Looks great! Definitely in favor of a WARN level message instead of faili

Re: [DISCUSS] KIP-605 Expand Connect Worker Internal Topic Settings

2020-05-04 Thread Christopher Egerton
Hi Randall, Looks great! Definitely in favor of a WARN level message instead of failing on startup. +1 non-binding when the vote thread comes Cheers, Chris On Mon, May 4, 2020 at 12:51 PM Randall Hauch wrote: > Thanks, Chris. > > 1. Added a use case that describes why you might want to use -1

Re: [DISCUSS] KIP-605 Expand Connect Worker Internal Topic Settings

2020-05-04 Thread Randall Hauch
Thanks, Chris. 1. Added a use case that describes why you might want to use -1 for replication factor but want to set other properties. 2&3. Thanks for bringing up these special properties that the worker always sets. I've added an "Excluded properties" column to the table of new properties, and l

Re: [DISCUSS] KIP-605 Expand Connect Worker Internal Topic Settings

2020-05-04 Thread Konstantine Karantasis
Thanks for the KIP Randall! Automatic creation of internal Connect topics has been very useful since KIP-154 and adapting the Connect workers to allow users to transparently use broker defaults will be useful as well. The KIP looks good. Konstantine On Sun, May 3, 2020 at 10:55 AM Christopher Eg

Re: [DISCUSS] KIP-605 Expand Connect Worker Internal Topic Settings

2020-05-03 Thread Christopher Egerton
Hi Randall, Thanks for the KIP! I have a few questions and suggestions but no major objections. 1. The motivation is pretty clear for altering the various "*.storage.replication.factor" properties to allow -1 as a value now. Are there expected use cases for allowing modification of other properti

Re: [DISCUSS] KIP-605 Expand Connect Worker Internal Topic Settings

2020-04-30 Thread Ryanne Dolan
Much needed, thanks. Ryanne On Thu, Apr 30, 2020 at 4:59 PM Randall Hauch wrote: > Hello! > > I'd like to use this thread to discuss KIP-605, which expands some of the > properties that the Connect distributed worker uses when creating internal > topics: > > > https://cwiki.apache.org/confluenc

[DISCUSS] KIP-605 Expand Connect Worker Internal Topic Settings

2020-04-30 Thread Randall Hauch
Hello! I'd like to use this thread to discuss KIP-605, which expands some of the properties that the Connect distributed worker uses when creating internal topics: https://cwiki.apache.org/confluence/display/KAFKA/KIP-605%3A+Expand+Connect+Worker+Internal+Topic+Settings Best regards, Randall