Re: [DISCUSS] KIP-653: Upgrade log4j to log4j2

2022-01-29 Thread Dongjin Lee
Hi Mickael and Luke, Nice catch! Sure, I just updated the KIP document and the PR. As you can see in '8. embedded zookeeper' section, the embedded zookeeper launcher script will show that it does not support the Log4j MBean registration feature anymore. (And then, zookeeper's `ManagedUtil.isLog4jJ

Re: [DISCUSS] KIP-653: Upgrade log4j to log4j2

2022-01-29 Thread Luke Chen
Hi Mickael, Nice catch! I agree that we should mention the zookeeper log4j dependency things in the KIP or upgrade/release notes. Thank you. Luke On Fri, Jan 28, 2022 at 10:35 PM Mickael Maison wrote: > Hi Dongjin, > > Before starting to review the PR, I was doing a bit of research of the > to

Re: [DISCUSS] KIP-653: Upgrade log4j to log4j2

2022-01-28 Thread Mickael Maison
Hi Dongjin, Before starting to review the PR, I was doing a bit of research of the topic and I noticed ZooKeeper actually depends on log4j1. In zookeeper-server, by default a few JMX beans are registered for log4j1. When starting ZooKeeper you get a log line like: INFO Log4j 1.2 jmx support found

Re: [DISCUSS] KIP-653: Upgrade log4j to log4j2

2020-10-21 Thread Dongjin Lee
Hi All, As KIP-653 is now accepted, I hope to start a discussion about its release plan. As all of you know, this proposal has the possibility of a compatibility break, for the changes between log4j and log4j2. To minimize the unexpected consequences, I propose to provide a preview release. 1. K

Re: [DISCUSS] KIP-653: Upgrade log4j to log4j2

2020-09-29 Thread Dongjin Lee
Hi All, As you can see in the PR, I eliminated all compatibility breaks caused by the root logger name change between log4j and log4j2. (i.e., "root" → "") Plus, I rebased the PR onto the latest trunk, with migrating raft module into log4j2. Please have a look. And please note that now we have li

Re: [DISCUSS] KIP-653: Upgrade log4j to log4j2

2020-09-28 Thread Dongjin Lee
> 3. ... For the same reason I call that a bug, I think the description in the KIP is incorrect. Agree, the description in the KIP is written before you open a PR ( https://github.com/apache/kafka/pull/9266) - As you remember, I am participating the review. I think it is a bug and should be fixed.

Re: [DISCUSS] KIP-653: Upgrade log4j to log4j2

2020-09-28 Thread Tom Bentley
Hi Dongjin, Sorry for the late reply. 1. I think translating the name "root" to "" would work fine. 2. The second bullet in the Connect section of the KIP seems to need some translation between null and OFF, similar to the name translation. 3. The third bullet seems to be about logger inheritan

Re: [DISCUSS] KIP-653: Upgrade log4j to log4j2

2020-09-23 Thread Dongjin Lee
Hi Tom, Thanks for the detailed analysis. Recently, I was also thinking about API compatibility. I initially thought that the difference between the root logger name would break the compatibility (as the KIP states), it seems like I found a workaround: 1. When the user requests arrive, regard the

Re: [DISCUSS] KIP-653: Upgrade log4j to log4j2

2020-09-23 Thread Tom Bentley
Hi Dongjin, I'd like to see this feature, but if I understand correctly, the KIP in its current form breaks a couple of Kafka APIs. For Kafka Connect it says "From log4j2, the name of the root logger becomes empty string from 'root'. It impacts Kafka connect's dynamic logging control feature. (And

Re: [DISCUSS] KIP-653: Upgrade log4j to log4j2

2020-09-22 Thread Dongjin Lee
Hi devs, I updated the KIP with the migration plan I discussed with Ismael. I think 2.7.0 is the perfect time for starting migration into log4j2. If we miss this opportunity, the migration would be much harder. So please have a look at this proposal. I also opened a voting thread for this. Than

Re: [DISCUSS] KIP-653: Upgrade log4j to log4j2

2020-09-16 Thread Dongjin Lee
Hi Ismael, > Have we considered switching to the log4j2 logging config format by default and providing a mechanism to use the old format? As of present, the proposal leaves the default config format switching to sometime in the future. However, I think it is not a difficult task and is up to the

Re: [DISCUSS] KIP-653: Upgrade log4j to log4j2

2020-09-16 Thread Ismael Juma
Thanks for the KIP, Dongjin. Have we considered switching to the log4j2 logging config format by default and providing a mechanism to use the old format? It is likely that we will release 3.0 as the release after 2.7, so it would provide a good opportunity to move on from the legacy config format.

Re: [DISCUSS] KIP-653: Upgrade log4j to log4j2

2020-09-16 Thread Dongjin Lee
Is there anyone who has suggestions or comments on this feature? Thanks, Dongjin On Wed, Aug 5, 2020 at 11:37 PM Dongjin Lee wrote: > Hi, Kafka dev, > > I hope to initiate the discussion of KIP-653, upgrading log4j to log4j2. > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-653%3A+Up

[DISCUSS] KIP-653: Upgrade log4j to log4j2

2020-08-05 Thread Dongjin Lee
Hi, Kafka dev, I hope to initiate the discussion of KIP-653, upgrading log4j to log4j2. https://cwiki.apache.org/confluence/display/KAFKA/KIP-653%3A+Upgrade+log4j+to+log4j2 All kinds of feedbacks are greatly appreciated! Best, Dongjin -- *Dongjin Lee* *A hitchhiker in the mathematical world.