Thanks for the comets Matthias.
I respond inline below.
Thanks,
walker
On Sat, Dec 19, 2020 at 11:35 AM Matthias J. Sax wrote:
> Overall LGTM.
>
> A few minor comments:
>
> > The SHUTDOWN_CLIENT option in the Streams Uncaught Exception Handler
> should leave the client state in ERROR instead
Overall LGTM.
A few minor comments:
> The SHUTDOWN_CLIENT option in the Streams Uncaught Exception Handler should
> leave the client state in ERROR instead of NOT_RUNNING
and
> In order to be consistent, SHUTDOWN_CLIENT will leave the client state in
> ERROR instead of NOT_RUNNING
Both
Thanks for the KIP, Walker!
The KIP looks good to me. I have just a minor comment about the KIP
document.
You talk about SHUTDOWN_CLIENT in the KIP, but never explain that it is
a possible action that can be taken in the Streams uncaught exception
handler. Could you please clarify that?
Thanks for the comments. If there are no further concerns I would like to
call for a vote on KIP-696 to clarify and clean up the Streams State
Machine.
walker
On Wed, Dec 9, 2020 at 8:50 AM John Roesler wrote:
> Thanks, Walker!
>
> Your proposal looks good to me.
>
> -John
>
> On Tue,
Thanks, Walker!
Your proposal looks good to me.
-John
On Tue, 2020-12-08 at 18:29 -0800, Walker Carlson wrote:
> Thanks for the feedback Guozhang!
>
> I clarified some of the points in the Proposed Changes section so hopefully
> it will be more clear what is going on now. I also agree with
Thanks for the feedback Guozhang!
I clarified some of the points in the Proposed Changes section so hopefully
it will be more clear what is going on now. I also agree with your
suggestion about the possible call to close() on ERROR so I added this
line.
"Close() called on ERROR will be idempotent
Hello Walker,
Thanks for the KIP! Overall it looks reasonable to me. Just a few minor
comments for the wiki page itself:
1) Could you clarify the conditions when RUNNING / REBALANCING ->
PENDING_ERROR will happen; and when PENDING_ERROR -> ERROR will happen.
E.g. when I read "Streams will only
Hello all,
I'd like to propose KIP-696 to clarify the meaning of ERROR state in the
KafkaStreams Client State Machine. This will update the States to be
consistent with changes in KIP-671 and KIP-663.
Here are the details: https://cwiki.apache.org/confluence/x/lCvZCQ
Thanks,
Walker
