Re: [DISCUSS] KIP-745: Connect API to restart connector and tasks

2021-06-07 Thread Randall Hauch
Thanks, Konstantine. I've incorporated your suggestion about the `tick()` mention, and it sounds like my recent changes satisfy all of your other concerns (which seem relatively minor). So I'll go ahead and start a vote and we can continue to fine tune the wording. Best regards, Randall On Mon,

Re: [DISCUSS] KIP-745: Connect API to restart connector and tasks

2021-06-07 Thread Konstantine Karantasis
Thanks Randall. I reply inline as well. On Sat, Jun 5, 2021 at 1:57 PM Randall Hauch wrote: > Thanks for the review and feedback, Konstantine. I think I've addressed all > of your concerns below. > > On Fri, Jun 4, 2021 at 7:55 PM Konstantine Karantasis > wrote: > > > Thanks for the KIP

Re: [DISCUSS] KIP-745: Connect API to restart connector and tasks

2021-06-05 Thread Randall Hauch
Thanks for the review and feedback, Konstantine. I think I've addressed all of your concerns below. On Fri, Jun 4, 2021 at 7:55 PM Konstantine Karantasis wrote: > Thanks for the KIP Randall! > Really happy to see this feature coming along finally. Will indeed resolve > an unintuitive aspect of

Re: [DISCUSS] KIP-745: Connect API to restart connector and tasks

2021-06-04 Thread Konstantine Karantasis
Thanks for the KIP Randall! Really happy to see this feature coming along finally. Will indeed resolve an unintuitive aspect of Connect's REST API. I'm in favor of the current approach overall. Just a few comments below that could use a brief discussion: 1) Is there a specific reason why you

Re: [DISCUSS] KIP-745: Connect API to restart connector and tasks

2021-06-03 Thread Kalpesh Patel
Agreed, this would be a great enhancement. On Thu, Jun 3, 2021 at 9:26 AM Nikita Kretov wrote: > Hello! It's really not intuitive that you need to restart connect and > tasks separately! I'd like to see this KIP landed in 3.0.0 release! > > On 6/2/21 7:40 PM, Randall Hauch wrote: > > Hello all,

Re: [DISCUSS] KIP-745: Connect API to restart connector and tasks

2021-06-03 Thread Nikita Kretov
Hello! It's really not intuitive that you need to restart connect and tasks separately! I'd like to see this KIP landed in 3.0.0 release! On 6/2/21 7:40 PM, Randall Hauch wrote: Hello all, Many users struggle with the connector restart REST API only restarting the Connector instance rather

Re: [DISCUSS] KIP-745: Connect API to restart connector and tasks

2021-06-02 Thread Ryanne Dolan
Thanks Randall, this would be great! Ryanne On Wed, Jun 2, 2021 at 11:40 AM Randall Hauch wrote: > Hello all, > > Many users struggle with the connector restart REST API only restarting the > Connector instance rather than everything they associated with a "named" > connector. I've created a

[DISCUSS] KIP-745: Connect API to restart connector and tasks

2021-06-02 Thread Randall Hauch
Hello all, Many users struggle with the connector restart REST API only restarting the Connector instance rather than everything they associated with a "named" connector. I've created a KIP that attempts to solve this problem via new query parameters on an existing REST API method, though by