Re: [DISCUSS] KIP-797 Accept duplicate listener on port for IPv4/IPv6

2021-11-18 Thread Matthew de Detrich
Hi Luke, Thanks for the response, I have removed the PR link in the KIP (it was already in the JIRA issue) and I have also updated the code that generates the documentation for https://kafka.apache.org/documentation/#brokerconfigs_listeners (I also added an example of an IPv4+IPv6 listener configu

Re: [DISCUSS] KIP-797 Accept duplicate listener on port for IPv4/IPv6

2021-11-18 Thread Luke Chen
Hi Matthew, Thanks for the update. The "listener" config description should also be updated: https://kafka.apache.org/documentation/#brokerconfigs_listeners We stated: Listener names and port numbers must be unique. It'll be wrong after this KIP. Also, the PR link should not be put onto the KIP.

Re: [DISCUSS] KIP-797 Accept duplicate listener on port for IPv4/IPv6

2021-11-18 Thread Matthew de Detrich
Hi Luke, I have updated the KIP to make it clear that we are only talking about listeners and not advertised listeners. I have also updated/rebased the PR at https://github.com/apache/kafka/pull/11478 to add upgrade notes about the suggested change. I am not sure if there is an additional place wh

Re: [DISCUSS] KIP-797 Accept duplicate listener on port for IPv4/IPv6

2021-11-17 Thread Luke Chen
Hi Matthew, Thanks for the KIP. I have a question: If I remembered correctly, the "advertised listeners" already support duplicated ports, so your KIP should only focus on "listeners" configuration, is that right? If so, could you please make it clear in KIP, to mention that your change only apply

Re: [DISCUSS] KIP-797 Accept duplicate listener on port for IPv4/IPv6

2021-11-16 Thread Matthew de Detrich
Since no one has commented on either this thread or the original one I will summon a vote by the end of this week. Regards On Wed, Nov 10, 2021 at 5:28 PM Matthew de Detrich < matthew.dedetr...@aiven.io> wrote: > Hello everyone, > > I would like to start a discussion for KIP-797 which is about a

[DISCUSS] KIP-797 Accept duplicate listener on port for IPv4/IPv6

2021-11-10 Thread Matthew de Detrich
Hello everyone, I would like to start a discussion for KIP-797 which is about allowing duplicate listeners on the same port in the specific case where one host is an IPv4 address and the other host is an IPv6 address. The proposal is here https://cwiki.apache.org/confluence/pages/viewpage.action?