Hi Ismael,
The last option you suggested seems like a good tradeoff, I've updated
the KIP to follow this idea.
Thanks,
Mickael
On Mon, May 2, 2022 at 10:32 PM Ismael Juma wrote:
>
> The other option would be to add a deprecated config that then goes away in
> AK 4.0. Something like
The other option would be to add a deprecated config that then goes away in
AK 4.0. Something like "auto.include.jmx.reporter" and set it to `true` by
default. In 4.0, the default would effectively switch to `false` and the
config would be removed. Anyone with a config that would _change_ after
Hi Ismael,
Thanks for the feedback.
Kafka 4.0 still feels a bit far away. This is not really urgent so I
guess we could wait and save us adding a new configuration setting.
Thanks,
Mickael
On Mon, May 2, 2022 at 6:12 PM Ismael Juma wrote:
>
> Hi Mickael,
>
> I think Federico is suggesting that
Hi Mickael,
I think Federico is suggesting that we would do this in AK 4.0 and hence
the breaking change (with the appropriate deprecation period) would be
possible. I personally prefer that option too. Is there an urgent need to
do this before 4.0?
Ismael
On Mon, May 2, 2022 at 8:58 AM Mickael
HI Federico,
Thanks for taking a look.
I think the method you suggest is what I included in the rejected
alternatives section. The reason I rejected it is because it would
force people to change their configuration in order to preserve the
current behavior, hence a breaking change.
Thanks,
Hi Mickael, what about setting the default value to JmxReporter while
also maintaining the old behavior? When a user is setting
metric.reporters without explicitly including the JmxReporter, we
could simply print a warning message which says "The automatic
addition of the JmxReporter is
Hi,
I've created a small KIP to allow disabling JMXreporter:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-830%3A+Allow+disabling+JMX+Reporter
Let me know if you have any feedback.
Thanks,
Mickael
