Re: [DISCUSS] KIP-853: KRaft Voters Change

2024-01-29 Thread José Armando García Sancio
Hi all, This DISCUSS thread was continue in a new thread at: [DISCUSS] KIP-853: KRaft Controller Membership Changes: https://lists.apache.org/thread/6o3sjvcb8dx1ozqfpltb7p0w76b4nd46 Thanks! -- -José

Re: [DISCUSS] KIP-853: KRaft Voters Change

2023-12-20 Thread Josep Prat
Hi Jose, Thanks for the update. Best, Josep Prat Open Source Engineering Director, aivenjosep.p...@aiven.io | +491715557497 | aiven.io Aiven Deutschland GmbH Alexanderufer 3-7, 10117 Berlin Geschäftsführer: Oskari Saarenmaa & Hannu Valtonen Amtsgericht Charlottenburg, HRB 209739 B On Wed, Dec

Re: [DISCUSS] KIP-853: KRaft Voters Change

2023-12-20 Thread José Armando García Sancio
Yes. I have been working on the KIP. I don't expect to change too much from what is currently documented. I am mainly focusing on improving the UX and readability of the KIP. I am hoping to be able to restart the discussion first thing next year. Thanks On Wed, Dec 20, 2023 at 6:11 AM Josep Prat

Re: [DISCUSS] KIP-853: KRaft Voters Change

2023-12-20 Thread Josep Prat
Hi Jose, Did you have any time to update the KIP? Let me know if we can help in any way. Thanks in advance, On Mon, Nov 27, 2023 at 7:04 PM José Armando García Sancio wrote: > On Mon, Nov 27, 2023 at 2:32 AM Josep Prat wrote: > > I wanted to revive this thread and see if there is anything prev

Re: [DISCUSS] KIP-853: KRaft Voters Change

2023-11-27 Thread José Armando García Sancio
On Mon, Nov 27, 2023 at 2:32 AM Josep Prat wrote: > I wanted to revive this thread and see if there is anything preventing it to > be voted on. Happy to help unblocking anything that might be holding this > back. Hi Josep, Thanks for reviving the thread. I need to make some changes to the KIP.

Re: [DISCUSS] KIP-853: KRaft Voters Change

2023-11-27 Thread Josep Prat
Hi community, I wanted to revive this thread and see if there is anything preventing it to be voted on. Happy to help unblocking anything that might be holding this back. Best, Josep Prat On 2022/07/27 15:08:24 José Armando García Sancio wrote: > Hi all, > > Community members Jason Gustafson, C

Re: [DISCUSS] KIP-853: KRaft Voters Change

2022-07-27 Thread José Armando García Sancio
Hi all, Community members Jason Gustafson, Colin P. McCabe and I have been having some offline conversations. At a high-level KIP-853 solves the problems: 1) How can KRaft detect and recover from disk failures on the minority of the voters? 2) How can KRaft support a changing set of voter nodes?

Re: [DISCUSS] KIP-853: KRaft Voters Change

2022-07-27 Thread Jack Vanlightly
Hi Jose, It's looking good! > I think that when a replica has caught up is an implementation detail > and we can have this detailed discussion in Jira or the PR. What do > you think? Yes, that sounds fine. For what it's worth, making the leader take the decision of when an observer is caught-up

Re: [DISCUSS] KIP-853: KRaft Voters Change

2022-07-25 Thread José Armando García Sancio
Thanks for the feedback Colin. I updated the KIP with your suggestions and replied to your comments below. Colin McCabe wrote: > 1. It seems like the proposal is to have a UUID per partition directory on > the voter. If I understand correctly, this is sometimes referred to as > "VoterUUID" and s

Re: [DISCUSS] KIP-853: KRaft Voters Change

2022-07-22 Thread José Armando García Sancio
Jack Vanlightly wrote: > - Regarding the removal of voters, when a leader appends a > RemoveVoterRecord to its log, it immediately switches to the new > configuration. There are two cases here: > 1. The voter being removed is the leader itself. The KIP documents that > the followers will contin

Re: [DISCUSS] KIP-853: KRaft Voters Change

2022-07-22 Thread José Armando García Sancio
Thanks Niket for your feedback. I have made changes to the KIP and replied to your comments below. Niket Goel wrote: > > This UUID will be generated once and persisted as part of the quorum state > > for the topic partition > Do we mean that it will be generated every time the disk on the replic

Re: [DISCUSS] KIP-853: KRaft Voters Change

2022-07-22 Thread José Armando García Sancio
Tom Bentley wrote: > Thanks for the KIP. As Justine mentioned, this KIP currently lacks a > motivation, and nor does the JIRA provide any context. Please could you > provide this context, otherwise it's impossible for people on this list to > understand the problem you're trying to solve here. Jus

Re: [DISCUSS] KIP-853: KRaft Voters Change

2022-07-22 Thread Tom Bentley
Hi José, Thanks for the KIP. As Justine mentioned, this KIP currently lacks a motivation, and nor does the JIRA provide any context. Please could you provide this context, otherwise it's impossible for people on this list to understand the problem you're trying to solve here. Many thanks, Tom O

Re: [DISCUSS] KIP-853: KRaft Voters Change

2022-07-21 Thread Colin McCabe
Hi José, Thanks for the KIP! I have not had time to fully digest it, but I had some initial questions: 1. It seems like the proposal is to have a UUID per partition directory on the voter. If I understand correctly, this is sometimes referred to as "VoterUUID" and sometimes as "ReplicaUUID." T

Re: [DISCUSS] KIP-853: KRaft Voters Change

2022-07-21 Thread Jack Vanlightly
Hi Jose, Thanks for getting this started. Some comments: - Regarding the removal of voters, when a leader appends a RemoveVoterRecord to its log, it immediately switches to the new configuration. There are two cases here: 1. The voter being removed is the leader itself. The KIP documents that

Re: [DISCUSS] KIP-853: KRaft Voters Change

2022-07-21 Thread Justine Olshan
Hey Jose -- this seems like an important KIP! And I enjoy seeing more Uuid usage :) I was curious a bit more about the motivation here. That section seems to be missing. Thanks for sharing the KIP! Justine On Thu, Jul 21, 2022 at 10:30 AM Niket Goel wrote: > Hey Jose, > > Thanks for the KIP. Th

Re: [DISCUSS] KIP-853: KRaft Voters Change

2022-07-21 Thread Niket Goel
Hey Jose, Thanks for the KIP. This is a good improvement and will make the KRaft implementation much more robust in the face of failures and generally make it more flexible for users. I did a first pass through the KIP and here are some comments (some of these might just be a little uninformed

[DISCUSS] KIP-853: KRaft Voters Change

2022-07-21 Thread José Armando García Sancio
Hi all, I would like to start the discussion on my design to support dynamically changing the set of voters in the KRaft cluster metadata topic partition. KIP URL: https://cwiki.apache.org/confluence/x/nyH1D Thanks! -José