GitHub user Xaelias opened a pull request:
https://github.com/apache/kafka/pull/2665
MINOR: Let MirrorMaker pick up client.id if specified in consumer.properties
With this change, defining client.id in the consumer.properties used by
mirror
maker will no longer be ignored.
If not specified, the default will still be the group id.
----
Hi!
For reasons I won't get into here, we needed to change the client.id of our
mirror maker consumers. We quickly realized that the config was not picked up,
and looking at the code it became obvious why: it defaults to the groupId
without checking for a clientId.
Hence this small change.
PS: Ran unit tests successfully.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Xaelias/kafka
MirrorMaker/Use_client.id_if_defined_in_consumer.properties
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2665.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2665
----
commit 988595babc7b347a1706db0bf67ac02fb6c2edf6
Author: Alexis Lesieur <alesi...@signal.co>
Date: 2017-03-09T21:54:12Z
MINOR: Let MirrorMaker pick up client.id if specified in consumer.properties
With this change, defining client.id in the consumer.properties used by
mirror
maker will no longer be ignored.
If not specified, the default will still be the group id.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
