[VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-12 Thread Hu Xi
间: 2017年12月11日 12:19 收件人: dev@kafka.apache.org 主题: Re: 答复: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer The by-laws ask for 72 hours only, since the starting of the vote, and since you have three binding votes you can close this voting now. Please

答复: 答复: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-11 Thread Hu Xi
发件人: Mickael Maison 发送时间: 2017年12月11日 18:17 收件人: dev@kafka.apache.org 主题: Re: 答复: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer Sorry to only raise this now, but should we also update the kafka-consumer-groups tool to display

Re: 答复: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-11 Thread Mickael Maison
hild of the client-level >> > "records-lead-min", but it seems that whether doing that way takes no >> > effects on what this KIP gonna do, so is it a must? >> > >> > >> > 发件人: Guozhang Wang >> > 发送时间: 2

Re: 答复: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-10 Thread Guozhang Wang
t;, but it seems that whether doing that way takes no > > effects on what this KIP gonna do, so is it a must? > > > > ________________________ > > 发件人: Guozhang Wang > > 发送时间: 2017年12月6日 15:05 > > 收件人: dev@kafka.apache.org > > 主题: Re: [VOTE] KIP-223 - Add per-topic min lead and per-partitio

答复: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-10 Thread Hu Xi
Guozhang Wang > 发送时间: 2017年12月6日 15:05 > 收件人: dev@kafka.apache.org > 主题: Re: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead > metrics to KafkaConsumer > > Hello Xi, > > You can see that in o.a.k.common.metrics.Sensor, we allow constructors to > pass in

Re: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-06 Thread Becket Qin
s. I am not sure if I fully understand > the > > > parent metrics here. This KIP will introduce a client-level metric > named > > > 'records-lead-min' and three per-partition metrics tagged with > > > topic&partition. Is it the child-parent relationship

Re: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-06 Thread Guozhang Wang
12月6日 15:05 > 收件人: dev@kafka.apache.org > 主题: Re: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead > metrics to KafkaConsumer > > Hello Xi, > > You can see that in o.a.k.common.metrics.Sensor, we allow constructors to > pass in one or more "parent"

[VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-06 Thread Hu Xi
it a must? 发件人: Guozhang Wang 发送时间: 2017年12月6日 15:05 收件人: dev@kafka.apache.org 主题: Re: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer Hello Xi, You can see that in o.a.k.common.metrics.Sensor, we allow constructors to pass in one or more "par

Re: 答复: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-05 Thread Guozhang Wang
l introduce a client-level metric named > 'records-lead-min' and three per-partition metrics tagged with > topic&partition. Is it the child-parent relationship you mean? > > > > 发件人: Guozhang Wang > 发送时间: 2017年12月5日 15:16 > 收件人:

答复: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-04 Thread Hu Xi
nship you mean? 发件人: Guozhang Wang 发送时间: 2017年12月5日 15:16 收件人: dev@kafka.apache.org 主题: Re: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer Thanks Hu Xi, I made a pass over the KIP and it lgtm. +1. Just a clarification question:

Re: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-04 Thread Guozhang Wang
Thanks Hu Xi, I made a pass over the KIP and it lgtm. +1. Just a clarification question: for the cross-partition "records-lead-min" metric, would that be implemented as a parent metric of the per-partition metrics? Guozhang On Mon, Dec 4, 2017 at 3:07 PM, Dong Lin wrote: > +1 (non-binding)

Re: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-04 Thread Dong Lin
+1 (non-binding) On Wed, Nov 29, 2017 at 7:05 PM, Hu Xi wrote: > Hi all, > > As I didn't see any further discussion around this KIP, I'd like to start > voting. > > KIP documentation: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 223+-+Add+per-topic+min+lead+and+per-partition+lead

Re: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-12-04 Thread Jun Rao
Hi, Hu, Thanks for the KIP. +1 from me. Jun On Wed, Nov 29, 2017 at 7:05 PM, Hu Xi wrote: > Hi all, > > As I didn't see any further discussion around this KIP, I'd like to start > voting. > > KIP documentation: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 223+-+Add+per-topic+mi

Re: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-30 Thread charly molter
+1 (non-binding) On Thu, Nov 30, 2017 at 9:01 AM, Ted Yu wrote: > +1 > > On Thu, Nov 30, 2017 at 12:56 AM, Manikumar > wrote: > > > +1 (non-binding) > > > > On Thu, Nov 30, 2017 at 8:35 AM, Hu Xi wrote: > > > > > Hi all, > > > > > > As I didn't see any further discussion around this KIP, I'd l

Re: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-30 Thread Ted Yu
+1 On Thu, Nov 30, 2017 at 12:56 AM, Manikumar wrote: > +1 (non-binding) > > On Thu, Nov 30, 2017 at 8:35 AM, Hu Xi wrote: > > > Hi all, > > > > As I didn't see any further discussion around this KIP, I'd like to start > > voting. > > > > KIP documentation: > > > > https://cwiki.apache.org/conf

Re: [VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-30 Thread Manikumar
+1 (non-binding) On Thu, Nov 30, 2017 at 8:35 AM, Hu Xi wrote: > Hi all, > > As I didn't see any further discussion around this KIP, I'd like to start > voting. > > KIP documentation: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 223+-+Add+per-topic+min+lead+and+per-partition+lead

[VOTE] KIP-223 - Add per-topic min lead and per-partition lead metrics to KafkaConsumer

2017-11-29 Thread Hu Xi
Hi all, As I didn't see any further discussion around this KIP, I'd like to start voting. KIP documentation: https://cwiki.apache.org/confluence/display/KAFKA/KIP-223+-+Add+per-topic+min+lead+and+per-partition+lead+metrics+to+KafkaConsumer Cheers, huxihx