[VOTE] KIP-237: More Controller Health Metrics

2017-12-18 Thread Dong Lin
Hi all, Since there are no more outstanding comments, I would like to start voting thread for KIP-237: https://cwiki.apache.org/confluence/display/KAFKA/KIP-237%3A+More+Controller+Health+Metrics The KIP proposes to add a few more metrics to help monitor Kafka Controller health. Thanks, Dong

Re: [VOTE] KIP-237: More Controller Health Metrics

2017-12-21 Thread Dong Lin
Bump up the thread so that we can have these sensors to monitor our Kafka service sooner. On Mon, Dec 18, 2017 at 2:03 PM, Dong Lin wrote: > Hi all, > > Since there are no more outstanding comments, I would like to start voting > thread for KIP-237: https://cwiki.apache.org/confluence/display/KA

Re: [VOTE] KIP-237: More Controller Health Metrics

2018-01-02 Thread Ewen Cheslack-Postava
Dong, Seems like a reasonable addition. +1 (binding) from me. There were some final naming issues in the DISCUSS thread that didn't get follow up. I'm fine with either version of the naming as these are details I think mostly advanced users will be monitoring and both naming arguments are reasona

Re: [VOTE] KIP-237: More Controller Health Metrics

2018-01-03 Thread Jun Rao
Hi, Dong, Thanks for the KIP. +1 Jun On Mon, Dec 18, 2017 at 2:03 PM, Dong Lin wrote: > Hi all, > > Since there are no more outstanding comments, I would like to start voting > thread for KIP-237: > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 237%3A+More+Controller+Health+Metrics

Re: [VOTE] KIP-237: More Controller Health Metrics

2018-01-03 Thread Manikumar
+1 (non-binding) Thanks On Wed, Jan 3, 2018 at 10:48 PM, Jun Rao wrote: > Hi, Dong, > > Thanks for the KIP. +1 > > Jun > > On Mon, Dec 18, 2017 at 2:03 PM, Dong Lin wrote: > > > Hi all, > > > > Since there are no more outstanding comments, I would like to start > voting > > thread for KIP-237:

Re: [VOTE] KIP-237: More Controller Health Metrics

2018-01-03 Thread Becket Qin
+1. Thanks for the KIP. On Wed, Jan 3, 2018 at 9:28 AM, Manikumar wrote: > +1 (non-binding) > > Thanks > > On Wed, Jan 3, 2018 at 10:48 PM, Jun Rao wrote: > > > Hi, Dong, > > > > Thanks for the KIP. +1 > > > > Jun > > > > On Mon, Dec 18, 2017 at 2:03 PM, Dong Lin wrote: > > > > > Hi all, > > >

Re: [VOTE] KIP-237: More Controller Health Metrics

2018-01-04 Thread Mickael Maison
+1 non binding, thanks ! On Thu, Jan 4, 2018 at 4:38 AM, Becket Qin wrote: > +1. Thanks for the KIP. > > On Wed, Jan 3, 2018 at 9:28 AM, Manikumar wrote: > >> +1 (non-binding) >> >> Thanks >> >> On Wed, Jan 3, 2018 at 10:48 PM, Jun Rao wrote: >> >> > Hi, Dong, >> > >> > Thanks for the KIP. +1 >

Re: [VOTE] KIP-237: More Controller Health Metrics

2018-01-04 Thread Dong Lin
Thanks to everyone who voted or provided feedback! This KIP is now adopted with 3 binding +1s (Ewen, Jun, Becket) and 2 non-binding +1s (Manikumar, Mickael) On Thu, Jan 4, 2018 at 6:05 AM, Mickael Maison wrote: > +1 non binding, thanks ! > > On Thu, Jan 4, 2018 at 4:38 AM, Becket Qin wrote: >