+1 from myself as well.
I'm closing this thread with the tally below:
binding +1: 3 (Damian, Matthias, myself)
non-binding +1: 3 (Ted, Bill, John)
Thanks for everyone's votes!
Guozhang
On Fri, Jun 29, 2018 at 1:15 PM, Matthias J. Sax
wrote:
> Thx. That makes sense. Just want to make sure t
Thx. That makes sense. Just want to make sure the KIP clearly covers it.
+1 (binding)
I am only +1 because I think that there are no users customizing a
session store supplier. This KIP goes into 2.1 what is a minor release
that should not contain any breaking changes. We need to be careful wit
Thanks Matthias, thanks for the comments! Ack on all of them and have
updated the wiki:
https://cwiki.apache.org/confluence/display/KAFKA/KIP-330:+Add+retentionPeriod+in+SessionBytesStoreSupplier
Regarding the impact of this KIP, here's what I'm thinking:
1. For users of DSL, with customized se
The KIP says:
> In WindowBytesStoreSupplier, we will add:
Should it be `SessionBytesStoreSupplier` ?
What do you mean by
> Users customizing the SessionBytesStoreSupplier should not implement
this function.
From my understanding, this is a breaking change for all users
implementing a custom `
+1
On Thu, Jun 28, 2018 at 4:39 AM Damian Guy wrote:
> +1
>
> On Thu, 28 Jun 2018 at 02:16 Ted Yu wrote:
>
> > +1
> >
> > On Wed, Jun 27, 2018 at 4:40 PM, Bill Bejeck wrote:
> >
> > > +1
> > >
> > > -Bill
> > >
> > > On Wed, Jun 27, 2018 at 7:39 PM Guozhang Wang
> > wrote:
> > >
> > > > Hello
+1
On Thu, 28 Jun 2018 at 02:16 Ted Yu wrote:
> +1
>
> On Wed, Jun 27, 2018 at 4:40 PM, Bill Bejeck wrote:
>
> > +1
> >
> > -Bill
> >
> > On Wed, Jun 27, 2018 at 7:39 PM Guozhang Wang
> wrote:
> >
> > > Hello folks,
> > >
> > > I'd like to start a voting thread on KIP-330. I've intentionally
>
+1
On Wed, Jun 27, 2018 at 4:40 PM, Bill Bejeck wrote:
> +1
>
> -Bill
>
> On Wed, Jun 27, 2018 at 7:39 PM Guozhang Wang wrote:
>
> > Hello folks,
> >
> > I'd like to start a voting thread on KIP-330. I've intentionally skipped
> > the discuss phase since it is a pretty straight-forward public A
+1
-Bill
On Wed, Jun 27, 2018 at 7:39 PM Guozhang Wang wrote:
> Hello folks,
>
> I'd like to start a voting thread on KIP-330. I've intentionally skipped
> the discuss phase since it is a pretty straight-forward public API change
> and should actually be added since day one. The bug fix of KAFK
Hello folks,
I'd like to start a voting thread on KIP-330. I've intentionally skipped
the discuss phase since it is a pretty straight-forward public API change
and should actually be added since day one. The bug fix of KAFKA-7071
helped us to discover this overlook.
--
-- Guozhang
