Re: [VOTE] KIP-340: Allow kafka-reassign-partitions.sh and kafka-log-dirs.sh to take admin client property file

2018-07-21 Thread Dong Lin
Thanks to everyone who voted and provided feedback! This KIP is now adopted with 3 binding +1s (Jason, Joel, Dong) and 1 non-binding +1 (Ted). Regards, Dong On Fri, Jul 20, 2018 at 11:20 PM, Joel Koshy wrote: > +1 > > On Tue, Jul 17, 2018 at 1:42 PM, Ted Yu wrote: > > > +1 > > > > On Tue,

Re: [VOTE] KIP-340: Allow kafka-reassign-partitions.sh and kafka-log-dirs.sh to take admin client property file

2018-07-21 Thread Joel Koshy
+1 On Tue, Jul 17, 2018 at 1:42 PM, Ted Yu wrote: > +1 > > On Tue, Jul 17, 2018 at 1:40 PM Jason Gustafson > wrote: > > > +1. This is useful (though the naming inconsistencies in the tools are > > vexing, as always). > > > > -Jason > > > > On Tue, Jul 17, 2018 at 12:24 PM, Dong Lin wrote: > >

Re: [VOTE] KIP-340: Allow kafka-reassign-partitions.sh and kafka-log-dirs.sh to take admin client property file

2018-07-17 Thread Ted Yu
+1 On Tue, Jul 17, 2018 at 1:40 PM Jason Gustafson wrote: > +1. This is useful (though the naming inconsistencies in the tools are > vexing, as always). > > -Jason > > On Tue, Jul 17, 2018 at 12:24 PM, Dong Lin wrote: > > > Hi all, > > > > It seems that there is no further concern with the

Re: [VOTE] KIP-340: Allow kafka-reassign-partitions.sh and kafka-log-dirs.sh to take admin client property file

2018-07-17 Thread Jason Gustafson
+1. This is useful (though the naming inconsistencies in the tools are vexing, as always). -Jason On Tue, Jul 17, 2018 at 12:24 PM, Dong Lin wrote: > Hi all, > > It seems that there is no further concern with the KIP-304. I guess it is > time to start the voting thread. > > The KIP can be

[VOTE] KIP-340: Allow kafka-reassign-partitions.sh and kafka-log-dirs.sh to take admin client property file

2018-07-17 Thread Dong Lin
Hi all, It seems that there is no further concern with the KIP-304. I guess it is time to start the voting thread. The KIP can be found at https://cwiki.apache.org/confluence/display/KAFKA/KIP-340%3A+Allow+kafka-reassign-partitions.sh+and+kafka-log-dirs.sh+to+take+admin+client+property+file .